Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Fri, 25 Feb 2022 12:12:41 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ronak Jain <ronak.jain@xilinx.com>
Cc:     michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
        rajan.vaja@xilinx.com, corbet@lwn.net,
        linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
        lakshmi.sai.krishna.potthuri@xilinx.com
Subject: Re: [PATCH v5 3/3] firmware: xilinx: Add sysfs support for feature
 config
Message-ID: <Yhi5qesqaZINe6QS@kroah.com>
References: <20220209082709.32378-1-ronak.jain@xilinx.com>
 <20220209082709.32378-4-ronak.jain@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220209082709.32378-4-ronak.jain@xilinx.com>
Precedence: bulk

On Wed, Feb 09, 2022 at 12:27:09AM -0800, Ronak Jain wrote:
> Add support for sysfs interface for runtime features configuration.
>  The user can configure the features at runtime. First, the user need
>  to select the config id of the supported features and then the user
>  can configure the parameters of the feature based on the config id.
> 
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>

You are adding new sysfs files, without any Documentation/ABI/ entries.
That will cause errors when you run the scripts/get_abi.pl tool, right?

Please fix.

thanks,

greg k-h