Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp720144pxm; Fri, 25 Feb 2022 18:15:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6d7gNVdd7gAhzvLw3JEYe/Ig+ArD9eBNMkH+mJlF3BkUwR8dUTm8DuK9R9YxCCZNoYcYq X-Received: by 2002:a63:de55:0:b0:374:2526:3596 with SMTP id y21-20020a63de55000000b0037425263596mr8642270pgi.592.1645841743878; Fri, 25 Feb 2022 18:15:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645841743; cv=none; d=google.com; s=arc-20160816; b=E0G/AiJrch2JT2NlsTZjzxi9lUwgLF0VA4oNTF6gSpJhlFagqG4VI1p2s2q7NQueKE ghZeCcPNfm59GhSmJWwHrQpQM27QAR1Zv7k3n0n5VEcpL7UBgeGFIp0O6fC3J+MQXVx9 gcbNcdOVDtdprqPSvewVWgDK6VCVvYGG4v++W/04PvTN01iEVf7hM5C9K6ivACkv9a28 BGGqlv4cyyDcv9HSljMEyksS1H1WNsGrddBTPvm/Bg1M+2K/PSF47zWWVJDEIplYw2o6 nprF3mAF61zhbzE8ZP8xum0W6PAvUDBPD/QmyNaVJydYgOe37EOA4/RHMv9MI3D8Gu6Z RBnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=zTIcRnCFBxaQUhB53b5r1gLuh4ciOTg8cJMoIdLi7AU=; b=pM7efB+PGrKfKbiUaYVWXjLrW1JDlBqEzKBSeV5G0MrAvEfTW9mGqwgYV5go1q3CVx Hu7XcXdv/ZDQLhs6tQ6V7oE2YQ7TatRQIG4LIkx9QijaJE4QUyORyZrRyya3kzO46erH o4PlwDgxIOD19gkgLDx7YsilP6n45boEcrPgQCOhs0/VZ/qouM8b8l17SNbdMi8DBpav TI22NpppOVWVOZAk6KqZRa/zvy83gChmHQemast6jZwTuc/b9EyVs5xhegKMVRvQiyGO J5sM60fvDkQJmUSfHkEGv4XrPNABxYzP60QOjMgLLqyrkxRMEUUou47x9vMNpWhgkti7 3law== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="m8uVK/IX"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u9-20020a056a00124900b004f102a1303esi3354493pfi.145.2022.02.25.18.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 18:15:43 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b="m8uVK/IX"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4F8D1F3B6A; Fri, 25 Feb 2022 17:48:58 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbiBZBDm (ORCPT + 99 others); Fri, 25 Feb 2022 20:03:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237110AbiBZBDk (ORCPT ); Fri, 25 Feb 2022 20:03:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80CB51BE138; Fri, 25 Feb 2022 17:03:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B08C61AA0; Sat, 26 Feb 2022 01:03:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A965C340E7; Sat, 26 Feb 2022 01:03:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1645837386; bh=43pC9PdIzse0ZGz/ZNK8Q2fCOABbfYyUP49hGYhr+JA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m8uVK/IXP+hcQZtmdTES0fUSK/NmDeUqxCfezFUmK1NZO/9GClJWz8A5Sq2KgwOnZ bNwqN+Tq9mT436P9e5HntTMXhPo488hm0F7i2/TdRR1lzwjBb55qxhLiwF0rCGouku oiilh/6zQKhlEE2qCeCLWAbFaNbxUYlYWRID6W0g= Date: Fri, 25 Feb 2022 17:03:05 -0800 From: Andrew Morton To: Guillaume Tucker Cc: Shuah Khan , Borislav Petkov , Dave Hansen , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests, x86: fix how check_cc.sh is being invoked Message-Id: <20220225170305.de0aa0dc898ca583d8a83e5c@linux-foundation.org> In-Reply-To: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com> References: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Feb 2022 13:15:43 +0000 Guillaume Tucker wrote: > Add quotes around $(CC) when calling check_cc.sh from a Makefile to > pass the value as a single argument to the script even if it has > several words such as "ccache gcc". Conversely, remove quotes in > check_cc.sh when calling $CC to make it a command with potentially > several arguments again. This changelog describes the fix, but it fails to describe the problem which the patch is fixing! Presumably, we're hitting some form of runtime failure under undescribed circumstances when running selftests. But that's just me reverse-engineering the patch description. And me reverse-engineering stuff is a gloriously unreliable thing. Please spell out the problem.