Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp722313pxm; Fri, 25 Feb 2022 18:19:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqpqgMoN3csIRS/9IGpTrXR4pAtsRpB5/7askJ3sxFUnNmeMheZ95y0cxW3oU8+eRz+PKM X-Received: by 2002:a62:770a:0:b0:4e0:2547:9219 with SMTP id s10-20020a62770a000000b004e025479219mr10397764pfc.43.1645841977041; Fri, 25 Feb 2022 18:19:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645841977; cv=none; d=google.com; s=arc-20160816; b=kEQ1Jdczu/utZ+XF+dE+WwkBmcwAI76tuWlWocJTKGV0PrYRmkBkyPD+dmnOzCA4ri hauemNap79rrveIiSa83a1v1zS+awVVyOjDFw75CbXMv+O/XLBhXKuVD2B91VDYTwgLC HdEw+PC/XRo93f/dLm9kb384/3qjRt0znBR8M6HFeqEJSl6X85YeSOXmHTkJcjPlJhuU IwFj11UEFhDMXHVoZCt11cJXl4XI3huxohDdHwVNmFJwKhRg3HPi8wBIzfBazYWNa4ao o6UNmgFeNVw4BXdbQXMEbursn6TF7QVkvsHGUDBqOn0g8dRrl6yz72uFuJc4Qy2ZqH7d ixJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=H30SvYHja+ZyP4YS9nJgLrUskodT9gKdwIwo55+DWkk=; b=X8nqLf/S0JBWNNCVcA5Gu3Jl0/UkCm1lo39EbrDhVN9L/WbRL4etgRE4BlcnNLvuCT ZHPlJBwMNLPxwV+AphGN9JrGZzKXovXqk4YWT+nGHXKGraYrNGZ8Uxih5xJ2RmCswUzJ nOEdujLJ4D3ToHCdcWsLjhohUWeN5NdBxqANun5IlybIjW9KdzsP7Srw6v3pfpVfJ7yy 7hjCciVIuV5TbPfUiXLnXPMvSPEoVCuwxUjdNoH+5TxC5psAS71fTuXVLGmE+PGsQdw4 nhUTZUM7FlvC7y8tkAC3z4M8+ewS2zxP4x7jbHc01d5kNRx+lD/4oHLZ5N86GxAK+xo5 WmeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aEtKsCDG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g18-20020a056a001a1200b004f0f1584f01si3027614pfv.123.2022.02.25.18.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 18:19:37 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aEtKsCDG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2E8FC3B02A; Fri, 25 Feb 2022 17:52:01 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242523AbiBYQzs (ORCPT + 99 others); Fri, 25 Feb 2022 11:55:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241873AbiBYQzn (ORCPT ); Fri, 25 Feb 2022 11:55:43 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 082D91E6953; Fri, 25 Feb 2022 08:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645808111; x=1677344111; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=a/2QHHN/ETWTPtmCEfGXBl9buOitSAcfb/bJHn2KyY0=; b=aEtKsCDGlXMH+++MMqQOG1eb2JKVNPnIchpUA7Pn4EeVmtTFyOPlwRi/ Ilqpgpb28m9jcp/DlbzGPESomgkChUTuva5sA8Bd/CpwMwLIOCpEiCyXK SY+EhDyV57W5AxuAssbPuPmd7WJpnYlf68+nnmSnHzAaBxYh35c5nYX5J 4G9npQ7GRcVRdefsQ7RUxdFmxBDwb3wcWifVa0ZiJrMjNwsZ2GkStFihi KW0w9ND5ZznU7vRRj7J6waYsSw+lUmUJBJzoiY8IFPSXLP+3ke3HCu/oz LBIg8XQXetQ5DHTX3pF/QpDYDvKIsrCjaAc+EamfV8irEO+LZGKjzS0YA g==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="250112543" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="250112543" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 08:55:10 -0800 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="640169939" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 08:55:07 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nNdrG-008GpT-3G; Fri, 25 Feb 2022 18:54:18 +0200 Date: Fri, 25 Feb 2022 18:54:17 +0200 From: Andy Shevchenko To: Jia-Ju Bai Cc: ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com, yoshihiro.shimoda.uh@renesas.com, adrian.hunter@intel.com, swboyd@chromium.org, dev@lynxeye.de, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: core: check the return value of wakeup_source_register() Message-ID: References: <20220225121858.25638-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225121858.25638-1-baijiaju1990@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 25, 2022 at 04:18:58AM -0800, Jia-Ju Bai wrote: > The function wakeup_source_register() in mmc_alloc_host() can fail, so > its return value should be checked. NAK. This doesn't explain why this resource must be non-optional. One should not dumbly use the robots. -- With Best Regards, Andy Shevchenko