Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <cc0a9ec0-66b0-9c02-3adb-ea8ed19b6923@blackwall.org>
Date:   Fri, 25 Feb 2022 16:03:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH iproute2-next 1/1] bridge: link: Add command to set port
 in locked mode
Content-Language: en-US
To:     Hans Schultz <schultz.hans@gmail.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org,
        Hans Schultz <schultz.hans+netdev@gmail.com>,
        linux-kernel@vger.kernel.org
References: <20220225114457.2386149-1-schultz.hans+netdev@gmail.com>
 <20220225114457.2386149-2-schultz.hans+netdev@gmail.com>
From:   Nikolay Aleksandrov <razor@blackwall.org>
In-Reply-To: <20220225114457.2386149-2-schultz.hans+netdev@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/02/2022 13:44, Hans Schultz wrote:
> Add support for setting a bridge port in locked mode to use with 802.1X,
> so that only authorized clients are allowed access through the port.
> 
> Syntax: bridge link set dev DEV locked {on, off}
> 
> Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
> ---
>  bridge/link.c                | 13 +++++++++++++
>  include/uapi/linux/if_link.h |  1 +
>  2 files changed, 14 insertions(+)
> 

You should add man page documentation and update iplink_bridge_slave.c
with the new option as well.

Cheers,
 Nik