Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d70b88c0-037e-13fc-667b-de71bf4f0fde@gmail.com>
Date:   Sat, 26 Feb 2022 10:31:51 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/3] docs: pdfdocs: Pull LaTeX preamble part out of
 conf.py
Content-Language: en-US
To:     Jonathan Corbet <corbet@lwn.net>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Akira Yokosawa <akiyks@gmail.com>
References: <aaa9dca1-27c0-c414-77f3-c5587db0cc5b@gmail.com>
 <875yp4kqka.fsf@meer.lwn.net>
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <875yp4kqka.fsf@meer.lwn.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 24 Feb 2022 12:33:25 -0700,
Jonathan Corbet wrote:
> Akira Yokosawa <akiyks@gmail.com> writes:
> 
>> Quote from Jon's remark [1]:
>>
>>     I do notice that Documentation/conf.py is getting large and
>>     unapproachable.  At some future point, it might be nice to pull
>>     all of the latex stuff out into a separate file where it won't
>>     scare people who stumble into it by accident.
>>
>> Pull LaTeX preamble settings added since commit 3b4c963243b1 ("docs:
>> conf.py: adjust the LaTeX document output") out into
>> sphinx/kerneldoc-preamble.sty.
>>
>> It will be copied to the build directory by the added
>> "latex_additional_files" setting in conf.py.
>>
>> As a bonus, LaTeX/TeX code can be maintained without escaping backslashes.
> 
> I've applied the set, thanks.  Still testing the pdfdocs build (and will
> be for some time, naturally)
> 
> One little note, since you mentioned the need for backslash escapes:
> 
>> +# Load kerneldoc specific LaTeX settings
>> +latex_elements['preamble'] += '''
>> +        % Load kerneldoc specific LaTeX settings
>> +	\\input{kerneldoc-preamble.sty}
>> +'''
> 
> You can avoid that problem in Python code with the use of raw strings:
> 
> latex_elements['preamble'] += r'''
>        % Load kerneldoc specific LaTeX settings
>        \input{kerneldoc-preamble.sty}
> '''
> 
> (note the "r" on the first line).  Something for future reference.

Thank you for the tip.

It turns out that I unknowingly used a raw string in commit
77abc2c230b1 ("docs: pdfdocs: One-half spacing for CJK translations").

I think I copy-pasted an example from "extrapackages" key documentation.

Now I understand the use of raw string.
I will convert remaining LaTeX code in conf.py to raw string(s)
when I need to edit it in the future.

        Thanks, Akira

> 
> Thanks,
> 
> jon