Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sunil Kovvuri Goutham <sgoutham@marvell.com>
To:     Wan Jiabing <wanjiabing@vivo.com>, Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "jiabing.wan@qq.com" <jiabing.wan@qq.com>
Subject: RE: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck
 error
Thread-Topic: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced
 coccicheck error
Thread-Index: AQHYKhJxrR9dzEQ5a0aiW/kWobxjsaylfcAA
Date:   Sat, 26 Feb 2022 08:16:56 +0000
Message-ID: <BY3PR18MB4737A9EEA5F59B9089A4306DC63F9@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20220225063901.893274-1-wanjiabing@vivo.com>
In-Reply-To: <20220225063901.893274-1-wanjiabing@vivo.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uSrCJXhIb5SAUd5GToBEB05C0hW0c1WgtBn+b6KQPvJuv+GWWprmsPBP4tYl?=
 =?us-ascii?Q?1HvXFEmoRD5/cDQj8yScTpsuiZqmvQBfZxwKu75fP9v5OLDQ5KwEuxCC8adg?=
 =?us-ascii?Q?se59N6Oa9h61sCgzrk+fiCmE40TAlrYFPTbaRJ4Ozwvr7aIpm9I5PQB3Y6uN?=
 =?us-ascii?Q?pgp4ObhmYkFqeumcu6ooFnfL5vJ8ztMMlROm50v3EN+HQpibYfdjhLa92ov4?=
 =?us-ascii?Q?qARHHc/UhFSCjTNJ948tA9wzAuUrV7YTBY0qwKwt0DHRPBwMfmXVBcuFBrma?=
 =?us-ascii?Q?pumVQmUVJSVwT9WXfZI92afdxk1r48MCoDlS583QtOiKEzeX3igUChqbTwmW?=
 =?us-ascii?Q?npRBHsUvy7sFVRbqF4L5i06cDJq0zPX3+jfEskXi+lthIP8CMPkqWAtns2gY?=
 =?us-ascii?Q?TtAY4akdDup+69FgJ5orgc7dKoMo0BTgMMJgGFXWJc7h+lhA3SMs8o/QD26N?=
 =?us-ascii?Q?gDDgbCcOtNoIqCA+2OymUjcEeqnUd/e67W7cd6FNEkLnVCDa2B2mdIo6OPkc?=
 =?us-ascii?Q?qqiDmepUGyKQw/ZFWrPnf8zkpfSx1hBgSvS0NPmOz3pwayjjzgAwg7AIelQz?=
 =?us-ascii?Q?IMbhAIE1YqYnXd3oHA5S2lP/TxtknXuOMkxSTsQZblwBoeCKgIkInsRj6v+f?=
 =?us-ascii?Q?o52znhZiDW0aqDqmtdXG5i2Y81MACq6hM9bUq+ZABUCC6KHbAzhE9zPyvI1b?=
 =?us-ascii?Q?lxj9Ul+RB+j72yoH0UuZemDeMS6bb8sXKvBpby/vEt1b0HmpY7FXhLEwlzY2?=
 =?us-ascii?Q?yuGvTPmMENvVMbBN6Llh9v8ujJb4QiKEHGLLwfzSB9GfcymlZ9pFEooftQz+?=
 =?us-ascii?Q?zblv/ZWb+fIBdfYpy3pouX+4BJb8Mivpo8kA3dbYuC/E9ThZDNz1jwxcm62H?=
 =?us-ascii?Q?DTD9wCYeLW2zs+OUMgoqgyoi0DEt4csb1AVeQnRXwMn26zZDiNLhBTub9rUV?=
 =?us-ascii?Q?iM9DGESB5dS6xnwZAkXtJaakMjGkLszOWBGZucro3UUl/BKmvfYCu3vIocKq?=
 =?us-ascii?Q?2SwxiTsshHpNny6BpJEg70a1uJ4869Jgrju02utKEKEp6zCNPiI2W9VQKp7H?=
 =?us-ascii?Q?ABf/grQfft3P0H123RL37r6qiuxlhsNn2yDfrXBiVT0BmQH3gpOFz0Lpyk9N?=
 =?us-ascii?Q?0XsJxpZid0qJ+Qwp0hVo4n8EeJNWG/W7oOioQPEih0zukwrTAQCaQWPCOIrv?=
 =?us-ascii?Q?VJ33QhEaXejAaZCvjcQNTg57yjq+ivXkLoeyOC38kd8jvA/iQ9DhBSCJCzlG?=
 =?us-ascii?Q?kw0L7kaZqQNNELrdIQQPqtPNR2aCWmFY6wAzJfQplUtESsp6DiLKbba4NSTp?=
 =?us-ascii?Q?nyzxiihRSSH+1wS2TB5DJ/t2BXNkW7+KKXVbmKKfKuoTuxhb2VcuFuX0nLRg?=
 =?us-ascii?Q?6uXZLSalsHSdFMoDLY3+C2aZSRAJ1fwxYfHJm2BDfDMGyUKNlHj2jfvkaMxL?=
 =?us-ascii?Q?ofLf02ACbG+f0n71qNptWnlyOy0phQglqSPf1vrzkNWfA6D8LFe0nXiN7N9r?=
 =?us-ascii?Q?1DgUziq8xiwnmlSLEQXGfF4ZYBKaqKy4SbaaXxyEsJvjJGYLwzl84lA5civs?=
 =?us-ascii?Q?fALG08MJNdq9IbDGdDhZbpl4A1/sOZgbERFyio2mTKi11cgg3+Bk+/tGVTi3?=
 =?us-ascii?Q?/SQ/7OzDCJT17xWHl4pFM+Q=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 435786a0-30a5-4c11-1371-08d9f9005ac6
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2022 08:16:56.7257
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /en/Gz9Q/Ctn/1fO5O6efgAr8z52olsvRcxLR18438utsWRUTIU6gOyPUPalGMr6KKKUteSGWuTb2qbnBHnWJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB5137
X-Proofpoint-ORIG-GUID: FJvmj8dRLQ_w3mfYM-f5KqVqlAvKlBtK
X-Proofpoint-GUID: FJvmj8dRLQ_w3mfYM-f5KqVqlAvKlBtK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-02-25_11,2022-02-25_01,2022-02-23_01
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Wan Jiabing <wanjiabing@vivo.com>
> Sent: Friday, February 25, 2022 12:09 PM
> To: Matt Mackall <mpm@selenic.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; Sunil Kovvuri Goutham
> <sgoutham@marvell.com>; Wan Jiabing <wanjiabing@vivo.com>; linux-
> crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: jiabing.wan@qq.com
> Subject: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccichec=
k
> error
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Fix following coccicheck warning:
> ./drivers/char/hw_random/cavium-rng-vf.c:182:17-20: ERROR:
> pdev is NULL but dereferenced.
>=20
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/char/hw_random/cavium-rng-vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/char/hw_random/cavium-rng-vf.c
> b/drivers/char/hw_random/cavium-rng-vf.c
> index 6f66919652bf..7c55f4cf4a8b 100644
> --- a/drivers/char/hw_random/cavium-rng-vf.c
> +++ b/drivers/char/hw_random/cavium-rng-vf.c
> @@ -179,7 +179,7 @@ static int cavium_map_pf_regs(struct cavium_rng
> *rng)
>  	pdev =3D pci_get_device(PCI_VENDOR_ID_CAVIUM,
>  			      PCI_DEVID_CAVIUM_RNG_PF, NULL);
>  	if (!pdev) {
> -		dev_err(&pdev->dev, "Cannot find RNG PF device\n");
> +		pr_err("Cannot find RNG PF device\n");
>  		return -EIO;
>  	}
>=20
> --

Thanks for the fix.
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>