Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 26 Feb 2022 16:43:00 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Michal Simek <monstr@monstr.eu>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michal Simek <michal.simek@xilinx.com>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: adc: xilinx-ams: Use
 devm_delayed_work_autocancel() to simplify code
Message-ID: <20220226164300.63b31841@jic23-huawei>
In-Reply-To: <f874a9c7-8d8d-fecc-8fc9-51dcf37cf60b@monstr.eu>
References: <2626e6a057e40cd2271ef0e5f81d12e607bad5b4.1644776929.git.christophe.jaillet@wanadoo.fr>
        <20220220114552.53fedd33@jic23-huawei>
        <f874a9c7-8d8d-fecc-8fc9-51dcf37cf60b@monstr.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 21 Feb 2022 11:02:00 +0100
Michal Simek <monstr@monstr.eu> wrote:

> Hi,
> 
> On 2/20/22 12:45, Jonathan Cameron wrote:
> > On Sun, 13 Feb 2022 19:29:05 +0100
> > Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> >   
> >> Use devm_delayed_work_autocancel() instead of hand writing it. This is
> >> less verbose and saves a few lines of code.
> >>
> >> devm_delayed_work_autocancel() uses devm_add_action() instead of
> >> devm_add_action_or_reset(). This is fine, because if the underlying memory
> >> allocation fails, no work has been scheduled yet. So there is nothing to
> >> undo.
> >>
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>  
> > Looks good to me, but I'd ideally like some input from someone familiar with
> > the driver.  
> 
> Anand told me that the change is fine that's why here is my
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> 
> Jonathan: Anand decided to do change in his carrier that's why that emails won't 
> go through. But I am still around if you need something xilinx/amd to test.
> 
> Thanks,
> Michal

Thanks Michal and best wishes to Anand for whatever comes next!

Applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a quick look before I expose this to linux-next.

Thanks,

Jonathan