Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <fd9710d4-73a1-2b9d-7848-4c6291f6b2e1@roeck-us.net>
Date:   Sat, 26 Feb 2022 07:31:34 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] hwmon: add driver for Aquacomputer Farbwerk 360
Content-Language: en-US
To:     Aleksa Savic <savicaleksa83@gmail.com>
Cc:     linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220221102157.13574-1-savicaleksa83@gmail.com>
 <5fa0a22c-5f55-bd38-8d76-a4ea31898bca@roeck-us.net> <YhpCrNhjfb0E8rLn@fedora>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <YhpCrNhjfb0E8rLn@fedora>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/26/22 07:09, Aleksa Savic wrote:
> Hi,
> 
> On Thu, Feb 24, 2022 at 11:57:47AM -0800, Guenter Roeck wrote:
>> Hi,
>>
>> On 2/21/22 02:21, Aleksa Savic wrote:
>>> This driver exposes hardware temperature sensors of the Aquacomputer
>>> Farbwerk 360 RGB controller, which communicates through a proprietary
>>> USB HID protocol.
>>>
>>> Four temperature sensors are available. If a sensor is not connected,
>>> it will report zeroes. Additionally, serial number and firmware version
>>> are exposed through debugfs.
>>>
>>> This driver has been tested on x86_64.
>>>
>>> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
>>
>> Unless I amm missing something, this driver is quite similar to the
>> d5next driver (drivers/hwmon/aquacomputer_d5next.c), except that there
>> are 4 instead of 1 temperature sensor, the sensor data is in a different place,
>> and there is _only_ temperature data. It should be quite straightforward
>> to merge the two drivers into one, so please  do that.
>>
>> Additional comment inline.
>>
>> Thanks,
>> Guenter
> 
> Yes, it's very similar, I based this one on that. I'll send a patch for
> the original driver. I also have code ready for Aquacomputer Octo (8 fans, 4
> temperature sensors, very similar to all this as well) with PWM write control
> support for the fans. And there is also WIP code for PWM and curve support for
> the D5 Next from contributors on my github repo, though we're working on that.
> 
> Considering that the driver would then contain support for more devices (the D5
> Next and the Farbwerk 360 for now), can it be renamed to just aquacomputer or
> something similar?
> 

We don't normally do that (because the Kconfig symbol is already established)
and just name the driver for the first chip (or, in this case, controller)
it supports.

Guenter