Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Henry Lin <henryl@nvidia.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Mathias Nyman <mathias.nyman@intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] xhci: fix runtime PM imbalance in USB2 resume
Thread-Topic: [PATCH v2] xhci: fix runtime PM imbalance in USB2 resume
Thread-Index: AQHYKhd7AopZ8pn1EUiip/DzNcJli6yj/JuAgAH/8D+AAAgX2g==
Date:   Sat, 26 Feb 2022 16:20:59 +0000
Message-ID: <CH0PR12MB508950A481EA325581A94945AC3F9@CH0PR12MB5089.namprd12.prod.outlook.com>
References: <20220225055311.92447-1-henryl@nvidia.com>
 <20220225071506.22012-1-henryl@nvidia.com> <Yhied+G/K8MndRfk@kroah.com>
 <CH0PR12MB50897BE5D8841C27DD769580AC3F9@CH0PR12MB5089.namprd12.prod.outlook.com>
In-Reply-To: <CH0PR12MB50897BE5D8841C27DD769580AC3F9@CH0PR12MB5089.namprd12.prod.outlook.com>
Accept-Language: en-US, zh-TW
Content-Language: en-US
suggested_attachment_session_id: 7da19dee-a09a-04c0-cf1b-b3089b2e16c1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f5514dfe-9673-4190-bc34-08d9f943f9d3
x-ms-traffictypediagnostic: CH0PR12MB5281:EE_
x-microsoft-antispam-prvs: <CH0PR12MB52810FABEE4A8E57C3BAE44BAC3F9@CH0PR12MB5281.namprd12.prod.outlook.com>
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 5l7NSsGQKbRgy94U2Zzn2zpuAbPz7mLp+S/L3NItXe4CuJbtlrEhCz/b3cULHFxnGGw23vNwwQdbNkLTHCZNnuqmYfvDuEvyIGLJRs05yURu2FsEPU99AD5+kFEDPUr4lkCPvgbiyKmi2ylwj8nt7m75kOTjlFMWCXXu425VLoF4CAcg/2NUc0gF064WsV4MZfBZuk2AXu4/CtfuyWB8a2r3TBsQxa9xA8MXS2GhCp2bb3hsBz/oNqkkh7NWWjI5LP/FNq7IfYaK2sII1nJ5aiqxSWyfqIcPR8JYyJMoQmpR2HPhrgxlAZuX2IHGDfw+aD7JKiqVGnr7tMkXsumqmLSF4Hyh+1E4MFHriBhRE0wlcfUY2FeaL099Y4P1hBNncgmlNEASz0RjEOG3c84TAL2rO4Sm1w5yIRe6yugnl1H/PB1j8HjOwY0t7Lrnsdrt2bSNssEKZzNprP2sInVNTjPMqQIRGxGSoNTjwfABu4SJneRi9GZ1o08j5kqgzQKed+/frG4vfY6SfVQhZY9omAdOXD487eRfANZ5l6xeQeeu6iyOg7ZkLchxlTNxPghQi26vSKqIdKkRtWKIihkYhkm0cu4SBH2XlSKkQRL/Eel50mIxYIRr1xibDTb7l//ZYz9Uap9Xdswrb1wt4cwIvsR/k8BJyiUb81rZ8bxcbecfKNKn0nkTn3zNagF5E+dosS5+swuAiwFggemxm+YXzg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR12MB5089.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(83380400001)(64756008)(8676002)(71200400001)(91956017)(4326008)(122000001)(38070700005)(9686003)(7696005)(53546011)(6506007)(2940100002)(2906002)(186003)(26005)(8936002)(66556008)(52536014)(66446008)(66476007)(5660300002)(76116006)(66946007)(508600001)(316002)(54906003)(6916009)(33656002)(55016003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kVvIPL2SdXHZ39rgn9E8uoZa7Qwpft9YqnxlcibFU2LRdPI9ges1X+fyAmBU?=
 =?us-ascii?Q?qLV+TAS3AGStBTRBkDRcwogCGjc6R3yqp9AMyHbjyfbvU9MpypwjoXC+v2kw?=
 =?us-ascii?Q?6uDq7S+6krfRKXWx5ZP855ERtt5ngARQPbD75m8L96JYN+PXnW2C6FD+1owt?=
 =?us-ascii?Q?Wbi7UEjKFKVBnm0xHrCzfFJqLyKa14BBeE7WCJXSjcsrPQTYL2vmUSkDTbZJ?=
 =?us-ascii?Q?TgCjtQDXcUHOVFN0tz2oIwvLlbGBNremjip/jvUhgXfASfsh++hucmmToDXY?=
 =?us-ascii?Q?Axdq5hsK3dsLrqKsPq5khjJtOsSp9rmJwiaxsNipOa/e6+IAF9aBKYhMpYzO?=
 =?us-ascii?Q?RhK2zWzDpSd7rFHd4X7lk57ZNOXVAhB+k/NKmZxKhCClSTRZqpwSss5iFBLi?=
 =?us-ascii?Q?Akd7aGYrRcK9YUy9tISxuf3WBNDEkypzpJx3MNFegGjRlC3u9LA4c5VBEJqK?=
 =?us-ascii?Q?eSWg+jeBdt0KFM0hpPbsaZhgQc3MXn1m7RkncAOSLCT6fZL6KbTHzen3K4+3?=
 =?us-ascii?Q?hfOomCwrsV2RSFeXm/JKeGb7SYo8bX2zre9AKtzRRLCxD7/MVoZ28Ct+PWIO?=
 =?us-ascii?Q?jBfmcwKRhHtl/QfS9tjLXMCEsyDlc/2oGdUQfyPOUjI2F1HZ802pW4JPklgr?=
 =?us-ascii?Q?rS0rv8GObphSvslLRv2AQXxKBnaA0C+g38zehp9shcuBz/LagfinXhZqln1V?=
 =?us-ascii?Q?PzaZYg9RGinLkzgPel4WjvuT2cLZsVTEqgDRmSSlrtE/5rVnZFbyfrHenh9c?=
 =?us-ascii?Q?Uq9sqvGUgOldwnYlHNqnz3Kwzw+w5oDL47OJAA0Rm5iph/o6B78c13tyJvMl?=
 =?us-ascii?Q?LGcFg+dQ+yU+hdL7B9lVK60G7aULFv81harJPaqf8CMdeHzabb4B1A6kO9lh?=
 =?us-ascii?Q?/TYPMKXeC8pIndjUl9lQGUENKS4G4myibK8xahTsLQCSmlgH79FYrkCJvszQ?=
 =?us-ascii?Q?GLR7KXDUFoOASP5Cm/3zzD15iB3ZXRu/xab+CHIeypCwg91UgRC0pvZqKboA?=
 =?us-ascii?Q?OxhIkTdY5q30aBX6TMPIOwUUaOK4TBiGnMK94Bp/HWTABS/B+BbMHE/mOFaB?=
 =?us-ascii?Q?J9hAJYbo+FEt3kB/wuiZ2Q4fcGgMKjEvHtfVcBriqhcSmm4WcSi7fXrfeO3F?=
 =?us-ascii?Q?w6iHF98uSempHFwSpYU6tqHdCUey08wsUS6ZO9UfJVsP7UsUKCCMuQ6FOH/M?=
 =?us-ascii?Q?Vexv7kRGfEXOkgaV2omLVJV1zOMGVnj+3Ch/tJ9z/AwWVVF5K+2Qt5Oom1lR?=
 =?us-ascii?Q?rWdJAR7O3OE6W75kQhaoJBoO51tsTRjMub7SlOYErgfw0CrLugYc/ZazQ+TA?=
 =?us-ascii?Q?aXkaUdN8TOz82fD60P7oBuuVD8QhXR1QNNv6H7NACFKnq3AX+OfCBbXn5i/L?=
 =?us-ascii?Q?D81g883WogheH/e0VVW3lIJH7elbD/TNlBVC1+uZHK1NykpEIlY6kM4DmLq7?=
 =?us-ascii?Q?CMpHUI/h2khu+1dwG/tg580ERxm0Dz1hb1r5N+/0LYVaMvpIBty0mAVD804O?=
 =?us-ascii?Q?Nvlg//TLx43S69wO1xWxe4ApAaij7a6jN5w4SC76On8RSTJYdhLsxWhe+1B6?=
 =?us-ascii?Q?WabahAC7MSoaHiOgxRh7QHDNtUncch//TEEuhX2b+iVbhGyVHKTo8uNOI4fC?=
 =?us-ascii?Q?qQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5089.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5514dfe-9673-4190-bc34-08d9f943f9d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2022 16:20:59.8538
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0q0ooALH17D+ehoxG9rjMUVNxojxQA/9IeCMahcdDQO9AluyAAb2YV5ySpg37RBvvJKjcS72oPM/iuO4Rik+Gg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5281
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +                       usb_hcd_end_port_resume(&port->rhub->hcd->self,
> +                                               portnum);
Tab indent is broken in this version. Will resend this.

________________________________________
From: Henry Lin <henryl@nvidia.com>
Sent: Sunday, February 27, 2022 12:06 AM
To: Greg KH
Cc: Mathias Nyman; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xhci: fix runtime PM imbalance in USB2 resume

USB2 resume starts with usb_hcd_start_port_resume() in port status
change handling for RESUME link state. usb_hcd_end_port_resume() call is
needed to keep runtime PM balance.

Fixes: a231ec41e6f6 ("xhci: refactor U0 link state handling in get_port_sta=
tus")
Signed-off-by: Henry Lin <henryl@nvidia.com>
---
V1 -> V2: Added Fixes tag in changelog

 drivers/usb/host/xhci-hub.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index df3522dab31b..4a8b07b8ee01 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -1090,6 +1090,8 @@ static void xhci_get_usb2_port_status(struct xhci_por=
t *port, u32 *status,
                 if (link_state =3D=3D XDEV_U0) {
                         bus_state->resume_done[portnum] =3D 0;
                         clear_bit(portnum, &bus_state->resuming_ports);
+                       usb_hcd_end_port_resume(&port->rhub->hcd->self,
+                                               portnum);
                         if (bus_state->suspended_ports & (1 << portnum)) {
                                 bus_state->suspended_ports &=3D ~(1 << por=
tnum);
                                 bus_state->port_c_suspend |=3D 1 << portnu=
m;
--
2.17.1