Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 26 Feb 2022 18:44:48 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     lars@metafoo.de, tangbin@cmss.chinamobile.com,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: Add check for devm_request_threaded_irq
Message-ID: <20220226184448.0a2a49b1@jic23-huawei>
In-Reply-To: <20220224062849.3280966-1-jiasheng@iscas.ac.cn>
References: <20220224062849.3280966-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 24 Feb 2022 14:28:49 +0800
Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote:

> As the potential failure of the devm_request_threaded_irq(),
> it should be better to check the return value and return
> error if fails.
> 
> Fixes: fa659a40b80b ("iio: adc: twl6030-gpadc: Use devm_* API family")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Good find.

That one has been there a long time so I'm not going to rush this in
before the next merge window.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything,

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index afdb59e0b526..d0223e39d59a 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -911,6 +911,8 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, irq, NULL,
>  				twl6030_gpadc_irq_handler,
>  				IRQF_ONESHOT, "twl6030_gpadc", indio_dev);
> +	if (ret)
> +		return ret;
>  
>  	ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK);
>  	if (ret < 0) {