Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
        xkernel.wang@foxmail.com
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Xiaoke Wang <xkernel.wang@foxmail.com>
Subject: Re: [PATCH v2 2/2] staging: wfx: check the return value of devm_kmalloc()
Date:   Fri, 18 Feb 2022 15:12:56 +0100
Message-ID: <2337500.Vxl4yIHFln@pc-42>
Organization: Silicon Labs
In-Reply-To: <tencent_3CB9DC1C721449E14B4AD3FF65201CCC4C08@qq.com>
References: <tencent_24A24A3EFF61206ECCC4B94B1C5C1454E108@qq.com> <tencent_3CB9DC1C721449E14B4AD3FF65201CCC4C08@qq.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?cTXVBZ9Z7leOG59VCnkAP/MkRwABdzu93PA0MuigzyEvRcJZZ/AU89aQv7?=
 =?iso-8859-1?Q?yadt35ZFf793dbN3k6Z64sMSDg8pptWH/EsiVkiqELUPmvbiCbppBW89KV?=
 =?iso-8859-1?Q?GQk8q0hZYEWaMZFwTzdc8IA8ZrZYWSA14UICLo3gRqEtvDUtVnGOuUVdFE?=
 =?iso-8859-1?Q?ogM3Vv50oGu06yj2m7FDoIdjoqCd0/0P229IbqyJU6O0u7mGECSo5CEYbZ?=
 =?iso-8859-1?Q?MsvUdenM+4JOX4lpUc0RjphY29Dhb7iQgy7EgVFjprmKG0DWiqiuhWE1kf?=
 =?iso-8859-1?Q?4hNgl15r1bgVEk44MWEWfqUkatIWq1VoxEDCzeYhJME9BlKLQIiDb/Sh8I?=
 =?iso-8859-1?Q?NTjRdGN6utwBuhd2aV8CQIWbAA69jLwm1/tOEJbp/F+qk4f04V/gsZtHmK?=
 =?iso-8859-1?Q?NdGVWO/tXpi0WVdxs4wRFAxLMn63PrNIkUkf9+x8ss5+cc00ebaE2SZdia?=
 =?iso-8859-1?Q?LWU/t7BvJk0JZAxPmIVEhQyoff17okw3vx3D7CErjGE8Uxfy9BbHuD9hb8?=
 =?iso-8859-1?Q?E1ajOszf/bvyN8a+g19xbNrFDEYHIuc4a/TsrvpjB+JBda2gQlCyL3FPTe?=
 =?iso-8859-1?Q?DXkOe+v7kJvzalQoXhv82dK5pjOLD+V1jJaNbQoikXo6xPa/KIKvJtKk0j?=
 =?iso-8859-1?Q?CEMdVQs5ON50TgBU+/lXz/f0Oj/jmZXyKs7LeeQNJywEBfWfP9G87mM2v/?=
 =?iso-8859-1?Q?4mmtpaLXBrJJPOFPV0Wwq3XzshhtFryjcNS+lDZMRLlZhy4Xko1hF2eEpN?=
 =?iso-8859-1?Q?yiSLjs4ZB90lCI1o+3VTwC9A2OU4vZnrBNZdIfRgW09kuGTKq2E47kTL2K?=
 =?iso-8859-1?Q?39dYa6tnhbcahMbwdkBc8sy6DiaQLwwOncTy2ZiLkZjScSBMmu0OQtPykO?=
 =?iso-8859-1?Q?6H5aj6P0N5NTUrlOud3iasY9vASxCgt/PTMcILUBNc/8AxL6bE+zjYdJLH?=
 =?iso-8859-1?Q?k6e7j4xPYjdGv4B3YfFvRGpPoCaIus7KBGwM4Xp1fv85HTFADptPHYCoMu?=
 =?iso-8859-1?Q?5wNTZJu9d1n8pqJIEtxC8oDyGgcwsKkninl5D/z/keXh7HSUphJcmBLctN?=
 =?iso-8859-1?Q?PuynyRY9zyDSgtSmSTBdZoUU9HFZNyVBzgLN0p1ccJK3PfGXuNb2eVtj+q?=
 =?iso-8859-1?Q?INaL7OksZjKusrVPWsgWp57Bujlr3p/ybPjy2bfC7vQ44+REpqBf2XBM1H?=
 =?iso-8859-1?Q?ugYXtI+1sajX3hTisJK9XK0SIa73zzPAYcLAtO/DBwKAXarBMxYCZd+aYH?=
 =?iso-8859-1?Q?AW+pVWuJTpQS/PKhATg58+p3K7bKLjivcBPsjJd8ltvkvkl11wdXeGNEDz?=
 =?iso-8859-1?Q?nsOL8O4i8dzEs0fDyLEalsd+hj77bp+IqcOghEU5kCd1QoGXtB350trnjp?=
 =?iso-8859-1?Q?4kSc4/cRfdjfRjLn6O2MPxcrvfilT1VxSl8xuZExYfq9GnkLrJaEGRw//B?=
 =?iso-8859-1?Q?pT9NLrw6BIiVPanBZIu+kp929hp1qEdkw3CLoPcLxUk6yVOA8cztYGbjke?=
 =?iso-8859-1?Q?BTmAduBv/4kvPNTaOea++4jW9ETL8Y4Hqs74QVeykbgvNcA+FnxAxPWsII?=
 =?iso-8859-1?Q?uZLMqhXDqKoNaIVIOmKy13A9WhVDtgX/eSB7xL13+Mi7MFM0p5f4RSqvDA?=
 =?iso-8859-1?Q?SlzqhcaqmjyMjzuMYUPss5LsL4lCBCjv9mKlZQWUTq0jIo6C0iUFUV0e/G?=
 =?iso-8859-1?Q?PwLALA7wtFCC6xgAmh9ye0oAfhSNi2w1LwME23AV9QWdEk3NJekkiCkXU5?=
 =?iso-8859-1?Q?zllk1sCTvDqcUP2RUlsGRwD94=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 186bbfe7-4101-411a-32b5-08d9f950e72d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2022 17:53:32.3348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jwx78NVgvBCTQAjab+O/R1+8v7jXW4YaQZLiVdOueixqrNJBsC819u5e/TsKEQ66L6GjIExPdgG6I8XsiPhUvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1869
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00,DATE_IN_PAST_96_XX,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 18 February 2022 15:04:02 CET xkernel.wang@foxmail.com wrote:
>=20
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>=20
> devm_kmalloc() returns a pointer to allocated memory on success, NULL
> on failure. While there is a memory allocation of devm_kmalloc()
> without proper check. It is better to check the return value of it to
> prevent wrong memory access.
> And I use the err label which is introduced by the previous patch to
> handle the error.
This last sentence is not very useful, but it is not a big deal.

Reviewed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>


>=20
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> Changelog
> v1->v2 update the description.
>  drivers/staging/wfx/main.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index 9ff69c5..85fcdc3 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -294,6 +294,9 @@ struct wfx_dev *wfx_init_common(struct device *dev,
>         hw->wiphy->n_iface_combinations =3D ARRAY_SIZE(wfx_iface_combinat=
ions);
>         hw->wiphy->iface_combinations =3D wfx_iface_combinations;
>         hw->wiphy->bands[NL80211_BAND_2GHZ] =3D devm_kmalloc(dev, sizeof(=
wfx_band_2ghz), GFP_KERNEL);
> +       if (!hw->wiphy->bands[NL80211_BAND_2GHZ])
> +               goto err;
> +
>         // FIXME: also copy wfx_rates and wfx_2ghz_chantable
>         memcpy(hw->wiphy->bands[NL80211_BAND_2GHZ], &wfx_band_2ghz,
>                sizeof(wfx_band_2ghz));
> --
>=20

--=20
J=E9r=F4me Pouiller