Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1340610pxm; Sat, 26 Feb 2022 12:18:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmSW6MEcHVK+XHDmKGehTmjuEOrTyumMg5VNIzDYT7oUezpjU+K3zJtlAZwMfgQPxX6ec4 X-Received: by 2002:a05:6a00:22d3:b0:4f3:d439:7189 with SMTP id f19-20020a056a0022d300b004f3d4397189mr8520568pfj.79.1645906684090; Sat, 26 Feb 2022 12:18:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645906684; cv=none; d=google.com; s=arc-20160816; b=O7lxEJQq1uYlMsyzYdEY9+XEd89J5VS2MCZrhPPprnYDWjhUIdOvgt/MOfH/PEo93I 61VWymvs8v8/U9xV3jJ+L3+ac4sb5OO4ohZiwnvD19qTYU53rGUbC9FERoqsWbhU6FJn L0GCW2fArVbAhx2Km0hnpP6zvL7dTC/x56C9PGUhjEARVSPGp2wDLNjB2fkHWRtSmL2I bMGucMfE8khFe3sTB62NjTScBP4Ur3VOMrddUEWyEKGcQNolCGk0yXMEATq/50Cfpr2/ 6qtC9i60Kt5Dkkb31IsXYA3Gjhnid0w/mRNfI7dB8sWhkrcBR3b2S5sbHMrqQGdC83An xm0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3jtsbTUt6V38pFt8n1sHbB9pg1mHTnabw6ltzIZs8Sg=; b=YKiOYTC7NQR+FiEtQ8TOoCJIZOk5+zkvyseztPaQh2a/zqXy8VpYX4pTcWqmu2bOtr p2rwXPEorBOHWLg2WwjbpRa2cVfXy6Lq8Tbv/0LH6bL4rQXjDJkTPmSY2OOxoSBaRT4q CJr6FEMyOCyGSnC8fUqXPsrdH855/9Rd+WNMp24OwGX19REMAGhAd2RhBPD6f+ViOtqm FiOhxTDFlrAuSlnxvfGNnKOLh99MeYHEztKNSu4fqDa7lITOReWIZNUOfmj8UERrtz/f MU4V6kAzR/l/VudCjLX2xxh7w5hVEwv44aUJpsZr5sgkBGtYHXR4ncGnX6V9yAysNptD a90w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PJdvdyGD; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l4-20020a170903120400b001514606ffddsi3196175plh.491.2022.02.26.12.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 12:18:04 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PJdvdyGD; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EA83F2A5765; Sat, 26 Feb 2022 12:11:40 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232002AbiBZS1s (ORCPT + 99 others); Sat, 26 Feb 2022 13:27:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbiBZS1q (ORCPT ); Sat, 26 Feb 2022 13:27:46 -0500 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2DE01C1EEA for ; Sat, 26 Feb 2022 10:27:10 -0800 (PST) Received: by mail-ot1-x32b.google.com with SMTP id l21-20020a056830239500b005afd2a7eaa2so3342906ots.9 for ; Sat, 26 Feb 2022 10:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3jtsbTUt6V38pFt8n1sHbB9pg1mHTnabw6ltzIZs8Sg=; b=PJdvdyGDQwqh2VpXzxHWkm0p3uewn0h/C1v1R8Fge+1c3Ew4RyGG4ql1sICwSa4f1W e1ZKpOkJHZwE9JOSl7QzOJ4rbhpI30ZAonB3Ja83VEewI2lpiSGbdyhXEpzkEWgaK/Nj AmtbtOe5eo7nK088NeIGqx6bVIjTrGkLFDH9Wm6BRw9cb5rS8IM6Fxn4IGvsHe4r8XrR 8ePrsxVJBtP3GECuuMgoGuofe9bZB9e3+J1Acn56EkneXb2wjDaCjLn/hAFYxH/NNvDk XtTjOVIa4HumJA2IKKcgEmOxSNv0ES+cOl21/Cb4zH/+44A+d5lFoH+A9OqVS6P/DScd jDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3jtsbTUt6V38pFt8n1sHbB9pg1mHTnabw6ltzIZs8Sg=; b=dZ68ZUM/7Zus+R4/E3cPOSr/F5FcXYPyEnPsGU4WlrL3NBU5U6AWPPvGdUr6THsMC0 L/zgGsTob+VQs62tZ0LyP9clUcNufNIrOmFrBTzgTCO2X7RlJJ0TDVPAyFM2qz1GQJBt xRqYxE3C9AMGcXD5MgExVelb+sRwJhkN1fBvlv3ChPUT4c7gh32HDlPn+4OSmRIcqDiR 3yCAgXsrMSBP/RO9YAAbEavaiazE5zTwoYYiiYWhZPLC/nlGWzV9hxkqjiD98+H5iLyJ Q0l8N9xrkDpd0XkQ16KUQsCELFzkcm7twLI8hEJiR00fLC8FUpgWt8awa4qiH5tlo0FZ BViA== X-Gm-Message-State: AOAM531IgMLPnQZrx6mtxdcL8UAKnGNi7Xy7+9EMRwYUuufiJeatmOpI TE1dELnOfn0xLuEdw6/114k+zhL6kx839aAUw46T7g== X-Received: by 2002:a05:6830:55d:b0:5ac:ebf8:6d95 with SMTP id l29-20020a056830055d00b005acebf86d95mr5503416otb.162.1645900029933; Sat, 26 Feb 2022 10:27:09 -0800 (PST) MIME-Version: 1.0 References: <20220119203133.467264-1-bhupesh.sharma@linaro.org> <20220119203133.467264-3-bhupesh.sharma@linaro.org> <2f208798-2ec5-4c29-1362-0de102f29718@quicinc.com> In-Reply-To: <2f208798-2ec5-4c29-1362-0de102f29718@quicinc.com> From: Bhupesh Sharma Date: Sat, 26 Feb 2022 23:56:59 +0530 Message-ID: Subject: Re: [PATCH 2/4] pinctrl: qcom: sm8150: Specify PDC map To: Maulik Shah Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, bjorn.andersson@linaro.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Thanks for the review and sorry for the late reply. On Thu, 20 Jan 2022 at 16:24, Maulik Shah wrote: > > Hi, > > On 1/20/2022 2:01 AM, Bhupesh Sharma wrote: > > Specify the PDC mapping for SM8150, so that gpio interrupts are > > propertly mapped to the wakeup IRQs of the PDC. > > s/propertly/properly Ok. > > Cc: Bjorn Andersson > > Cc: Linus Walleij > > Signed-off-by: Bhupesh Sharma > > --- > > drivers/pinctrl/qcom/pinctrl-sm8150.c | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c > > index 7359bae68c69..499dd05c3e3d 100644 > > --- a/drivers/pinctrl/qcom/pinctrl-sm8150.c > > +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c > > @@ -1500,6 +1500,25 @@ static const struct msm_pingroup sm8150_groups[] = { > > [178] = SDC_QDSD_PINGROUP(sdc2_data, 0xB2000, 9, 0), > > }; > > > > +static const struct msm_gpio_wakeirq_map sm8150_pdc_map[] = { > > + { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, > > + { 12, 104 }, { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, > > + { 30, 39 }, { 36, 43 }, { 37, 44 }, { 38, 30 }, { 39, 118 }, > > + { 39, 125 }, > GPIO 39 is duplicated. 39 is used with 118 PDC interrupt in downstream. > so { 39, 125 } can be removed. > > { 41, 47 }, { 42, 48 }, { 46, 50 }, { 47, 49 }, > > + { 48, 51 }, { 49, 53 }, { 50, 52 }, { 51, 116 }, { 51, 123 }, > GPIO 51 is duplicated. 51 is used with 116 PDC interrupt in downstream > so { 51, 123 } can be removed > > + { 53, 54 }, { 54, 55 }, { 55, 56 }, { 56, 57 }, { 58, 58 }, > > + { 60, 60 }, { 61, 61 }, { 68, 62 }, { 70, 63 }, { 76, 71 }, > > + { 77, 66 }, { 81, 64 }, { 83, 65 }, { 86, 67 }, { 87, 84 }, > > + { 88, 117 }, { 88, 124 }, { 90, 69 }, { 91, 70 }, { 93, 75 }, > > + { 95, 72 }, { 96, 73 }, { 97, 74 }, { 101, 40 }, { 103, 77 }, > > + { 104, 78 }, { 108, 79 }, { 112, 80 }, { 113, 81 }, { 114, 82 }, > > + { 117, 85 }, { 118, 101 }, { 119, 87 }, { 120, 88 }, { 121, 89 }, > > + { 122, 90 }, { 123, 91 }, { 124, 92 }, { 125, 93 }, { 129, 94 }, > > + { 132, 105 }, { 133, 83 }, { 134, 36 }, { 136, 97 }, { 142, 103 }, > > + { 144, 115 }, { 144, 122 }, { 147, 102 }, { 150, 107 }, > > + { 152, 108 }, { 153, 109 } > > +}; > > + > > static const struct msm_pinctrl_soc_data sm8150_pinctrl = { > > .pins = sm8150_pins, > > .npins = ARRAY_SIZE(sm8150_pins), > > @@ -1510,6 +1529,8 @@ static const struct msm_pinctrl_soc_data sm8150_pinctrl = { > > .ngpios = 176, > > .tiles = sm8150_tiles, > > .ntiles = ARRAY_SIZE(sm8150_tiles), > > + .wakeirq_map = sm8150_pdc_map, > > + .nwakeirq_map = ARRAY_SIZE(sm8150_pdc_map), > > On SM8150 need to set .wakeirq_dual_edge_errata = true, similar to sc7180. Sure, I will fix this in v2. Regards, Bhupesh