Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1362440pxm; Sat, 26 Feb 2022 13:01:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGRxBT16QHkuvFzWdJq1CY9a16O5hlqSPh0WBfpSWsqCzyEjfM3psq3NWIlQPDPP7gUVNb X-Received: by 2002:a17:903:40c2:b0:14f:ffd2:71d0 with SMTP id t2-20020a17090340c200b0014fffd271d0mr13728507pld.20.1645909291911; Sat, 26 Feb 2022 13:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645909291; cv=none; d=google.com; s=arc-20160816; b=j8Wwr2chH49w+mumrsxRcI8GVuvNpjFq1cbIjKp/6NJK2f4Pze3fKP/OZDmnF6aU1Y hlC+g4u6J5rtNL9WXzZSgtAAPg/C+c2PIMhlZBXlBKD9t8EkzKhBe9cm8ZAFbFPY4sh2 L9C81JrzVM3KBF4BiSCMrzTWWMH3ci0gMoa5FX1Ax+Wq6JrHfsTqM8lyuh9ClJ3Rmk3P jSj/V9BzOveqhrXOdZkSY+tRR40FnXR9G4hu2NfuwOdsC4ACN1RYfUdIFRAEYFYlrYzE EnOd9ycEkmMYiCHD3/PntJDHRoKJgV3YVmIS8ecE7ZAPpjxZmWQt9TlllxiuHiXau6tQ RqyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=msxU2UfcVFrwCj3eU5XFZoVOe7HH+NdjfV+cwoL/Fik=; b=jN6fKHu5d9YncKeJpirXlmCSKpot+IAQ9cbT1OvxcDiduWnHOAyIEIR3TEPKCVw2PB eRHNbTLVicWOqqjNAFe4QzOnZDLxAlt9zPhxJqXIt83SPIJYNr3ToYM4CBg0QyocGJcT 0fYzAohi2gAf/H3uVigfQDtJx4dJtkWfPZ7UrD9+AlMR80/wQ2Ma+u4gq6Kr8ihWDoJR Bq8+f7hXVYyeIGgWStyFhvKyEs7jfUXziBKSFGk9BFnJT/zKFngPV9sw7FuEMCkHFODs HRkLrP6RPX1mkkO+RRqsGj84jvGZQJOtcIUQGtKIT/V3x/oXmjEw/Pgf6P3Sz5ZBI0UQ cmUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yfQKckeH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id n7-20020a1709026a8700b0014f85c15c61si5178198plk.479.2022.02.26.13.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 13:01:31 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yfQKckeH; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D25EE23D1B2; Sat, 26 Feb 2022 13:01:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbiBZVBm (ORCPT + 99 others); Sat, 26 Feb 2022 16:01:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbiBZVBk (ORCPT ); Sat, 26 Feb 2022 16:01:40 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FBB61DED4B; Sat, 26 Feb 2022 13:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=msxU2UfcVFrwCj3eU5XFZoVOe7HH+NdjfV+cwoL/Fik=; b=yfQKckeHAJUkzcec9GpbN5u7v5 tt7t+WkvONdXeNDMT9gecLftrxF7SgByNdnwaiPKnHsbsvgxjdYak+WeNFloAOLrGcpUe8nuaz/Ur eo3Kc2A3i15qlSLEByZ6uW5+OWy0H2QqMgWJNLJ6D5glFLloHSGkYDrW2aVBDXKZC9CSYpNmqIyjB JrKzp6SQtMgaDnGLjrD6AMIRjbWqxTpOIyNeMsvLMviz+OI9FF7FgfO/PWimm1Ezng3aWoUBxsmtG rRABOwL3FQU/4IS8uQ24Lbj8rpoL6y4m9BrG9jwGRmqgs5JdBRQSDAa6IjGfGKR4K3tZL4vNov1Sx XQPBj4gw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO4BR-008Xjj-IV; Sat, 26 Feb 2022 21:00:53 +0000 Date: Sat, 26 Feb 2022 13:00:53 -0800 From: Luis Chamberlain To: tangmeng Cc: Matthew Wilcox , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com, sujiaxun@uniontech.com Subject: Re: [PATCH 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220220060626.15885-1-tangmeng@uniontech.com> <8940d534-d6e5-0642-f145-67a323eb8092@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8940d534-d6e5-0642-f145-67a323eb8092@uniontech.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 23, 2022 at 05:51:33PM +0800, tangmeng wrote: > On 2022/2/23 08:39, Luis Chamberlain wrote: > > > > Since you are following up on more changes, can you work on this? > > Brownie points if you show size results to refelct no size difference > > based on a new build with an example new user. > > > > I'm going work on this, but I think it may take some times to get it done. Thanks and good stuff! Can you please then make that the focus of your first set of patches, and then respin this series by collecting all ACKs, Reviwed-bys? Yes please send a new v3 series for it. While at it please Cc the other folks doing sysctls changes so they are aware of this. Thanks! Luis