Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Sat, 26 Feb 2022 13:02:19 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     tangmeng <tangmeng@uniontech.com>
Cc:     viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
        keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        nizhen@uniontech.com, zhanglianjie@uniontech.com,
        nixiaoming@huawei.com
Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its
 own file
Message-ID: <YhqVW972rnF5L22U@bombadil.infradead.org>
References: <20220221061018.10472-1-tangmeng@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220221061018.10472-1-tangmeng@uniontech.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote:
> kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
> dishes, this makes it very difficult to maintain.
> 
> To help with this maintenance let's start by moving sysctls to places
> where they actually belong.  The proc sysctl maintainers do not want to
> know what sysctl knobs you wish to add for your own piece of code, we
> just care about the core logic.
> 
> All filesystem syctls now get reviewed by fs folks. This commit
> follows the commit of fs, move the drop_caches sysctls to its own file,
> fs/drop_caches.c.
> 
> Signed-off-by: tangmeng <tangmeng@uniontech.com>

Thanks but please send a v3 including all the other patches as well
and collecting the Reviewed/Acked-bys, etc. This can be sent *after*
your v3 of the optimization work.

  Luis