Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp1366154pxm; Sat, 26 Feb 2022 13:07:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxsX1vzEKrCEu1nrd7/Gkfg8Zg+fsWbQlEhx1+JhECysULPfnQ95WHe/eDxKOV6UzTCAkXC X-Received: by 2002:a17:902:6bc1:b0:14a:c390:a44b with SMTP id m1-20020a1709026bc100b0014ac390a44bmr14093665plt.11.1645909637224; Sat, 26 Feb 2022 13:07:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645909637; cv=none; d=google.com; s=arc-20160816; b=uLIwRi0DjpD5h7Z/FcF5wFcuuHTOSfVYnzmBbqP9snNpFx/ybXwMAEpAeRhf7dpwvT yWGoY1+Q6lB8+jQg8km4JX8MokklJLcJzYnLaqAdUJRjvdy676Z3CYw48958waT5jx9r rktrokQlVyDRhDoX2mNHV2Ba+MSDk7W9vbg2myC62fM35GQEampK0Qxup5v6wiOB/p4/ rRYDTik1j9ciLdXYXzXbGvHrPvmL+8eNGhFW8n3QRIzSNBUKStNR+p4MPOwjq4pbr6sC Wl9YmeDKIuKAiIRBrRoqFjVDTUyLeqor8gE10ruQfJVkCKGQOBw4gqnixpJzuPxv+Shg pm3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=t5PvKUiCfOMquPumfQ4cEUgcoR3Wsv7oMQVd0HhO0Zo=; b=Rkx4z1dXRINedHSLHHKTR1wmFZymuUYbfSjpolOpV8+Gnr7nwyThUz0BxF/lwC3dPA MLd+vz9DhBMpI2hWkRF6eFrMrRgJnlsIgsQ6Y7Bhx1hCq1v3zY3cWQaT37pGfNEzk09n zO+s1Ru6qg+Zlleh/cjyEpY/SDkXY368EL2dGGErkErVhajaH0frOQH2Jo+2pXFk04GU yGcPzu2qyq/KFwGk1o47X7gB9YzecERGHjKIH6M61b75OXHhLbZgUBMetLwAmlyUA+jq SiztPrcR+0PPWKj+izdM4fS1UYi5zzjm829FAcfW9GbX1D9omNkSF6wNBNA+OpWd36Yu 5vgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=gtNP4G6f; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id r2-20020a17090b050200b001bc62e27ccfsi10754765pjz.99.2022.02.26.13.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 13:07:17 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=gtNP4G6f; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 54860DED5; Sat, 26 Feb 2022 13:02:40 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbiBZVDE (ORCPT + 99 others); Sat, 26 Feb 2022 16:03:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbiBZVDD (ORCPT ); Sat, 26 Feb 2022 16:03:03 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C813DFC7; Sat, 26 Feb 2022 13:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t5PvKUiCfOMquPumfQ4cEUgcoR3Wsv7oMQVd0HhO0Zo=; b=gtNP4G6fJqE4QOtsMvUMIVFpQ4 usPnT7I8lr5qMEgoySSAWt79IYauedv87xchUhNtpl7pnUuuRmvckbPV6Jrh5QQRePDS6sPnrEQDd mLQ0Ey83QSIJDK7LZAYz8RaD9Ty3Uk4YPD8g08lRJITopv9NFbKS0T6ivFF2JXpzjxWqLKHWfLMs7 /1pUHclLHba1zIqBZlA3gQ5Fdj504mt++KNl0uh9fqrQ9NvJbk0RXdsU+cxFtTCjnPBSHCngUnrxJ dos+hBJALOqBjdOz1d/nnI/Uul/HHo8YsphtGDRkybBB1eyTqR3HR5r/4/hbB0g5TVXmt2v3P+8gM 8tVWXt+A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO4Cp-008XqG-Id; Sat, 26 Feb 2022 21:02:19 +0000 Date: Sat, 26 Feb 2022 13:02:19 -0800 From: Luis Chamberlain To: tangmeng Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nizhen@uniontech.com, zhanglianjie@uniontech.com, nixiaoming@huawei.com Subject: Re: [PATCH v2 10/11] fs/drop_caches: move drop_caches sysctls to its own file Message-ID: References: <20220221061018.10472-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221061018.10472-1-tangmeng@uniontech.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022 at 02:10:18PM +0800, tangmeng wrote: > kernel/sysctl.c is a kitchen sink where everyone leaves their dirty > dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to places > where they actually belong. The proc sysctl maintainers do not want to > know what sysctl knobs you wish to add for your own piece of code, we > just care about the core logic. > > All filesystem syctls now get reviewed by fs folks. This commit > follows the commit of fs, move the drop_caches sysctls to its own file, > fs/drop_caches.c. > > Signed-off-by: tangmeng Thanks but please send a v3 including all the other patches as well and collecting the Reviewed/Acked-bys, etc. This can be sent *after* your v3 of the optimization work. Luis