Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zev Weiss <zweiss@equinix.com>
To:     Marcello Sylvester Bauer <sylv@sylv.io>
CC:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: [PATCH v1 1/1] drivers/hwmon/pmbus: Add mutex to regulator ops
Thread-Topic: [PATCH v1 1/1] drivers/hwmon/pmbus: Add mutex to regulator ops
Thread-Index: AQHYK2po2MlpoGQR/EqdsknvVjVpMqymfigA
Date:   Sat, 26 Feb 2022 23:42:21 +0000
Message-ID: <20220226234220.GV5754@packtop>
References: <b991506bcbf665f7af185945f70bf9d5cf04637c.1645804976.git.sylv@sylv.io>
In-Reply-To: <b991506bcbf665f7af185945f70bf9d5cf04637c.1645804976.git.sylv@sylv.io>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N0IMUlmVkRhMxf7RMO4QptSginYI1NyELg5FKLmHN0xYk3Dd6AoYYxGwrOdB?=
 =?us-ascii?Q?KYWrgPHl5D52TUrxdT32ncuuuDsHo1Fz5vnYUltMMJ3Za/fCYhyJJ0yYsaZe?=
 =?us-ascii?Q?ksjhgmRTEEhhP/DC1cAplM3KVTIWM19p+WQGzoaT71jHs9rB/Jk0tMpl3m3p?=
 =?us-ascii?Q?DwhRHL/F9frxX/VUDGAugURnGLc0KY/t3q1G/fmo2LNOHJn8X+Ld1qcJxJo2?=
 =?us-ascii?Q?DGZ+FNgUVjZB1k497IAB5CfzJTpHr9RURx+3coXNNe+nKgzqTyZrDLIIv65G?=
 =?us-ascii?Q?DLgj9t8mVkheOQpRMAARrWLVjhCH+hzb+eByWwGi9uCs4eBr+ZoBnXIcyCtC?=
 =?us-ascii?Q?SFe9IFl65aUZRbQvKuCjlND1OnumdBZT3ppyth6HLRcvuQzY2idegmvmTl5S?=
 =?us-ascii?Q?WP0AOnfBY3mBzGW/Vib9MaWIMC6gcYRpvcYS6NWEzffgF5mv+dBSiaUaGZfC?=
 =?us-ascii?Q?2YsHIiYOuVvYN4yB+lbulgVw5N+C+AtFEjtFntiGHHqctna5e4ghC8HCi5aZ?=
 =?us-ascii?Q?NBEj2qR7+gOGQVRSQ5IT0kOO108csAM3YmQ+yJdw9EeSnuptbmPliS7O8sBY?=
 =?us-ascii?Q?xa8E9oh3IH+Rtg86aHsUQdkLvnTt5H2Y/KNfHqhNUITm5BAhnTYDjwNpqvoo?=
 =?us-ascii?Q?uKyQaOQC8bKLlEz6M4orCbllydi56jTxG0MTtahtRM6FapRXEWVuAesdmW/n?=
 =?us-ascii?Q?aEw1tFlajqAw7yRT/vBwAdaLu2erp31+uviknHcWR/oiqDVEoxZpJyxHfuZT?=
 =?us-ascii?Q?YJfd1uRsOMv1RvAFlfxAxgzreUCTiZgb/4EP6/y09wd0NUdF7+lVNHh8RhKJ?=
 =?us-ascii?Q?kyDxQ7s77eJWMOR9F09cuPXB6gOoE0GE49jy9Dw+igIOFiWIb2iTKGVQFIZC?=
 =?us-ascii?Q?ujlzlA+nk+hM87WGGqoerXsnAjc6Uy2B+BDO20TdWBKsUnoOBc490WEnBw/6?=
 =?us-ascii?Q?jrO95O4QDTso0sKv+PnFX4wUAoBOcXPQOMp+OvfEDQkJuKYxXhZbcN1p5zLR?=
 =?us-ascii?Q?Zv8cFcfwfvZYjjKHBRWSqFlQcu5TDDqB9500mp0HmwOARZOJt0eNNEuNY41X?=
 =?us-ascii?Q?NApLcz1Sj3Fl+pTNeBo8bAaZtJWhXJ/wu5k5VdfZG+1J+k1jABM1RYhz9U90?=
 =?us-ascii?Q?+oDSwtsrtzNu/lmyKZqOYVow2ELSKEPo5EDdOjSxzMy6pFdV3nKsU75C4gLx?=
 =?us-ascii?Q?BQ/gSoY5W1jKCm2ZgtHpOoRJx0mt+ceMOsy0/jrnUKrq6+Ly3jj6EufXTUhr?=
 =?us-ascii?Q?7btgz7AbDNuk3lqpdfoeSUv8oj9+ffGxgnOEpTOFj21L41Sl25Iy/XdHQzQd?=
 =?us-ascii?Q?G5IW+xF6KaRcZ0fgkI03wOYEWwuM/6ElN6jO18Na9qVlfRfRMcQpPi7FRCAO?=
 =?us-ascii?Q?ntYqaAcQ4tyggogj2lNEZowk2P81JbxIHiuBUBAv0EyPJSdas6up8zvI/GQh?=
 =?us-ascii?Q?/vuh8zOJEeXRezPG7/5uerNEztag1tKaz+t2rBP2bl25wiEB3OatW8RHyeVQ?=
 =?us-ascii?Q?YDPtAxD/le6yUJh9RhxzUjyoAQjnN1XWqyuymdA8mlTQHrBXzm0RgfOc2pAs?=
 =?us-ascii?Q?5SDgoalfAxwNJf3BBP4bf2cxUOy24jZH8U0Q8u0ZFopLs+MH0nTRM5XTmhXN?=
 =?us-ascii?Q?6Dm4C/YdV/Le1KkahVUYzlM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <73E3868561C98B439A6A5C826AEC7EDA@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: equinix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8007.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a747326-05b1-4df2-612c-08d9f981a1ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2022 23:42:21.0834
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72adb271-2fc7-4afe-a5ee-9de6a59f6bfb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IEcCjda71kN3dF5yvl35/dYc8bDgjdCaVHDFqJXt5Z4l12m+8q4gJsb01ONDb4/0+pU+ZZLotCUr5UGlum3CMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8125
X-Proofpoint-GUID: SbVzkCh3vM-l7E3VmgD3qRBYYgRpwVIk
X-Proofpoint-ORIG-GUID: SbVzkCh3vM-l7E3VmgD3qRBYYgRpwVIk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-02-26_12,2022-02-26_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0
 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 mlxlogscore=733
 priorityscore=1501 clxscore=1011 adultscore=0 impostorscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202260169
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_FMBLA_NEWDOM,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 25, 2022 at 08:06:09AM PST, Marcello Sylvester Bauer wrote:
>From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
>On PMBUS devices with multiple pages, the regulator ops need to be
>protected with the update mutex. This prevents accidentally changing
>the page in a separate thread while operating on the PMBUS_OPERATION
>register.
>
>Tested on Infineon xdpe11280 while a separate thread polls for sensor
>data.
>
>Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
>Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
>---
> drivers/hwmon/pmbus/pmbus_core.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_=
core.c
>index 776ee2237be2..f79930162256 100644
>--- a/drivers/hwmon/pmbus/pmbus_core.c
>+++ b/drivers/hwmon/pmbus/pmbus_core.c
>@@ -2386,10 +2386,14 @@ static int pmbus_regulator_is_enabled(struct regul=
ator_dev *rdev)
> {
> 	struct device *dev =3D rdev_get_dev(rdev);
> 	struct i2c_client *client =3D to_i2c_client(dev->parent);
>+	struct pmbus_data *data =3D i2c_get_clientdata(client);
> 	u8 page =3D rdev_get_id(rdev);
> 	int ret;
>
>+	mutex_lock(&data->update_lock);
> 	ret =3D pmbus_read_byte_data(client, page, PMBUS_OPERATION);
>+	mutex_unlock(&data->update_lock);
>+
> 	if (ret < 0)
> 		return ret;
>
>@@ -2400,11 +2404,17 @@ static int _pmbus_regulator_on_off(struct regulato=
r_dev *rdev, bool enable)
> {
> 	struct device *dev =3D rdev_get_dev(rdev);
> 	struct i2c_client *client =3D to_i2c_client(dev->parent);
>+	struct pmbus_data *data =3D i2c_get_clientdata(client);
> 	u8 page =3D rdev_get_id(rdev);
>+	int ret;
>
>-	return pmbus_update_byte_data(client, page, PMBUS_OPERATION,
>-				      PB_OPERATION_CONTROL_ON,
>-				      enable ? PB_OPERATION_CONTROL_ON : 0);
>+	mutex_lock(&data->update_lock);
>+	ret =3D pmbus_update_byte_data(client, page, PMBUS_OPERATION,
>+				     PB_OPERATION_CONTROL_ON,
>+				     enable ? PB_OPERATION_CONTROL_ON : 0);
>+	mutex_unlock(&data->update_lock);
>+
>+	return ret;
> }
>
> static int pmbus_regulator_enable(struct regulator_dev *rdev)
>--=20
>2.35.1
>
>

Looks like this doesn't cover pmbus_regulator_get_error_flags(), which
was added recently -- perhaps rebase onto hwmon-next?


Zev