Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-005e10e1-b6fd-4573-956d-3f474c3c9ae2-1645949622469@3c-app-gmx-bs39>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Peter Geis <pgwipeout@gmail.com>
Cc:     =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Frank Wunderlich <linux@fw-web.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        devicetree <devicetree@vger.kernel.org>,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Aw: Re: [PATCH v1] arm64: dts: rockchip: Add sata2 node to rk356x
Content-Type: text/plain; charset=UTF-8
Date:   Sun, 27 Feb 2022 09:13:42 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <CAMdYzYro7r2nELu2O4TuxxtZLxNSv1e3iU5yBzjd7AQgHP+FPw@mail.gmail.com>
References: <20220226135724.61516-1-linux@fw-web.de>
 <2815432.3mA4caTK8C@diego>
 <CAMdYzYro7r2nELu2O4TuxxtZLxNSv1e3iU5yBzjd7AQgHP+FPw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Samstag, 26=2E Februar 2022 um 19:15 Uhr
> Von: "Peter Geis" <pgwipeout@gmail=2Ecom>
> On Sat, Feb 26, 2022 at 1:08 PM Heiko St=C3=BCbner <heiko@sntech=2Ede> w=
rote:
> >
> > Hi Frank,
> >
> > Am Samstag, 26=2E Februar 2022, 14:57:24 CET schrieb Frank Wunderlich:
> > > From: Frank Wunderlich <frank-w@public-files=2Ede>
> > >
> > > RK356x supports up to 3 sata controllers which were compatible with =
the
> > > existing snps,dwc-ahci binding=2E
> > >
> > > My board has only sata2 connected to combphy2 so only add this one=
=2E
> >
> > how far does the added node diverge from the vendor kernel?
> >
> > If it's pretty much similar between both, we can assume the other node=
s
> > should work pretty well as well and therefore should all of them at on=
ce
> > and hope for the best?
>=20
> There's essentially zero divergence (minus the change due to combophy
> changing), and likely won't be until the ahci-platform=2Etxt is
> converted to yaml=2E
>=20
> I have tested both SATA1 and SATA2 successfully on the rk3566=2E
> I don't have any rk3568 boards that are operational yet to test SATA0=2E

Like Peter says, the sata-node(s) is basicly same as downstream, only comb=
phy-label has changed=2E
Sata1 from Peters tree [1] seems to have only this change=2E
I'll send an followup containing all 3, but had only tested sata2=2E

already sent a bindings-patch for the ahci-platform=2Etxt [2]

regards Frank

[1] https://gitlab=2Ecom/pgwipeout/linux-next/-/blob/main/arch/arm64/boot/=
dts/rockchip/rk356x=2Edtsi#L238
[2] https://lore=2Ekernel=2Eorg/lkml/20220226204404=2E109867-1-linux@fw-we=
b=2Ede/T/