Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Feb 2022 12:21:45 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Cristian Pop <cristian.pop@analog.com>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        robh+dt@kernel.org
Subject: Re: [PATCH v7 1/2] dt-bindings: iio: frequency: Add ADMV4420 doc
Message-ID: <20220227122145.6bc20b68@jic23-huawei>
In-Reply-To: <b591b26e-1a80-e17d-4525-989b357e97b1@canonical.com>
References: <20220223130808.13352-1-cristian.pop@analog.com>
        <b591b26e-1a80-e17d-4525-989b357e97b1@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 23 Feb 2022 14:26:05 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote:

> On 23/02/2022 14:08, Cristian Pop wrote:
> > Add device tree bindings for the ADMV4420 K band downconverter.
> > 
> > Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> > ---
> > Changes in v7:
> >  - Fix commit message  
> 
> Please include the tags accumulated in previous reviews.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> 
> Best regards,
> Krzysztof

Series applied to the togreg branch of iio.git and pushed out as testing
to let 0-day take a look before I go breaking linux-next (again :)

You get the same general feedback for future series as I just gave Antoniu:

1) Particularly when doing multiple revisions close together, please give
   a longer change log covering at least the last few versions as not
   everyone will have looked at v7 and it saves reviewers time otherwise
   spent checking back through earlier versions.
2) Cover letters are good for multipatch series because they both provide
   somewhere for general discussion that overlaps multiple patches and
   as somewhere for series wide tags to be given and that sometimes
   makes my life easier (complex cases where some tags are for individual
   patches and some are series wide which I have to go in an add by hand
   as no automated tool e.g. b4, could work it out!) 

Sometimes I like to complain about this trivial stuff that makes me
ever so slightly grumpy :)

Jonathan