Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1645558375.git.riteshh@linux.ibm.com> <a62c8d1c0d8a01e2b1e3afc9c2b012c04c54b137.1645558375.git.riteshh@linux.ibm.com>
 <20220223094149.h5lj2dwq3sd5b3tp@quack3.lan>
In-Reply-To: <20220223094149.h5lj2dwq3sd5b3tp@quack3.lan>
From:   harshad shirwadkar <harshadshirwadkar@gmail.com>
Date:   Sun, 27 Feb 2022 10:30:38 -0800
Message-ID: <CAD+ocbyhQ4OWO-s021hod=EQFJF_BKE4u0xyLXDNLzkZ_66Tuw@mail.gmail.com>
Subject: Re: [RFC 4/9] ext4: Do not call FC trace event if FS does not support FC
To:     Jan Kara <jack@suse.cz>
Cc:     Ritesh Harjani <riteshh@linux.ibm.com>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        "Theodore Ts'o" <tytso@mit.edu>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Looks good.

Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

- Harshad

On Wed, 23 Feb 2022 at 01:41, Jan Kara <jack@suse.cz> wrote:
>
> On Wed 23-02-22 02:04:12, Ritesh Harjani wrote:
> > This just puts trace_ext4_fc_commit_start(sb) & ktime_get()
> > for measuring FC commit time, after the check of whether sb
> > supports JOURNAL_FAST_COMMIT or not.
> >
> > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
>                                                                 Honza
>
> > ---
> >  fs/ext4/fast_commit.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> > index bf70879bb4fe..7fb1eceef30c 100644
> > --- a/fs/ext4/fast_commit.c
> > +++ b/fs/ext4/fast_commit.c
> > @@ -1167,13 +1167,13 @@ int ext4_fc_commit(journal_t *journal, tid_t commit_tid)
> >       int status = EXT4_FC_STATUS_OK, fc_bufs_before = 0;
> >       ktime_t start_time, commit_time;
> >
> > +     if (!test_opt2(sb, JOURNAL_FAST_COMMIT))
> > +             return jbd2_complete_transaction(journal, commit_tid);
> > +
> >       trace_ext4_fc_commit_start(sb);
> >
> >       start_time = ktime_get();
> >
> > -     if (!test_opt2(sb, JOURNAL_FAST_COMMIT))
> > -             return jbd2_complete_transaction(journal, commit_tid);
> > -
> >  restart_fc:
> >       ret = jbd2_fc_begin_commit(journal, commit_tid);
> >       if (ret == -EALREADY) {
> > --
> > 2.31.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR