Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2226586pxm; Sun, 27 Feb 2022 15:15:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJx4cM0mgJGP8zgytHKRdy2hN0W/bsDcTJvWxLoY0krgBLu/BYxvFkKdCl5PlOtB6rXmIMUS X-Received: by 2002:a17:90a:ac07:b0:1bc:79df:8486 with SMTP id o7-20020a17090aac0700b001bc79df8486mr13738071pjq.31.1646003756937; Sun, 27 Feb 2022 15:15:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646003756; cv=none; d=google.com; s=arc-20160816; b=W2fUH3uhzVZPx91VAJjLv17pbp1o6SB6cRSBW3MacxchWbP0Wb15s4q2LSXKF1hVYJ MNAng3d4nUalq4ipeFgJM3vM1EiGXLlCrUG0Os5KWkX3dB2qvawuZnaolJ3emS0SWaTa vivp492GJ5ZE4kfdcH6K5TV6oqhJyAbSpIvHobEFNwE1Ah9jdOKvIgwNJ2Ca3he9eFSU uB4wS0kdc7IAXpkMAcFkXpe2dmiXQOdZf8Ao8fBHraDOhENIcidBF18qKD/tuMwMqMR/ jCuJLW3RQIHbPW7MhtHc1C5IZINuHo5YOPB6/ZB1o8X4Y11VBZ6Tx4x3ibrBY7Z+FrGp dNDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=p61rwQ6Hs00Y+G3dvWm3cSahGuQsRZC6GD/tER+ucvg=; b=DkI0sEb/iae7ScCuNMCXlBJkAhNXsR6LsMmwKOmle6n88qWK8zhwZzQlKTWv53FzV8 40IOgF2/Y1Kri9I6NIZMIMJuXbLSbHnmU2UD11rQ9To7a3MFingO+9B7U3VOYwo/1GQl O1hL6qjVxm6f3DnF4Ym6QCEW1Clr1Yb8dfQgoX+Jov2HHhS902cg128FcEBI4z4j0gnP RLner+bRb9iXTKD7yliIb1gxY7JgKh2dlyjdwSl/lAznIy8qgC2Ew7O033Q0Viysulm6 2BJxmBxjCHWFvmEPyrTPw1fe2qlJxxdPd6eSDIuwEyckKaiRJotV+0ruyE9wZjj8paQ9 MukQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k2-20020a637b42000000b00373fe5602fdsi8149834pgn.290.2022.02.27.15.15.40; Sun, 27 Feb 2022 15:15:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230356AbiB0XHl (ORCPT + 99 others); Sun, 27 Feb 2022 18:07:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbiB0XHi (ORCPT ); Sun, 27 Feb 2022 18:07:38 -0500 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B86AB55493; Sun, 27 Feb 2022 15:07:00 -0800 (PST) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 8918892009C; Mon, 28 Feb 2022 00:06:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 7BAA292009B; Sun, 27 Feb 2022 23:06:58 +0000 (GMT) Date: Sun, 27 Feb 2022 23:06:58 +0000 (GMT) From: "Maciej W. Rozycki" To: Greg Kroah-Hartman cc: Jiri Slaby , Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Feb 2022, Maciej W. Rozycki wrote: > On Fri, 25 Feb 2022, Greg Kroah-Hartman wrote: > > > We don't do this for any other driver subsystem, so why is it really > > needed? What is so special about this driver that distros can't > > just enable all of the drivers and all is good? What is keeping those > > drivers fromb eing enabled? > > My justification is we have a supposedly generic PCI 8250 UART driver, > except it explicitly and silently refuses to handle a handful of devices > chosen by their PCI IDs based on that they may have extra features, even > though they are otherwise fully compatible with a generic 8250. Actually as it happens we do have a precedent too, as here's what I have just spotted on my laptop by chance when hibernating: psmouse serio1: synaptics: The touchpad can support a better bus than the too old PS/2 protocol. Make sure MOUSE_PS2_SYNAPTICS_SMBUS and RMI4_SMB are enabled to get a better touchpad experience. (with a distribution kernel, so clearly whoever packaged that has not enabled what might be needed). Someone else wanted to be helpful too as it seems. Maciej