Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Rob Herring <robh@kernel.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: serial: fsl-lpuart: Add imx93 compatible
 string
Thread-Topic: [PATCH] dt-bindings: serial: fsl-lpuart: Add imx93 compatible
 string
Thread-Index: AQHYIkQLsWfV0rmwl0a6my6eQFwuT6ykfZ0AgAO1SJA=
Date:   Mon, 28 Feb 2022 00:44:46 +0000
Message-ID: <DU0PR04MB94172264E2DCE759EE3B9A3688019@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220215081334.788419-1-peng.fan@oss.nxp.com>
 <Yhj9joQkgTswMVcs@robh.at.kernel.org>
In-Reply-To: <Yhj9joQkgTswMVcs@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d3aPgcW5HjyZJuew0uy57GkYObjpd07V7XH547+TqKfA6KHDZvwLm08acVGe?=
 =?us-ascii?Q?+X5n9LXvVE7DmeVfK/oKzbXHry/GLAodvjzvkiJdoNUw8OODJa4svOpnsZTc?=
 =?us-ascii?Q?ClJagB7WnBYy+22n2te8F2kdP5IbUttfVDYkEsVZNs5jW56RLaoQH6KEIvsU?=
 =?us-ascii?Q?w9WzeqlrNazh56DMBiLRCYRV10YyBSEoP/gwOWfwZpMRSg0oZUTXTpR7/3Zb?=
 =?us-ascii?Q?RRbwSyKzKQpSLhnhyoJT6yyAg5GExX7b0DxY8W0Yels+9RBWiRXavQJ4EXzL?=
 =?us-ascii?Q?Etx+XrJZS0v5m2IDf+5MUHMMBO9Diq6amgQHvEiJM9sTyDwOzlue25RoInVp?=
 =?us-ascii?Q?eUppPbLqBerww8KuyhzuRkW0MHDXBZNUf5Ur/jHSNfMVH3ct3JHeIxTCqmiO?=
 =?us-ascii?Q?ryz5OapJAey3ZYbseuXTSu6O7raNjcwAyc7IvNqUcKB/zOA8QxnqIhcwOH7B?=
 =?us-ascii?Q?Tt6aGz36AcToby8YSpmysN+uIiskAHJrnm5HncMV8Eglt31idKzcE46KxVS+?=
 =?us-ascii?Q?noEWAlKsbzdd64AO1Y5bEoIjr2HTLVp16y1/tKjuwWc3Q7VRmBkG3nMKjPN9?=
 =?us-ascii?Q?/acfn01KOjlHn4/R+onSfYUbWCuL+StzC752qXpPABIOv0PL+lX8P49wpJU1?=
 =?us-ascii?Q?CF8/4F5/A9Z6+ppr6SJ3UFAYHMFTwz7Z5Pq2BETxojG6V18YkQdQxSN6V/oF?=
 =?us-ascii?Q?vLnIH98Av/Lz7s6fptHC6h7vk7Ntl3MqJwhLWasvlXINsApWDdLr6liZDTJn?=
 =?us-ascii?Q?CfgG54DipfKKz2QpwOJ9i1v/o06fODki9trOLaYlEjjHbpWKVQfar2J+rnhN?=
 =?us-ascii?Q?WzBHO6qVuJcTY/9hdSvW9OuvNs8gDh0ND2NVsq1S79tOXD3IszlrjN+NZN+u?=
 =?us-ascii?Q?i0Y0Go9SxLiQ5TEpa750ms5azfEtFP6BCdataqun3PwaP9JutsXAyhFtMz67?=
 =?us-ascii?Q?GJzn9b1GDe4ceZJYE8aeA4qzXsn3MC5zgGrUghemCmC8koh6QVcR6lHUaPf/?=
 =?us-ascii?Q?HJsMwA9HW+esSCs3+5RJ4ysMVvtEIdSmKQNHaJA84ERxmqr7NEX5Lth/aAVW?=
 =?us-ascii?Q?KoAkEkN/RyILva+UebGMG9a5aq+91f42GonVsQBw+CYuY7y5g/k6qX8muFBd?=
 =?us-ascii?Q?58S/eFjjR2MCr7K8zUfCbpF8SNff/xgAHz2E2yAihk7M12hhHl+6Yn0NIB7A?=
 =?us-ascii?Q?z9sJOtwBrI7G+9ghcU66s2PXIyQ/l5jiJDcRVMvZXRIeK49PY5p6JQoSWdnA?=
 =?us-ascii?Q?CHumphvLdfO0gR0rdP8q5+m/QMsTOe53fDimUEok4P7e1cQynDuNlpSpcERV?=
 =?us-ascii?Q?A5buimmlKf5RSI1pt+veYAjGI+N9JGIz/lTvtTtGjmLMwbGHXQNOwDK8bsb+?=
 =?us-ascii?Q?Yx6oX15biujp0iADpXgbWPi62nl9fXnajwNtMjTFJdzktjVPN5HBrsx9JrwW?=
 =?us-ascii?Q?eLqfU5x7q2WS8OY4ey4Li2PxgO0UQq2FYYuI0zeYNEexcx1c7zMV7iTRpkZk?=
 =?us-ascii?Q?Sl+toy0Hs3GqvZOaMC/nHxRxjeZWFbcBdYtqeFq7MAE77tdZmIKK3uoRlvPA?=
 =?us-ascii?Q?ol3DBKMksly277FenqBxR6c1hkM2cV4EWMXR1qqWIrdVdJUYDu/unF6R0Tjr?=
 =?us-ascii?Q?wg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2ff4d42-19ba-4e50-0fca-08d9fa5384ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 00:44:46.4109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZJh+l2IfiP6Q0neHcfUPUwKdNALOKNEpzUZN3b3U7RJOo5MkJdFTsMeuOb9d3wuPpQuvmTEXDYi1UkhuB9FbCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8675
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

> Subject: Re: [PATCH] dt-bindings: serial: fsl-lpuart: Add imx93 compatibl=
e
> string
>=20
> On Tue, Feb 15, 2022 at 04:13:34PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The lpuart on i.MX93 is derived from i.MX8ULP with some industrial
> > enhancements, it uses three compatible strings, so update the
>=20
> Looks like it's 2 compatible strings...

Oh, yes. i.MX8ULP/7ULP is same uart IP.

>=20
> > compatible string for i.MX93. But for a few instants,
>=20
> s/instants/instances/
>=20
> > DTR_B, DSR_B, DCD_B and RIN_B pins are supported, so use one
> > compatible string fsl,imx93-lpuart-v2
>=20
> If the differences are just what gets pinned out, then I think the differ=
ences
> should be handled with separate properties. We probably already have some=
.
>=20
> Plus, while you may have all the above signals, a board design may still =
only
> use a subset.

It is SoC integration level with above features not support in some instanc=
es,
so no such signals connected to SoC pin.

Saying LPUART IP itself support DTR/DSR/DCD/RIN, but instance A has the
feature disabled when doing SoC integration, instance B has the feature ena=
bled
when doing SoC integration. What's your suggestion with such case?

Thanks,
Peng.

>=20
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 6e04e3848261..d7805f31ccc2 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -24,6 +24,8 @@ properties:
> >            - fsl,imxrt1050-lpuart
> >        - items:
> >            - enum:
> > +              - fsl,imx93-lpuart
> > +              - fsl,imx93-lpuart-v2
> >                - fsl,imx8qxp-lpuart
> >                - fsl,imx8ulp-lpuart
> >            - const: fsl,imx7ulp-lpuart
> > --
> > 2.25.1
> >
> >