Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: wan: lmc: use time_is_before_jiffies() instead of open coding it
Date:   Sun, 27 Feb 2022 19:13:48 -0800
Message-Id: <1646018028-61175-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a9B6GkMwKPlWKFpsPHmHw8Q9N41p20KgO6nwS/x0FKWlizmAzpB+QUgPL/4f?=
 =?us-ascii?Q?9DX7CEF1vpaIVVPlL9frk25B8Lx5qZvNCkAdwj+rdgtt/70mkfrOe+fNRgIh?=
 =?us-ascii?Q?j3B0T/3JAmLMX/V7fGL/5czb87jjeZ8G1zTBxlf8M4UqsDPCLPCshIdWXEjN?=
 =?us-ascii?Q?hal3FQEbUJhzZl9EUo2BTxU0FC1aqQTBxuYIzYiPGqUGqmKXNPHT8w39KvNS?=
 =?us-ascii?Q?6r8NfFbv7bqo/Pav11DsEMXrtIWsKSYiti4sYIVxGMMqOR/2pf5v3Tm5foTG?=
 =?us-ascii?Q?9PmAUwx22D7vh5dlI8OIRRLrXIsVyKog8geN7me/w8WC91ZT3jCDmwDrJK+e?=
 =?us-ascii?Q?Kwp2j7ZUdA/8XQD7JSKa5/KWwOKegPmjC+xtbCgfPZDYXQWB1DTeBQ9Nx44b?=
 =?us-ascii?Q?FOjl+UzqxdbRarJaQwt+pUCHbQ+tSa93PfSO7syMzhQDsqVdN4WZaA8x0G6X?=
 =?us-ascii?Q?f5+JCTD0hj3lphsyBgdcBaV0vAU9y11TALXOtZOot+Z6QemN1Bq5yPei2ICB?=
 =?us-ascii?Q?KADY1n2NGtahMTc1ehGy79cySmPD2CYKKxYYvpPqtK9s7nqzzIjBM+2Z9Efd?=
 =?us-ascii?Q?Hr96FDnafm300uPUuvl0MNIVofnJmiBS7Z5TwKwCn6tJ7PGEXlfiDymRguJh?=
 =?us-ascii?Q?+6oId63wE9FCccMUtzoTT6rc8TCaK1P0IqkDWgW5U3qUxX26NNNu01ZaMUWR?=
 =?us-ascii?Q?rZXDfRelq2sDJ0/G2gWJnp7oiXaabZ8rqqaZa7w/E2wQDUqZL1buZKU8z/kv?=
 =?us-ascii?Q?+/y1jWsnZKMGUoUH4wBY9E4ti/jGY3cJroR3/nX5GVGOJskkqIqF2RUyJ9Ty?=
 =?us-ascii?Q?wz8FfGItZsNTdDDYrSbEzpJTkq5O0e8Wuo3BsSit+CnPFv8tuA0VyDRxPx6+?=
 =?us-ascii?Q?KvjRyL8aLyysLbkRxAqaMnfH5yhCD3LpYj2IYnoxPSUL6OcajD/HA9a4fpdu?=
 =?us-ascii?Q?ZVz9lvm3Fcnqzh22iouyN7ftd2Ur1rZxkAacE04W+UIz3ORj7djlOwIMRRXS?=
 =?us-ascii?Q?7BfrR7Q4Sa3XfqlzoNj3cvZbj6+0ak7W3xEAUV8lOeqgQNraqpccM8qan19H?=
 =?us-ascii?Q?4X91LTrbg9NxLdSLXnwY1nTR84c4AmSfUv889bytTE5ivO4nlhm4AKhn+5s3?=
 =?us-ascii?Q?t7BRJCezHOfgLIFNzGH0H5Ao7sX41NKOhfEK+m578YVVrStuWPk7bhe5FLH6?=
 =?us-ascii?Q?UmkzYIHNzNW+8gf/p2epfT88vNSiF97fm3vMtJUXUSIDIAvEcOPvPuyukeug?=
 =?us-ascii?Q?yCgj3GXbHyEtF8ZZnC6yoVU2FalaJdonDHN6kxv7jU3u8yuOYnZPsxs5FY84?=
 =?us-ascii?Q?Xs8caWoMKGJUq9sSbnXoMTkIfboUFexblf6V1UsYsHdZXEMEAFEOEN0nXx8j?=
 =?us-ascii?Q?YMlAhR+0ykOyHTRbnQk8+JmNqVJQL7Mcbjw7yRl0qgHxVk3cFQKCEQ6Z9o75?=
 =?us-ascii?Q?R8kqWaWg6dPrqJYZu1VjOWo+NupE7B0RQgBcFRg+gQ/Bo+qAXV89RWlLwij0?=
 =?us-ascii?Q?1P6xRF+h3aZ0hVGliqWPYtaWCzh4Tyd/CVfyYTluOVB7mn9KnZ1bl9ksDBSV?=
 =?us-ascii?Q?ZQqX7uSorW2DOcT86nOHAzX4y+rHo3mgRegbV9R4cEIM0KmC7dBCexMQixII?=
 =?us-ascii?Q?YaoOL1ZoCZrqkN0aaJxZw58=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b9b8702-7d83-4d80-2316-08d9fa685c3a
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:13:58.2679
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yBTQNKQuJWFFpNsCQtw1FuSpnnULcvVFq58RR6MihPmAJ6U+zQ0pMNaupotbuQ9w1x9LkzC3//DgxE1xNoMnkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2191
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/wan/lmc/lmc_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 6a142dc..76c6b4f
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_main.c
@@ -57,6 +57,7 @@
 #include <asm/io.h>
 #include <asm/dma.h>
 #include <linux/uaccess.h>
+#include <linux/jiffies.h>
 //#include <asm/spinlock.h>
 
 #define DRIVER_MAJOR_VERSION     1
@@ -1968,7 +1969,7 @@ static void lmc_driver_timeout(struct net_device *dev, unsigned int txqueue)
     printk("%s: Xmitter busy|\n", dev->name);
 
     sc->extra_stats.tx_tbusy_calls++;
-    if (jiffies - dev_trans_start(dev) < TX_TIMEOUT)
+    if (time_is_before_jiffies(dev_trans_start(dev) + TX_TIMEOUT))
 	    goto bug_out;
 
     /*
-- 
2.7.4