Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     John Stultz <john.stultz@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] timekeeping: use time_is_before_jiffies() instead of open coding it
Date:   Sun, 27 Feb 2022 19:15:39 -0800
Message-Id: <1646018139-61508-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/ej+NKyhpSMfetd+JqyWX5JGPjOQv7zR+t3TgRmBBlkCLZi+5kIAfZRuYXP9?=
 =?us-ascii?Q?rimssgC+ctmbOH2ob3RRPzStzRz3vMZS6LxpksXxm42aEjyolRO+tyfrEFjm?=
 =?us-ascii?Q?vrMQ67ANNLHeQv2pvq+/LY23t1GMUX7856s1qNMuzTCnN9g4AGhlAs5NqDJp?=
 =?us-ascii?Q?BRxtu8lc49f0MjslJrhePAvbjDV+8S5Z39jW+YABczE8RDaVff/Q/mMgECU8?=
 =?us-ascii?Q?oZmKZ+e8yCeKDJ+n0H8Mrtu5E0Nkg1/1CWFzxCwCMINFETe098xQhZMT8x8Y?=
 =?us-ascii?Q?Dj4xJudRS0Y0NWV1uU+c2wDj14BpS7x1WyrrpyHfxJ5Tr22230pkMBt7zvsY?=
 =?us-ascii?Q?PyIdSwX29OrstYT3KNuL3P9pdnFbDs1eF1JiRkzOBmt2b7cq70pjuW/eJSaX?=
 =?us-ascii?Q?t384s98cbWoQHgq/e8m388KGT2yOtkiYCimEXZaLBwa3UQPMzbck1wROIpkB?=
 =?us-ascii?Q?LAg99y9B63fRQOyNEvUjOXoCngv0gNHePeScqLHg2WMirc7gKsV14JJP7so7?=
 =?us-ascii?Q?JwyJuEXgRtOFtqCExsI1crG0MJEckn4YEaW5V58eQKPWZajcxp7jbpDF9k01?=
 =?us-ascii?Q?gGpypU8v6nqvLc+RvpxjboAcYUcqJsrdCy8pFaXjzza9ae2kohrHpdww14tD?=
 =?us-ascii?Q?6K4EkZSm7Voybwd0V3bZbh9BWpvW3pPc/N96C5qtWCNEqZa7NF5dmm4k8mYO?=
 =?us-ascii?Q?K+CQb3gHmbKVV0lbqqOq6ErSsu+xSRipaSinOpgzRmq8MT9EDcoJIAIyg9al?=
 =?us-ascii?Q?kW4TCR7d5OnZEFFawmVc1EAahcOgCYHEdxqzUqqtwWVOFeWy4BHASbm2Xd/o?=
 =?us-ascii?Q?L+ey7C9v/Qkj8AT17YKv6b6+fS74Th5OOJowbsEGvVr4Ei1MQV8lPH7AQyjU?=
 =?us-ascii?Q?XX/JkKQIReiCuN3QEYyLqXtQrtcwOke87VgAhmjgiyKhL1XEOg8uwJRXM6A1?=
 =?us-ascii?Q?E3IHtP/LmcTEwrRwF1qDP1MPygxA3o3y58AjxhcTfayEg2g6Zvg0qldE2A4T?=
 =?us-ascii?Q?p18Gl7cOcwQ2dNu14LFUsfluFY0hDLXjq/oN+/LJY2L10AvFFJuaWD9AXICL?=
 =?us-ascii?Q?sW3jwEd938EhWsxiF3r8j1sZobfDC5j75QRafvSfVTioNZxZh967LJKxyaf4?=
 =?us-ascii?Q?IUsKoZmUZDxXSVC/r1z/dW76jtU/iTJ3AtPedBE1sEFD/CRkuaPV6auraEor?=
 =?us-ascii?Q?LEnGnSFG/exefgv64KZCQ0jNt+iv53DPRCEETJQJxlaVzJcm62D4mD2JaswN?=
 =?us-ascii?Q?/4IK8JIAGwIskp3zgISgyD/akcXNUZMCxZTWN+Dwq9xy6JZOJ7/U0+S0hKqZ?=
 =?us-ascii?Q?FkaDmtE16Seaxeu29/CxcrgqPl2RwoAOLQWizSVnaNzT4SYkKfJP8s9aJZUF?=
 =?us-ascii?Q?50zb0DnXTygSEvKS+2t0GuZdSYxt3alozyJbeCOjrQr4I6oCgxSB1RbSfmOs?=
 =?us-ascii?Q?qcBK0q5ZQl4sZk60MJ2tA5OZjJh7y7tEKMfBjWWlndnU27cxtuG3GzUgRFnD?=
 =?us-ascii?Q?tevfKLd4tuNKWW3HgTXVZD8QKOju0x1/Xu36Bj/uxASTq+Bu3nGLkmfuO7dd?=
 =?us-ascii?Q?Mrtx7HYaDZ6rfo3JQOzskdWs4fW6FAEPHXa0U+8VPb3RhjSyc04CrK5xatHZ?=
 =?us-ascii?Q?xNwjoBFPgNUf1oSwhN+sGl8=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e325222-9b83-4f89-a406-08d9fa689d71
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:15:47.5586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xB/vg0vFcNziRPTxclA2bErp/KIt/QG3GACCfB7uJdsTeRqhspmLnjwy1IhXiXD2CH5Jho+iUyo5sI7Rzso6vQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2454
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 kernel/time/timekeeping.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index dcdcb85..6f32ac6
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -215,7 +215,7 @@ static void timekeeping_check_update(struct timekeeper *tk, u64 offset)
 	}
 
 	if (tk->underflow_seen) {
-		if (jiffies - tk->last_warning > WARNING_FREQ) {
+		if (time_is_before_jiffies(tk->last_warning + WARNING_FREQ)) {
 			printk_deferred("WARNING: Underflow in clocksource '%s' observed, time update ignored.\n", name);
 			printk_deferred("         Please report this, consider using a different clocksource, if possible.\n");
 			printk_deferred("         Your kernel is probably still fine.\n");
@@ -225,7 +225,7 @@ static void timekeeping_check_update(struct timekeeper *tk, u64 offset)
 	}
 
 	if (tk->overflow_seen) {
-		if (jiffies - tk->last_warning > WARNING_FREQ) {
+		if (time_is_before_jiffies(tk->last_warning + WARNING_FREQ)) {
 			printk_deferred("WARNING: Overflow in clocksource '%s' observed, time update capped.\n", name);
 			printk_deferred("         Please report this, consider using a different clocksource, if possible.\n");
 			printk_deferred("         Your kernel is probably still fine.\n");
-- 
2.7.4