Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b07af605-ab74-a313-f8e4-da794dcde111@huawei.com>
Date:   Mon, 28 Feb 2022 09:43:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH sysctl-next] kernel/kexec_core: move kexec_core sysctls
 into its own file
To:     Luis Chamberlain <mcgrof@kernel.org>, Baoquan He <bhe@redhat.com>
CC:     <ebiederm@xmission.com>, <keescook@chromium.org>,
        <yzaikin@google.com>, <kexec@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <zengweilin@huawei.com>, <chenjianguo3@huawei.com>,
        <nixiaoming@huawei.com>, <qiuguorui1@huawei.com>,
        <young.liuyang@huawei.com>
References: <20220223030318.213093-1-yingelin@huawei.com>
 <YhXwkTCwt3a4Dn9T@MiWiFi-R3L-srv>
 <c60419f8-422b-660d-8254-291182a06cbe@huawei.com> <Yhbu6UxoYXFtDyFk@fedora>
 <YhqLnIjopfoBEBcV@bombadil.infradead.org>
From:   yingelin <yingelin@huawei.com>
In-Reply-To: <YhqLnIjopfoBEBcV@bombadil.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/2/27 4:20, Luis Chamberlain 写道:
> On Thu, Feb 24, 2022 at 10:35:21AM +0800, Baoquan He wrote:
>> That seems to be an issue everything related to sysctl are all added to
>> kernel/sysctl.c. Do you have a pointer that someone complained about it
>> and people agree to scatter them into their own component code?
> https://lkml.kernel.org/r/20220226031054.47DF8C340E7@smtp.kernel.org
>
>> I understand your concern now, I am personally not confused by that
>> maybe because I haven't got stuff adding or changing into sysctls. My
>> concern is if we only care and move kexec knob, or we have plan to try
>> to move all of them. If there's some background information or
>> discussion with a link, that would be helpful.
> We're moving them all out. Sorry, yingelin's commit log message sucks
> and it needs to be fixed to account for the justification. All the
> filesystem sysctls are already moved out. Slowly we are moving the other
> ones out and also doing minor optimizations along the way.
I'm sorry I didn't express it clearly. I'll fix it in v2 patch.
>
>    Luis
> .