Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2478312pxm; Sun, 27 Feb 2022 23:00:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJqLPPdcY0AgKXaROGVx8gD15SWoxVIYPqK5pCC0UQaKsZKle2TRKk1rxLuxApJyhDXWnM X-Received: by 2002:aa7:c948:0:b0:413:2bed:e82e with SMTP id h8-20020aa7c948000000b004132bede82emr18227511edt.394.1646031649433; Sun, 27 Feb 2022 23:00:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646031649; cv=none; d=google.com; s=arc-20160816; b=okHR11Xxq7COicv1JNJnkXUCxv/j25dBhsX7PYtfgfhBq0KT70t0GVTO0hlLSZOdoZ pPd2nJ/caeicjhFXXNeet8jL7IOwxnKp9evBkIsBfEos5B4t9QMmL/cIsP6MkMQFBK/F OCejYGOAE7QNlUzOvPwm0S8iFUJXgD+OTd+9GzDCzI1vUjQ16Z1z9O4wpGi5UCAx8sh9 Rcb6L1HR2pI1cDve6+Tx2HftmlhkrSwK5WV0gj5WbrLjpF2HqCNaTEIA5Nx5qRYoSzuF sJc1I/S1YsUSZip+FLDaMZ/Ukf7jhMihxyfDRwQKcdWVd4f34olJ5tBq1luwhpRolV6x L2LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WDPd4UU66TYdGYyEzivTW4h3BXzO/do4dlet7bzcTrs=; b=bzXajuJ02aqH4bx5QBn0gGeZlBAymvDA3rDycQzNLtAphZFu1yVMEVmyaoklpoLIzs hlQeNWg4KfKhqxRMtAXN3oQ+/+6SjQ6zi8xP9QKIyvFd0N7R36PeWkr99MoRgSzWilsP FuAvRfOojsL/493H+ytaa4yWGQqmuavodv3vAMLk7V0oEQ0mp2/1HcfAnSyv+Qk5igBd wiVak4Ywm9lHSZwBHU9dogDPWq+Cu+f9wEJVkJ8ZEn+05LG4NSD6nivWY9ruOkdReZ2J PtnkFUXJ4Po2W6h3j51ubLz4XhfzKOW+ClX+PzGWExEJDCWre7t/22YM/MimgfiFL8H0 uD+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=HZTxdwhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bi3-20020a170906a24300b006c9e73f6967si5509248ejb.45.2022.02.27.23.00.26; Sun, 27 Feb 2022 23:00:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=HZTxdwhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbiB1DoP (ORCPT + 99 others); Sun, 27 Feb 2022 22:44:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232969AbiB1DoP (ORCPT ); Sun, 27 Feb 2022 22:44:15 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 562063982A; Sun, 27 Feb 2022 19:43:37 -0800 (PST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21RMwaGT029567; Mon, 28 Feb 2022 03:43:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=WDPd4UU66TYdGYyEzivTW4h3BXzO/do4dlet7bzcTrs=; b=HZTxdwhjO6Pw2Qxq8pxHVMvOukRLGlwvT7PFBgEqjESCJ8w1CoUeOcKAh9IFnJkVHnSJ lqgWMV5KgLmS5Ejhhp2cyxkJHQ7w9OTKBoGqFCtq8De5iNKog9vSfYzeHW2Ofw7b3ifO Oss032za4bI3puwS59qV1KgUcbyiDG7AoD2CIg6H0ax5Jg7piGKzY0WtUZEo11tTLLrc z277hi2/yQk2+QUER+UjPtOFCOgfV85YYLUG0b85Y2jSBpabk8Kpzjs9361NH4qrXHIx VK+2upTdNojG+XXMHUo5lmgANj1LSii37xlRFgGuQSqaRblrFrWRtxQD/OH1RJN2uZw0 Gg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3efbttayev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Feb 2022 03:43:32 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21S3bHn3157825; Mon, 28 Feb 2022 03:43:32 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 3efa8bxnvg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Feb 2022 03:43:32 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 21S3hPvw165853; Mon, 28 Feb 2022 03:43:31 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by aserp3030.oracle.com with ESMTP id 3efa8bxnt3-7; Mon, 28 Feb 2022 03:43:31 +0000 From: "Martin K. Petersen" To: Guixin Liu , bostroesser@gmail.com Cc: "Martin K . Petersen" , xlpang@linux.alibaba.com, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, xiaoguang.wang@linux.alibaba.com Subject: Re: [PATCH V4] scsi: target: tcmu: Make cmd_ring_size changeable via configfs Date: Sun, 27 Feb 2022 22:43:21 -0500 Message-Id: <164601967777.4503.13105145657095242015.b4-ty@oracle.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <1644978109-14885-1-git-send-email-kanie@linux.alibaba.com> References: <1644978109-14885-1-git-send-email-kanie@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: hGCbUb_VMG1B_joGWGWU4EG_X7pw8rT_ X-Proofpoint-ORIG-GUID: hGCbUb_VMG1B_joGWGWU4EG_X7pw8rT_ X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Feb 2022 10:21:49 +0800, Guixin Liu wrote: > Make cmd_ring_size changeable similar to the way it is done for > max_data_area_mb, the reason is that our tcmu client will create > thousands of tcmu instances, and this will consume lots of mem with > default 8Mb cmd ring size for every backstore. > > One can change the value by typing: > echo "cmd_ring_size_mb=N" > control > The "N" is a integer between 1 to 8, if set 1, the cmd ring can hold > about 6k cmds(tcmu_cmd_entry about 176 byte) at least. > > [...] Applied to 5.18/scsi-queue, thanks! [1/1] scsi: target: tcmu: Make cmd_ring_size changeable via configfs https://git.kernel.org/mkp/scsi/c/c7ede4f044b9 -- Martin K. Petersen Oracle Linux Engineering