Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
        Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] scsi: bfa: use time_is_before_jiffies() instead of open coding it
Date:   Sun, 27 Feb 2022 19:14:35 -0800
Message-Id: <1646018075-61321-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VP26WbaaOyeqIpx/1lHRqZ4FTeApAQuujihtiKZMkqAjAAH1Bv/aKd5GxZiI?=
 =?us-ascii?Q?D/gVS4U/j4v3T6vEq4L74wMwnY2NwkMPxVnVN5U1KI/Q8SjZSxcPhh7Mhaug?=
 =?us-ascii?Q?2xdpv66rMn8iGGhuVGlW70gD52PPr8sPlgp2YgAawiiGsBVaMwZVkd2TfdDH?=
 =?us-ascii?Q?wtRCxdxiNIfvGUeiQqzqoWcOHLgthNBFHm4kFAjpUkj846TGOeO90y0seBKj?=
 =?us-ascii?Q?maRQD+/dEE2bSeJSpHCNdRInP6pW1ekx/eGqiOVs0IsR0Sz8+3ixmjTSjwVJ?=
 =?us-ascii?Q?XLzuD827nvr8SoIys9NNJuSB1LmQ3UDAU+a3C/oBPSOBv8FL2Rj+0NOckXe0?=
 =?us-ascii?Q?ogihJaC3+QVpzvPHDtAwvHmyxWlWnaX2KR2U6ONqSpoRCovtL8ELgQdsih8n?=
 =?us-ascii?Q?E9+xTY0iMo0ycxlgZqV2YhxbMcwikVXgcpJuk2GiA0GNDUbqBBmMxXXn3CSZ?=
 =?us-ascii?Q?2eBbbIllVtXjIwU7f9korOeGicr1xLsmTuaIAu8iV9+tP2bip+tVhdMfzOJA?=
 =?us-ascii?Q?xvnYL5xX8g/DF1jNQn0Sqtwz/hdanNfFqdd18d9PA4+nj1UBRvDrAJ0QoiFe?=
 =?us-ascii?Q?j5SRA4AH17QQY7X3J/5eHTZP//G+u0Fz9PqHVVhzRlVR7dtrhL4C5CBiRgyY?=
 =?us-ascii?Q?CQUQf+QwOTHWo5+VRJP2O7HDpIN/hSDPqrUxRoj1kKapqGFGF2miSYgLEVdI?=
 =?us-ascii?Q?VRuEUJ1i2XHTi0SbLkmuCfaoic+kL45LB9t3w3geGmyMAUlL4YQCcjCKMpDM?=
 =?us-ascii?Q?MRMGMpR8dr+owslCY+1vH7xBGg2EVx+Uz8Leh2YX130LdjR3FdwY4sqYlPIM?=
 =?us-ascii?Q?c40KYcSwCw9cbOaXhDFFMOI+wQxe65O21+Kr1WTktYX7SKvi+I8KLkgLiTxi?=
 =?us-ascii?Q?Cif5uLEfsOWlE/9zTIjdz1YGnndfUqtx2fUjCExCB7FP38NuFAwZQpYOgPyG?=
 =?us-ascii?Q?4Z/VWwdGxg3C/PKy3ehV31LTXCc0RxP8bSmqir/6t2mjonpiHb2IClZAObZT?=
 =?us-ascii?Q?aggN+4cbf9HBeQ3Io3fX08aBJeJ7hmDaUBYXPetMs95sjLwliFncNtZhE7ov?=
 =?us-ascii?Q?g+rhmyMDAmYTFb/pOBKGVPDyHNsVNU8cyMEXGOdM/ksx+0YFz6qxZGX0ljdu?=
 =?us-ascii?Q?utFasBZQxqsmHeMAy4eSRV0wrUy/FFYwNq41PX6pwCCSojriMXvMKcxbltCj?=
 =?us-ascii?Q?mZsD+ahralU6jMUB/ixglfdBOdlVwzTQxfztRbsleHykVtCKpirg+cQYVU9Y?=
 =?us-ascii?Q?JCiWpCBUgl5YdHpK4+tnOzaX3ocJ6VEnnDqshTeBuGpfPDQ79TiIxQos8Ic+?=
 =?us-ascii?Q?y/JLQN02rpuw0M2jUQd4Njb9p4HyiaVOkcgHcgBSARbtObkCpkLN/2vZF2Ur?=
 =?us-ascii?Q?nt9yXM6cC0g3AgGEs7GjkUM/biiYWeobddKgJHUBg3r+NV/rJlxPvjkv7p/v?=
 =?us-ascii?Q?qHxW6cXTptGKmuxL7+45sCVcfXFpbW9UoV0n81F9NgkYUwYw9try72E+Om7b?=
 =?us-ascii?Q?11BAFH8wVcG14pq90GeVUP7SN/k/ej/qVSnWLLL5upKgoKl/gx4ZfGKwe+Jj?=
 =?us-ascii?Q?Jnw+D3fYfygp69b2JMVboBgxFDNz5/IfKwUiF8B2J/pjRWJePoVaFNZKBkHD?=
 =?us-ascii?Q?I0+cEde5Ol8XLCWkwk0jFYQ=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13b59f91-547b-4e6d-8480-08d9fa68796e
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:14:47.2339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NWHRmduPfb5+LO9mjX0Vis0h+nfGplZClpB//D8eARTEBiCY9sq5KMFdDBMa967DyCR3RS5XP4Mq8kF0fvDN+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2454
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/scsi/bfa/bfad_im.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
index 759d2bb..41f49f5f
--- a/drivers/scsi/bfa/bfad_im.c
+++ b/drivers/scsi/bfa/bfad_im.c
@@ -13,6 +13,7 @@
  */
 
 #include <linux/export.h>
+#include <linux/jiffies.h>
 
 #include "bfad_drv.h"
 #include "bfad_im.h"
@@ -870,9 +871,9 @@ bfad_ramp_up_qdepth(struct bfad_itnim_s *itnim, struct scsi_device *sdev)
 {
 	struct scsi_device *tmp_sdev;
 
-	if (((jiffies - itnim->last_ramp_up_time) >
+	if (time_is_before_jiffies(itnim->last_ramp_up_time +
 		BFA_QUEUE_FULL_RAMP_UP_TIME * HZ) &&
-		((jiffies - itnim->last_queue_full_time) >
+		time_is_before_jiffies(itnim->last_queue_full_time +
 		BFA_QUEUE_FULL_RAMP_UP_TIME * HZ)) {
 		shost_for_each_device(tmp_sdev, sdev->host) {
 			if (bfa_lun_queue_depth > tmp_sdev->queue_depth) {
-- 
2.7.4