Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     Guo-Fu Tseng <cooldavid@cooldavid.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: ethernet: use time_is_before_eq_jiffies() instead of open coding it
Date:   Sun, 27 Feb 2022 19:12:22 -0800
Message-Id: <1646017944-60946-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V8iaMdU8Ljn5zSlg97F1KjOEX4tnkKKIAmjFPvOQwBKCr6snezZKO4apRGBN?=
 =?us-ascii?Q?SERoTX287fzF9mULfdy9DLKaLWY+XCeZ6weT4w12dxEhNID3z+k4BIIWepfs?=
 =?us-ascii?Q?4trijiVesXGjYqqkO59+qbFqK5X/FzilAFDF+YdnEXq4bc+P8hCmRJlaQMtK?=
 =?us-ascii?Q?CsKnAr/okdKHYhCueL304Lc0KRHeKpnLwN0fcBk6q55wfi13B7ALachb42ZH?=
 =?us-ascii?Q?05CbeiteZv5praMC+AEyQ1se+uPEOoUXEDavJfJ6U2MgrZfbM1yL4YgWk8vd?=
 =?us-ascii?Q?cdxGBH7S4C1LsDDmEqFKBVShQ9oDhbLKi2CXd6FQd1bmmrV+39YqzwGrD7jW?=
 =?us-ascii?Q?FSHYLGy8pxrvvopqf+h299FqXGGEMBUeINonmW6vOHXsBV9KQurzNR+yKX79?=
 =?us-ascii?Q?/mY09erG6Xdn8QaSmnYknP+/eyeZEbHgrMFaN0TV0V0rArWRRFFzuxaolOKH?=
 =?us-ascii?Q?gtgmOWVn/ZPUmAx0Eh0t8gcu8MlNr6/aEPwezoMZ6Zd/HHrq6dELxfvLz9QM?=
 =?us-ascii?Q?RRaDGZjS55RkPvk9begVjA2REYtO786rA+PGwlFqigwRbDEbmqU+Gt7qCcOE?=
 =?us-ascii?Q?lLx2bSZpatppUniUy492QEhtk/NpkDecOTxdrlDVsdQzGrN+HbpGgwTnEIPx?=
 =?us-ascii?Q?c9pj9Y3bsGMfeAQEwmlUCsIrDYgfKUBJmylox9X609FcQScuLYG/+6dm/SgJ?=
 =?us-ascii?Q?xbEC4ako6Zs5QvbWh2rO+6MJy7u5AHO/a7FaY7i7JK+iVDtzX9hDoIM/J63n?=
 =?us-ascii?Q?zguIKXbOo6HjLJqePlpS5jZts/zRz2OH/Fvga4wfE9sNcHH6ZJXhXexG5O+o?=
 =?us-ascii?Q?bpLhXaLob2BhohhnlhT07Ujzt77TY8+hiPMFJ2JN2GrhXOR3IESeQKd3yuJT?=
 =?us-ascii?Q?/fFzoa0rbadodOPK3PGhhRrcAA0pPhUxiIwmK+bH2KzOgJ5+wFd+NB2ExSpP?=
 =?us-ascii?Q?Fs5Y0bzWGxtTr9ZCMIt61ii6Zug61E7Am4KP6IrgNzgfrluEimuC0I5xeV16?=
 =?us-ascii?Q?H/fNqlJNOwbWKwUWQ8HhdwK3+Z7dMOSCy/DylCte4MoMeFokeDv+jGoYpnIf?=
 =?us-ascii?Q?H3pQr4BCM7kWCIK4d4+KsN9AQus4FI+S/HjTxfSR1aflOSWd1vfXuT6xgdR9?=
 =?us-ascii?Q?ljrVFkGz//CPTMN3Ky4KeuYdwG12RxguzUFR0gnkhQMlrmoaB1cUWJDGr0UI?=
 =?us-ascii?Q?FcpeqLfJgyMXJmldkt09kj1pvhisyfUR/my2L2GQUmCihRDS25OWqtXrA7PD?=
 =?us-ascii?Q?XWmz+vAVdFE/cOjKKuWqNXmO1JI25CUIDAy5cXcLIxc51N7109TB4z2l7LQR?=
 =?us-ascii?Q?tSPd4wozasZCH9ERVuzZhHCD6DIo1p3prCb1Qe32dEDnhDiv+PM0fKUcMSxk?=
 =?us-ascii?Q?qZ8fmOv9gQIkuar+FEJ0d72D9GVXeTSX5z/1wWofHJ96mZw+gUTmGLRdm2Tf?=
 =?us-ascii?Q?Z1SqRalARWIiR1u0bQ6HNIvSqNjKgJphzYqFPfCuqRzIhsX6/eoVdGf0ispG?=
 =?us-ascii?Q?NVANDo2u9Sd0pXTnydT4zBgwDlz4ckFo2plWS/K+JCmx1MqzVDzUi4/OXgvG?=
 =?us-ascii?Q?ie+/3DztBN62xofOtiqEsZ2hLIzZ7HIOZtadf6yeQvxT0XnuFa4S2BMOHmeW?=
 =?us-ascii?Q?ZfAeAnIUkKq+VJvMzAKZEtk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c83170b-456b-4508-7ce0-08d9fa683077
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:12:45.2721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wqL1/JJj9cILnph3pM1iMoRbNdn8FaHpRE2ceyZAw0a69+2hn4+SgHhXGc5WjtkOSeyzIEVEmb3EjgUD0QvuzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2454
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/ethernet/jme.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 439674f..b6c5122
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -28,6 +28,7 @@
 #include <linux/udp.h>
 #include <linux/if_vlan.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 #include <net/ip6_checksum.h>
 #include "jme.h"
 
@@ -2179,7 +2180,7 @@ jme_stop_queue_if_full(struct jme_adapter *jme)
 	}
 
 	if (unlikely(txbi->start_xmit &&
-			(jiffies - txbi->start_xmit) >= TX_TIMEOUT &&
+			time_is_before_eq_jiffies(txbi->start_xmit + TX_TIMEOUT) &&
 			txbi->skb)) {
 		netif_stop_queue(jme->dev);
 		netif_info(jme, tx_queued, jme->dev,
-- 
2.7.4