Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Finn Thain <fthain@linux-m68k.org>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac53c94: Stop using struct scsi_pointer
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfs37m64.fsf@ca-mkp.ca.oracle.com>
References: <3529a59873a7de8455a27af2528341afe5069adc.1645484982.git.fthain@linux-m68k.org>
Date:   Sun, 27 Feb 2022 21:35:55 -0500
In-Reply-To: <3529a59873a7de8455a27af2528341afe5069adc.1645484982.git.fthain@linux-m68k.org>
        (Finn Thain's message of "Tue, 22 Feb 2022 10:09:42 +1100")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5+9ugNhguLsLvpDkK9lDlUw+YmCMFxZWPMKu27Nev569joDnCP0Ss1mhXfky?=
 =?us-ascii?Q?i2hm62w9h1/RtAYSjMHWAxYOGnICSKZT2Iulhszoq3n9NSzQjl5NugUsFXB0?=
 =?us-ascii?Q?SX0tY0BM8JsL9vq0JQQlQ5L0Bqqv4a1m/fPsSS9UNYXLGICBQ+Ky6lTeWuw9?=
 =?us-ascii?Q?fZWTcN0cR0X4dIPKnPtTMHQMQ/WqJDDtlacGe16WDi6L39SbrMubNM2IYF/e?=
 =?us-ascii?Q?7QxHmR2qxpu1/lADz6njCD9JYtVRYjwAvKdTDLEvQyREeaTR/fV0whLcYNvp?=
 =?us-ascii?Q?DM5w92CsgiMlEjYrmINZJyl1aReKxQbHi6eKKapW5xzE1WbKW//RiuJubizn?=
 =?us-ascii?Q?y4IXH1T/IssmwYnDa2GhZM3zfDnelSZQVspJMIjPtoWj5d1gR9fU+MRCav/p?=
 =?us-ascii?Q?Fks3Ls1gVUfkXqQwc2akayBL/deqvMrTybYi252ZG1xD2wwG3M8DXFusqlAM?=
 =?us-ascii?Q?BAwGdaXZXmYlyt21hUYDOh5u4pWf0LzhKVj3mE/a+vxw2robyjN7n2C1HPDp?=
 =?us-ascii?Q?NLqUBTbb8u50tBmx1uSoJdpkMVXfKISFlAcs37WoHvmfIFJDDIpQr+Tt72be?=
 =?us-ascii?Q?2Q0Y7N9qWB4Tp1Ia4V7B6uZWOXj33rMGoX6CQPj8WmgKND3XFd1nrn99MYOg?=
 =?us-ascii?Q?36ffy/G8DyPFcsXoNT3UuHkHqyg/X3zFFeJItFb+DIvJiAFcysAq4sG3uRG9?=
 =?us-ascii?Q?D1WbSM4jsobRPu6EM9pUr9+11NCv/RF0K+RB1/h2jtg9F176sd9Uvj1FbJbj?=
 =?us-ascii?Q?mP2QmUcBylhiK++u7QJ1FqO9AWQAtuoXe6m2wq1e5uhvqGenWlrqlgLf3GBY?=
 =?us-ascii?Q?QVmfGTuCmv/oX4IHyOjYnj2kCJrYCE0uwhwf454X6jDy13jg9AOvu/ukxGoZ?=
 =?us-ascii?Q?6a1J8FXc3/Il+MI3oRiXIkv2DgNBjpeUK+/JqtcmTl1BxUEeZ9SdrraXDDyo?=
 =?us-ascii?Q?9I778S6sXqBKU37BqUGNNTtJ7TKa/w0Z23DWBCe0lwievIMavYysGcAxEGFQ?=
 =?us-ascii?Q?iapRDLwUqcoZUikVX7OSasEIExkoYTl55O3dAybGy0Pfi4qcbl6bv46TPmh8?=
 =?us-ascii?Q?l3omISdBrR1NmflOnnuLBGjmMsZXpYaX4G2h6394ATiWFSFGpdZvppQS74BP?=
 =?us-ascii?Q?XNZhwCj+vuZ/QDwDmjGdyAy8o7RpVrTLTGt6T80wb1pM1rHrNi1iiySmh6R+?=
 =?us-ascii?Q?B2Ehb9i8sCzotAyUrLGr/DIqYE5xAAA19AyOy8zd1U7SuIYD1DDV0tzN2i3m?=
 =?us-ascii?Q?WlCLPSTfBuS95F3kW/e6UAjReRIyxj8/ReIjYpTnW241dG49EOOkrIxoWC0f?=
 =?us-ascii?Q?HUUIm6/hsaYTDVk/B9ZtK6T2wvnGglih+cFsaHZWUKhsEGC9lC9+KgOg8Pqg?=
 =?us-ascii?Q?iU/inynxX3G2dn3QSzRW/EGFYcwTcM+i5/HqOjVBfLG8wJMd6f5B9lEfF5Ch?=
 =?us-ascii?Q?d/4Ak2npqJOcjrYCYHzNWUNXmDlfMUDCQE0HT8/suBD6o41WnlHtXjxNVyXW?=
 =?us-ascii?Q?tgo+DKk81Z/SLl3Nkvh5AZavwaWwZLzM15jfbC6KxiY/O6nLhHOGg83ZPyQK?=
 =?us-ascii?Q?Npml79YbfG4GGH6Zc7V54SBMmfIotecAmrUK4sLjHqw1M/2OCCcXFfktrgmA?=
 =?us-ascii?Q?tTrlYHFnJWY222vQP1fSnGZRZWaKVAAqpIHOoebMiGrW9yuu8tXk7dzN88p2?=
 =?us-ascii?Q?tvvUcQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01fb821b-215e-4eae-5c91-08d9fa630d14
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 02:35:57.9031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8zX4WCDy9BLOaF97yBSXm4F+t7g1MOmVcNxECQ4bW3q24uHZLAeUCcBACW1uZc7u6+Wp9WaGtYji5q5cD1mMRsGB3qLtk3/HvjExcYCUFi4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3717
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10271 signatures=684655
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=903
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202280013
X-Proofpoint-GUID: Gr2zPPP59BWH3ZbAzxCZTbz0eHX_8F0N
X-Proofpoint-ORIG-GUID: Gr2zPPP59BWH3ZbAzxCZTbz0eHX_8F0N
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Finn,

> This driver doesn't use SCp.ptr to save a SCSI command data pointer
> which means "scsi pointer" is a complete misnomer here. Only a few
> members of struct scsi_pointer are used and the rest waste memory.
> Avoid the "struct foo { struct bar; };" silliness.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering