Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d4bca06-7d4f-a905-e518-12981ebca1b3@virtuozzo.com>
Date:   Mon, 28 Feb 2022 12:13:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Vasily Averin <vvs@virtuozzo.com>
Subject: [PATCH v2] memcg: enable accounting for tty-related objects
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     cgroups@vger.kernel.org, Michal Hocko <mhocko@kernel.org>,
        Shakeel Butt <shakeelb@google.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Roman Gushchin <guro@fb.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-kernel@vger.kernel.org, kernel@openvz.org
References: <afbaec7c-1872-d43a-1240-e077adc0d6d9@virtuozzo.com>
Content-Language: en-US
In-Reply-To: <afbaec7c-1872-d43a-1240-e077adc0d6d9@virtuozzo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aE9qYmlEa1VxbnZtWDRVYklVMjk0R0NyeEZaN3BrV3E1TlZzNlA3ZDN6eVNi?=
 =?utf-8?B?UmRobElERjhUNG5JZDFPU1ZhQ09jVE51enZhdXhOYjR1SGxKams0SlhmSmps?=
 =?utf-8?B?dC92Y3BHeXZrNkdNTUxMM012R01rWTlvZktUVXlCUk11aUk1aXdYRTcrUW1G?=
 =?utf-8?B?d2xlUVRWQTFrNTVaMnZBaGcvZlNabExWaGNvRXNMTW5PL20rNzJ4TlZ0VUUx?=
 =?utf-8?B?VkM5dzlQNU1kTStmdkUrRW84amVJVU1hVWMxZjVsWjBMZkxmQkxXeFY5dlNJ?=
 =?utf-8?B?S1cybGplSGlJbytZcHJlMXdXV2lkZEFCNHZYQ3ZuR0JYekFtWnV0Wk56YkNH?=
 =?utf-8?B?cm50RWFmdUZQU05VamtoR1BBTVpycFp4a3J1K01XUlBpWnNxSUovZ2IwMmsr?=
 =?utf-8?B?T3N0eXlWUk9BcTNRUTlmV0ZFQVd3NkpWWUMwL0ZTTUpiUEZFV093RWFYbTF3?=
 =?utf-8?B?UWpPUitsQjJvUVlhcGNYekNYK29yRkpMNGY4dmxIbkNlZVVLclg5cWxob094?=
 =?utf-8?B?aE5HdEhSaW53TGU5RnV2QUxrR1laMzhjU2hiTmlaYjZLK3RsVXd4UE1Lemkr?=
 =?utf-8?B?Q1ZDWDJ2NnlDc3hhMnU0QWRONXc0bGVhOW1weVR0MVg3NWZ3b2NKNDVpcHlp?=
 =?utf-8?B?ZzlzNmZpZ291OFo5djlNU3B1c1ZMK2lZZHJRM3V4OEhMaXl2TlJqNDg1ODk0?=
 =?utf-8?B?SmNGWFBRV2ZvcGdQT1NzOVJ0NmdnQTQ5SnovL1ZVam13Rit3VCt4M3VWSDhi?=
 =?utf-8?B?N0M2UGtVRERKYk84eDlCdkdmaVIwU0cvVnk3dkpzYW9xeXB0aUJsZUFTQXdq?=
 =?utf-8?B?LzJzWjd3UTEwLzVZOFM5SnI4V1kyZDFqdGRNdG4vamx6Zm1pWlpuZ1VIeWlQ?=
 =?utf-8?B?ajV6aEhIZGxBcjhyUUN0MWtQekQxdnhIYTBWb0owYVVDYlg3b2VvaVF5Vm9h?=
 =?utf-8?B?ZllNZzBjaFIydjhIVnJITWJOVnYwemY0MEtxdi8renNVRWgyckt3a1lOaGdK?=
 =?utf-8?B?K3pqQlBERkhzRkQzZ1BPY1hKVElGOFJzR2FGaWYraHZtMlNSK25VNVRhNGNP?=
 =?utf-8?B?V3pmdWNNTS9NWWpNbm9qRFBsdi9SSkdUTVlQTGpETHN6T0g3enI5OHN0cTli?=
 =?utf-8?B?dWVvN2ZQWGNMOXpmNU1aWG4xcEV3VFRvMzRDQlcycFpWU0pZMXI3SDdKTlN1?=
 =?utf-8?B?eWV6RzBHOHJLWkFERVIyQ2lwbUFxODhLRzFtNDU3V1k3NmJqZUMyNzJLWm53?=
 =?utf-8?B?V2ZpNnlqWitFSlhYK0U1YzVIZEppYTQyL2lFaXdMZCtwSUxmNHV0aEt6RHJ1?=
 =?utf-8?B?UFVKNElacXNXZFRkcitGU2dZZ01MdjZPZmFCeUVpbUdwN05aSHJ6M1JaWlpY?=
 =?utf-8?B?cERIN1lCRFVTcERFK0Q4dDNrUTZZVnZTSy9HZVZkZnpCM3BuSUpYQlNYcC8z?=
 =?utf-8?B?RXJqTUNQRENiaThjSzgyWGdzMVhLN2pKNnFZK1VDNEh4ZDY5ZlNIUUlKK05T?=
 =?utf-8?B?SXB0NkJoVkJvSFhaSVdSRUpEWkhXS2Fzdm5MNndzMmRjV0RTMUdLNnJmbmhp?=
 =?utf-8?B?MHJtZEtZVDZURGVGdFpMTkpHWXprUnRyMS9nMWJRbWc0NVMrU0c3ektQWDlQ?=
 =?utf-8?B?aFJLcUpDV3VLVHE0U1k3blhIT0RnSlMyQXRVeWpERmZ6eTZjT1lBb3pnM2kx?=
 =?utf-8?B?SW5LUGk2eG0zU0JjeS95dHlheGlVRmxRcERJMXdRR2RWMmI2bzFBaEFzb2ZR?=
 =?utf-8?B?d2g0YzE5a2xiRmUrS3NmaXczSVJZd01aR1I1WnNRa2xXMkRSSnVCcTBuNDdG?=
 =?utf-8?B?ODlOSklUcnF3Unl5RWFySGxNMnVrY0ZoOFl2UTcxcUdIOW54aEc2RFZJUStp?=
 =?utf-8?B?MXhqOE5Dc0VLSHFpYi9MYUowZWZLZlptb3d6U1J0TCtpZHBLUDdYOW96Z3Fy?=
 =?utf-8?B?OXZ3cUxmV1JhcjA2SjlPSmsvOFJBYkVXeHpESTFLcjY3VVBjVmM4WTkwZVBl?=
 =?utf-8?B?aHE1c1U0N21RcWdIOFc4RXV4UzZ0NW05NFRpRkY0c21TNmF6bzFUclFVbUJQ?=
 =?utf-8?B?RFhHMENvVkxXcnFmb1FKNGEwNCsyT2JQak02R2Z4dDhlSVh0azkzR2R1YWR1?=
 =?utf-8?B?ZjhDWlRuZ3FLa3VvSzNUYXh2aHgxRWZ6QUxRR0loZGtKVjVnSHhUcFo3RURX?=
 =?utf-8?Q?KpVRheHgtkNsiZUlPhKx0GA=3D?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07f53fe1-abd3-4267-6d8a-08d9fa9aa6c1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB3245.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 09:13:58.1893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O5i+Don1hbqJ8TI5z0inqnbuYxf2hNfFpek4pc3erzkHhdL/ow3FtAIy7fgPGbX3ZJho+YhZ6FUhG1ZZ5oE8JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3940
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At each login the user forces the kernel to create a new terminal and
allocate up to ~1Kb memory for the tty-related structures.

By default it's allowed to create up to 4096 ptys with 1024 reserve for
initial mount namespace only and the settings are controlled by host admin.

Though this default is not enough for hosters with thousands
of containers per node. Host admin can be forced to increase it
up to NR_UNIX98_PTY_MAX = 1<<20.

By default container is restricted by pty mount_opt.max = 1024,
but admin inside container can change it via remount. As a result,
one container can consume almost all allowed ptys
and allocate up to 1Gb of unaccounted memory.

It is not enough per-se to trigger OOM on host, however anyway, it allows
to significantly exceed the assigned memcg limit and leads to troubles
on the over-committed node.

It makes sense to account for them to restrict the host's memory
consumption from inside the memcg-limited container.

v2: removed hunk patched tty_save_termios()
Jiri Slaby pointed that termios are not saved for PTYs and for other
terminals used inside containers. Therefore accounting for saved
termios have near to zero impact in real life scenarios.
v1 patch version was dropped due to noticed issue,
however hunk patched alloc_tty_struct is still actual.

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
  drivers/tty/tty_io.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 7e8b3bd59c7b..8fec1d8648f5 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -3088,7 +3088,7 @@ struct tty_struct *alloc_tty_struct(struct tty_driver *driver, int idx)
  {
  	struct tty_struct *tty;
  
-	tty = kzalloc(sizeof(*tty), GFP_KERNEL);
+	tty = kzalloc(sizeof(*tty), GFP_KERNEL_ACCOUNT);
  	if (!tty)
  		return NULL;
  
-- 
2.25.1