Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Potin Lai <potin.lai@quantatw.com>
To:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Patrick Williams <patrick@stwcx.xyz>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Potin Lai <potin.lai@quantatw.com>
Subject: [PATCH v3 1/2] hwmon: (adm1275) Allow setting sample averaging
Date:   Mon, 28 Feb 2022 18:37:15 +0800
Message-Id: <20220228103716.10774-2-potin.lai@quantatw.com>
In-Reply-To: <20220228103716.10774-1-potin.lai@quantatw.com>
References: <20220228103716.10774-1-potin.lai@quantatw.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U9bbYv7ieMQuxpYeJnHnnZV5L9ziZEvpg8VkrAA/WGijC29o+hnKgG+tJ+Fq?=
 =?us-ascii?Q?CPjiJsqdL3LzTKD7N0Tq4s1ywPANb7D+ASk6kWX8u1/+cp/2McgSpinVr3S1?=
 =?us-ascii?Q?r146hi1H2PLRoW1PAbQ7YAZlUjtLqIJaysErO1RKE17FwotsPSuhFV5cb1Eo?=
 =?us-ascii?Q?Kgr14SriMLlhyh6fayhNALJz3vM7MSH1Eb4NoISgrLtO0/ziH4YVR4ODXaFs?=
 =?us-ascii?Q?DWOLY3jx+Hb2OQiW65RrOPq32OTNfXS7fQ32vZJDUIrGAjAC0vNt6xpnQrH6?=
 =?us-ascii?Q?bjG+FilicbC5hRNqHkpyZh9430plfN5glM8XoLfn+nlbGn/N+LEW+CRUszMe?=
 =?us-ascii?Q?eSd0Hmg/2ZjkcQr1sivpzIK1ByHxKQeJj3luFesULinJJ2iPM2C3RUD/+ag5?=
 =?us-ascii?Q?zy5FiTyZba78EC+ZF0REifp9TRnwQlU2X7FAebx0GOs0K8GWeXw4jA7SbGsb?=
 =?us-ascii?Q?baILHU5MzUVxu7FM8Rn5MV3sx90uiLXs40sqrSej+yiWkqwSHstwDOu6dyp/?=
 =?us-ascii?Q?uRq8Jg1keZNfdwvBBbHRmB9oGHnolkR+7qaQcw+v33mv7oC9wpNskqi1JNAT?=
 =?us-ascii?Q?j4QVF+fxZHxMcmgm8S1xK1IqSWwWyB6NKlkcTjdRuo28yReeAtjE6K8cKV5b?=
 =?us-ascii?Q?3iyuSd7t0ZWyrsWOFLGydZzStm4VWQhYQ5hzDhCmLGjIeG9EoVIAwTvs+MtO?=
 =?us-ascii?Q?QgUiD/oahZyYQ2P1XAtc3q5v2BMMIdJfzHTHngab5L1Vi2uyoooWe9ZWw9fP?=
 =?us-ascii?Q?99S6W6fJpFsExjmvczcahUhd8bmT1vvKwNgeyjJr6uMclfq2u9rbxTtpICys?=
 =?us-ascii?Q?2DP+NXX/RJUoMy+RDm30+z3MyTGX1yAls53OoXV7HQs6RSLq1/gPHLnvjUJF?=
 =?us-ascii?Q?tfUVFzCiL4NZSDZLaFoX9SqqUvC6j4uk2n5nyzJaP4eOVsRjPnypDzTenSKk?=
 =?us-ascii?Q?R2BgHsgj86X8//bZpCEo7atEDDtULXh50cfWQ/otCBdjN6T9WNwtFnRLA5pT?=
 =?us-ascii?Q?eJWpVba+m6CpnEol7ahTMqVZjOT2yG3zLRVB8bhyAk90U6QU9yQa5RA20m08?=
 =?us-ascii?Q?sFEFyiOuqQmZUyh0OjwQ0QvlJHp8xFfKsltl6w5QbMA6hlIKQaHRWdvq0NFo?=
 =?us-ascii?Q?fbwwJ9VG/5whQuLmXHDQMbnLeIQ8dHz+Dqwhsd3nvbUpqcbpM4hxwEHiRJEF?=
 =?us-ascii?Q?UOaCYcQUDSNp1Bjz7IFVAU5o8n7O95eGmFYoAkgUNui0ImUaKqr1KnY3bC1a?=
 =?us-ascii?Q?u2vBxWKKktYtz6NyItZMTe5JqsuLjtXDoKDTnX3mctlFWj/5y2r7uWtqiZWR?=
 =?us-ascii?Q?PIA5VJ1eHgCisrKq8k7pySN/tXQ0MyuYoDNmONvZ6JAtuRCub9G9cgpSc4Fz?=
 =?us-ascii?Q?rMHbrNyCPbFH5eRWb7DqoC1BSe9naGWWmRGvmBKG3L094rHcBBIHO+zTt586?=
 =?us-ascii?Q?6D0tsijThpIP+gJh8VkIq++6OlEyZrVdAyvUdlpsQHac0i7b9sSX4oGTbFuG?=
 =?us-ascii?Q?rH3OJoVmI6LKiWbePXxyhowaDA3/2/JBGNZ8dPnf0CtkbVkiUBlTGYRb49aE?=
 =?us-ascii?Q?lV1CfZzpZ9q72Cy/oHXdbYOhNSynyI7djS/e3b3z3wfgti2Z5omM3HYMvAbn?=
 =?us-ascii?Q?eINIKGpppmFV2d7AjTgWh9s=3D?=
X-OriginatorOrg: quantatw.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec95fe24-6abb-48f7-5e16-08d9faa65657
X-MS-Exchange-CrossTenant-AuthSource: HK0PR04MB3282.apcprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 10:37:37.7685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 179b0327-07fc-4973-ac73-8de7313561b2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FOtD+kTm2XsUcLk7mNGBK7onOHswafXIL4bSMwQsEYI/IbqB+waxq/lVhRj+SuOWpUBaMX1cX89tpwr6FjMtGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2PR04MB3002
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Current driver assume PWR_AVG and VI_AVG as 1 by default, and user needs
to set sample averaging via sysfs manually.

This patch parses the properties below from device tree, and setting
sample averaging during probe. Allowed input value from 1 to 128. If the
inputed value is not power of 2, the sample averaging number will be
configured with the smaller and cloest power of 2.

- adi,power-sample-average
- adi,volt-curr-sample-average

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
 drivers/hwmon/pmbus/adm1275.c | 36 +++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
index d311e0557401..212c7f3c59b0 100644
--- a/drivers/hwmon/pmbus/adm1275.c
+++ b/drivers/hwmon/pmbus/adm1275.c
@@ -475,6 +475,7 @@ static int adm1275_probe(struct i2c_client *client)
 	int vindex = -1, voindex = -1, cindex = -1, pindex = -1;
 	int tindex = -1;
 	u32 shunt;
+	u32 avg;
 
 	if (!i2c_check_functionality(client->adapter,
 				     I2C_FUNC_SMBUS_READ_BYTE_DATA
@@ -756,6 +757,41 @@ static int adm1275_probe(struct i2c_client *client)
 		return -ENODEV;
 	}
 
+	if (data->have_power_sampling &&
+	    of_property_read_u32(client->dev.of_node,
+				"adi,power-sample-average", &avg) == 0) {
+		if (avg > ADM1275_SAMPLES_AVG_MAX || avg < 1)
+			return -EINVAL;
+		dev_info(&client->dev,
+			"Setting power sample averaging number to %u",
+			BIT(ilog2(avg)));
+		ret = adm1275_write_pmon_config(data, client, true,
+						ilog2(avg));
+		if (ret < 0) {
+			dev_err(&client->dev,
+				"Setting power sample averaging failed with error %d",
+				ret);
+			return ret;
+		}
+	}
+
+	if (of_property_read_u32(client->dev.of_node,
+				"adi,volt-curr-sample-average", &avg) == 0) {
+		if (avg > ADM1275_SAMPLES_AVG_MAX || avg < 1)
+			return -EINVAL;
+		dev_info(&client->dev,
+			"Setting voltage and current sample averaging number to %u",
+			BIT(ilog2(avg)));
+		ret = adm1275_write_pmon_config(data, client, false,
+						ilog2(avg));
+		if (ret < 0) {
+			dev_err(&client->dev,
+				"Setting voltage and current sample averaging failed with error %d",
+				ret);
+			return ret;
+		}
+	}
+
 	if (voindex < 0)
 		voindex = vindex;
 	if (vindex >= 0) {
-- 
2.17.1