Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2633773pxm; Mon, 28 Feb 2022 03:09:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrvCKsRkaVeegTyCs8SwFXyXe+JWJq/O2UiZHKXiMTRGDd3EuYvIipvJg0CNiH/njhe8Gy X-Received: by 2002:a17:906:c18c:b0:6d5:8518:e567 with SMTP id g12-20020a170906c18c00b006d58518e567mr14314820ejz.37.1646046586692; Mon, 28 Feb 2022 03:09:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646046586; cv=none; d=google.com; s=arc-20160816; b=IW11S/GLU8x1RZGj9gvuu01vaPDK+4+QAxepFXAqMCnau+VRAvE/xLXIR5yl8Oso0j QkZtMusKltpMe526dkg9gmeGONCxDajaWNwdblG1WFC7ecOu0dYNAIfhW0Tu7UeFzASN q4TteWqdxumPsIxJ3madKEsVJrAujph5VnTn4m77i4QqleDI7qTRgj3Ttr/E01yZBelL u6IzOB4kYvPiMECM2+iGulXpJsWSOP+iSx5HjI1BbiP3cKhACfSFduILr29MCyZ+J6oZ 3YBc6AFoYWUvxsLjxZl7drkDwDMK4GJSyy58OaHKFF9F0vFSCQAmZvL6ZZ9p89Gbkh8p mfBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=rIIE+6znq1tRJvl+TlHj2+b3hEUePJ9pjiSKZ3FM0KQ=; b=IUQqjvtTl4mcQFM+rIuKotj9jfAGkfcrvT4+y2RZ8uuanxJMePXR5XgHt4tLNLf30D k0hZg/ObdKxB1On19qjxN4xVq66jt5QOAZh7zaVL1d4lIowfDjSuhb+kxyR6z5r7vSj8 Q8D+KN+F7cl5IagvFOTExngjTtb1za7LdQ4RUy43aYO3q0T2EHEeYdhxQIMtd6ym0eSR GUi54ZwaXbNvdFQMPVQL4v4WQT0rGMqotSBsJyfiRGnLIYvrdE49d3KBEfFVSpsEaZfh DYoJzPFSYoHKUzVuaatThX6K2x1YEzI5PRtoItbofdrwlpImixfyMND28RRRmYRu1U0u oFdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i7-20020a50d747000000b00402c23984basi7045346edj.467.2022.02.28.03.09.24; Mon, 28 Feb 2022 03:09:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234197AbiB1JXC (ORCPT + 99 others); Mon, 28 Feb 2022 04:23:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbiB1JW7 (ORCPT ); Mon, 28 Feb 2022 04:22:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E54CF57B2E for ; Mon, 28 Feb 2022 01:22:20 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 3971168AA6; Mon, 28 Feb 2022 10:22:16 +0100 (CET) Date: Mon, 28 Feb 2022 10:22:15 +0100 From: Christoph Hellwig To: Enzo Matsumiya Cc: linux-nvme@lists.infradead.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-pci: trigger disk activity LED Message-ID: <20220228092215.GA8549@lst.de> References: <20220227234258.24619-1-ematsumiya@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227234258.24619-1-ematsumiya@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I don't think we should add code to the absolutel fast path for blinkenlights.