Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     Shahed Shaikh <shshaikh@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] net: qlcnic: use time_is_before_jiffies() instead of open coding it
Date:   Sun, 27 Feb 2022 19:13:00 -0800
Message-Id: <1646017980-61037-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gA7qVaZelIr+Ew2oiSeQx/xQ132uplBiTG6iFloLzSSW2KTvI2/i0RGdxt0t?=
 =?us-ascii?Q?riVNEB2S+WqLkR8PtWTsqFCSlw0DcNK+cGvuqJ+3foJj3ooaR7sCnM4Vkuuy?=
 =?us-ascii?Q?nrQFjjMscsy2uQrjE79vE0XXZxUnRm0VMsUiPz9OoTMBu7UCSPodirz8S6/V?=
 =?us-ascii?Q?9PwEILgFCz3nEWKaq5PlNHbvx8HCev9SDq/gbikHLXvFVHpOvYCBYogKTF/m?=
 =?us-ascii?Q?OLwt2DsYwt8QdoNp3Mpg2lJ9yvOPS+8+zABCUT97ZAShwbkmNfr1m6yDeojy?=
 =?us-ascii?Q?Tq3k2v4/ROX1gv1xb5NzMyGxiHZ6SsiqwX8qGQE/7CF1e92+dLPY5BII9u6F?=
 =?us-ascii?Q?rbqyKoAom+O7Omxf3j41aFL7fta+MC70dLZP/J+cJoxjMDdaiHthof8nNpSF?=
 =?us-ascii?Q?RQ8RRc783IqKOyR0bFsLz3IkloyREGUP5KTuLpj+Pi6/vwaI1gAlMi+ifuoA?=
 =?us-ascii?Q?RR/UwH5+fmKvedsOAIwKtU20TBFz7wQ0XpH0HI9D1pwseDOxLEwVkUCqscxc?=
 =?us-ascii?Q?rAvzBZ02YvzyB/pvMnwl7flxz3XvAQsAtI+KeYUs4iHOhB9wW2RjisYFozV3?=
 =?us-ascii?Q?wm+2fW7z6fvVpC27TPeOATOUSa6qnrVxuGc8oIfNWQ/iC6S3b5FhPBmYZleW?=
 =?us-ascii?Q?zpa17TgrM1WK3zugUI+E559xECljiC/MGOyKc9YxFDexzeAhoJOU/OEdL3bm?=
 =?us-ascii?Q?KWunR3F6GAXBqfjezS7UVjYF0cqGFG5fdKwW2yBRwBT+BbGCarKA+vmRA1nh?=
 =?us-ascii?Q?kwCz0g3GeCtqZM41isnTMLSOF4LawnXBU5Oz69eS4uoU9hOZs52Nxv9hUaJ7?=
 =?us-ascii?Q?dQcuFccOMtjtqO8hv4jPL68GYpjZZgHOg/AMcri72btjH6Sq+i6aR9k9vTXL?=
 =?us-ascii?Q?BtDRkRxzIT5nHGvgVpoiZNK1xt5z/B7ZQ+3UTYFRWCmiknsin2tex4Cj8RmU?=
 =?us-ascii?Q?cZcQ51btiGz278bUNeMk+zpeQRH1qwS8a5sf7HHO3WwruwsS0uiC32N/u6rG?=
 =?us-ascii?Q?J7JEWO1AxNnXnXy7KdP80/x+hW2kc8zrutssr0iVYA3CFVcHfQzIrXQhy9bQ?=
 =?us-ascii?Q?kwKHG8OAbdKqRVHQGGWEL4HCcfxK9/TNrnZuVHiVpOtyUTKA+B+eR8JhMBYh?=
 =?us-ascii?Q?g5FQeU3zVqhNfV3o4AgavYLFKhpt9qf4mWg/33+WqxsGjUhm0kabUt4f0SIw?=
 =?us-ascii?Q?7DNyWxAzmvmv+EiZbdVTyTzPkKffmPOgA0J2Ta2r2SCaaaJmdC2DeCCyae/+?=
 =?us-ascii?Q?/LDTZ37O1tPhFNHD4kEKLEvb1xaTLPLRqc103uVB58sILvvPJbS3X6LG0WKF?=
 =?us-ascii?Q?zL0pFSOdVPfh0lVLQB8erbn7gK9bDL5DQ4AAIrAn8EDOQW5fhzdj5K+ZvDX1?=
 =?us-ascii?Q?DEMvAzPEkn7FiLNIy9fO4sxFLoXeHOaH2WfSQKVSvXDarRK8ySFwbzq3gkzs?=
 =?us-ascii?Q?VOYkZlSy+jxpUNkD7HLIL09HzZZWhbFzCn8AIibupNTDOm0cnMLVAUy9LQBl?=
 =?us-ascii?Q?JVgu+EHYy4kUSJneML2RvKTGlhySp/3cAXU1SrdT0ql5cXE2MGVHFE8C7k43?=
 =?us-ascii?Q?+Ik6Sc4iT8jnngWSwXxPK3XToqmHqwGJAqW78RXvni1n9RHEjECILuSC0B26?=
 =?us-ascii?Q?C4Mi376mYB1J/X7HGhqFirk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2acc3ea9-9598-4e4b-e512-08d9fa683f4a
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 03:13:09.7238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fjLAprKpRSJ2gFH3m98BknMlcE/nyVv6FYgAkM8kVjryg3qJiZt26dGeKQb1ze6QsBVf/mYmW2vqnuK8bf3KLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB2454
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
index 29cdcb2..bcf3746
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
@@ -10,6 +10,7 @@
 #include <linux/ipv6.h>
 #include <net/checksum.h>
 #include <linux/printk.h>
+#include <linux/jiffies.h>
 
 #include "qlcnic.h"
 
@@ -332,7 +333,7 @@ static void qlcnic_send_filter(struct qlcnic_adapter *adapter,
 	hlist_for_each_entry_safe(tmp_fil, n, head, fnode) {
 		if (ether_addr_equal(tmp_fil->faddr, (u8 *)&src_addr) &&
 		    tmp_fil->vlan_id == vlan_id) {
-			if (jiffies > (QLCNIC_READD_AGE * HZ + tmp_fil->ftime))
+			if (time_is_before_jiffies(QLCNIC_READD_AGE * HZ + tmp_fil->ftime))
 				qlcnic_change_filter(adapter, &src_addr,
 						     vlan_id, tx_ring);
 			tmp_fil->ftime = jiffies;
-- 
2.7.4