Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1644395927-4138-1-git-send-email-wangqing@vivo.com>
 <CAPDyKFqg5N1tCqQ2u2jt5qU0qLuDJRSJRtq_aMVDc7XNDbRvkw@mail.gmail.com> <bcd6688f-6f42-ca8f-ab9c-978eeff4f4e3@wanadoo.fr>
In-Reply-To: <bcd6688f-6f42-ca8f-ab9c-978eeff4f4e3@wanadoo.fr>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 28 Feb 2022 13:03:47 +0100
Message-ID: <CAPDyKFo-4hkTo8F9q4+BmxUH_Y4nk_K0N20q53xrdJLAFRutcQ@mail.gmail.com>
Subject: Re: [PATCH] mmc: mtk-sd: use div64_u64() instead of do_div()
To:     Qing Wang <wangqing@vivo.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Chaotian Jing <chaotian.jing@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 17 Feb 2022 at 21:00, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 17/02/2022 =C3=A0 16:39, Ulf Hansson a =C3=A9crit :
> > On Wed, 9 Feb 2022 at 09:39, Qing Wang <wangqing@vivo.com> wrote:
> >>
> >> From: Wang Qing <wangqing@vivo.com>
> >>
> >> do_div() does a 64-by-32 division.
> >> When the divisor is u64, do_div() truncates it to 32 bits, this means =
it
> >> can test non-zero and be truncated to zero for division.
> >>
> >> fix do_div.cocci warning:
> >> do_div() does a 64-by-32 division, please consider using div64_u64 ins=
tead.
> >>
> >> Signed-off-by: Wang Qing <wangqing@vivo.com>
> >
> > Applied for next, thanks!
>
>
> This is wrong.
>
> See [1].

Thanks for reporting this, I am dropping the patch from my next branch!

See more comments below.

>
>
> Wang Qing, you should really warn all the people you have sent such patch=
es.
>
> CJ
>
> [1]:
> https://lore.kernel.org/linux-kernel/19b96972-cee7-937f-21ce-c78982ed2048=
@linaro.org/
>
>
> >
> > Kind regards
> > Uffe
> >
> >
> >> ---
> >>   drivers/mmc/host/mtk-sd.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> >> index 65037e1..777c9a8
> >> --- a/drivers/mmc/host/mtk-sd.c
> >> +++ b/drivers/mmc/host/mtk-sd.c
> >> @@ -766,7 +766,7 @@ static u64 msdc_timeout_cal(struct msdc_host *host=
, u64 ns, u64 clks)
> >>                  clk_ns  =3D 1000000000ULL;
> >>                  do_div(clk_ns, mmc->actual_clock);
> >>                  timeout =3D ns + clk_ns - 1;
> >> -               do_div(timeout, clk_ns);
> >> +               div64_u64(timeout, clk_ns);

I guess a proper patch would be to convert clk_ns into an u32 instead!?

> >>                  timeout +=3D clks;
> >>                  /* in 1048576 sclk cycle unit */
> >>                  timeout =3D DIV_ROUND_UP(timeout, BIT(20));
> >> --

Kind regards
Uffe