Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "Xu, Yilun" <yilun.xu@intel.com>,
        Yusuf Khan <yusisamerican@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "trix@redhat.com" <trix@redhat.com>
Subject: RE: [PATCH -next] pga: dfl: pci: Make sure DMA related error check is
  not done twice
Thread-Topic: [PATCH -next] pga: dfl: pci: Make sure DMA related error check
 is  not done twice
Thread-Index: AQHYKmDvTPIYclDPJ0ydMlszHI+cxayovZbg
Date:   Mon, 28 Feb 2022 09:58:21 +0000
Message-ID: <DM6PR11MB3819C9631EAED0AFE7E8D99B85019@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220222042700.385001-1-yusisamerican@gmail.com>
 <CAJoG2+-97KyWrxym2NXECRtjT9OxVQE_=DcNkUfOsPm_Ax90Aw@mail.gmail.com>
 <20220225155208.GA1377611@yilunxu-OptiPlex-7050>
In-Reply-To: <20220225155208.GA1377611@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2uxFCF7Ga0yxWElTwlCCkfGiW4Nkppj3O4vBNdOmxbajAw4E74ZkcDhEf3rQ?=
 =?us-ascii?Q?HrGVWFwYT2sKG/Q936FeFFdVhLkYtcw2m0xSCDyXseZeRYos8p3Tbr5pTxyc?=
 =?us-ascii?Q?IU4ph/NuJ50Ia1mUSi38UcF36uYLraMWMtr1kGtm+Yx4mSKdoGVjiMBAMxFR?=
 =?us-ascii?Q?N20cCrxlySWxsdhwgEukC4983F8IOmIzo71IRHVrrIibV/LsJrKZo1E9v2Er?=
 =?us-ascii?Q?J9AL16HNLyr6fCTA0IC69bBDy4UtKSUYKhVGYGNBGaTm7FUJbCHxQxqi5hG4?=
 =?us-ascii?Q?Ai8/lVCtWmsIg7A/Qg5E92/UO6+lEx58k9lOYh70+XEOtqoUg2cQ/sut0Gta?=
 =?us-ascii?Q?2TO9GtElSIrtXn73ayzaG9XNW8Q8NrRlfruEg3vSDBQ0nJn5Pd81vAtC2x+C?=
 =?us-ascii?Q?JfnrEHgfrmYZwG8Qoo5OgYeW3cpaLrE2fToKG/qu1r71E29wRVcmkzsNn/xW?=
 =?us-ascii?Q?OE0KAtjmP5IZ67aUHdqvtCPx/kDuDH8kFJ6cS4Jn1HZ+31B1xSIIadGTxP9G?=
 =?us-ascii?Q?Xsx8e38aybj7Oi9GkNd3H11dQjs8UAyjQPwtgf/Zq/00HFjVIUL5voIaoHws?=
 =?us-ascii?Q?zsET3QpuM6TLznGlsIUD2Cz/qHEuiLRzPaXadYTV3FfEh3ggVFJkpJx9M7m0?=
 =?us-ascii?Q?ALim9YlC9vGbO7hjatWnNza7dfuo/gA5wpos/7Ty4+3Uboh8ELjDeIhOA647?=
 =?us-ascii?Q?dGb8NVwqqoOJRszgeMU1mqItCf6V6YaS326YJ2ARUsttMFlaVlVghc5mX1gh?=
 =?us-ascii?Q?FyyzBYGyKWXdLyVwWbcSScp04lin/ErC5bSeDb7sGeN23y6FOoJ/PLJbZabr?=
 =?us-ascii?Q?QY8PW8RT5SuJSm4Qy7VUtpz4T4wWb8MdnRX9+BiL+moLhK1VSdsxx+kCdfEP?=
 =?us-ascii?Q?5pktfmsj7tl6Hi7VuY1LObKboTCTgzHJN7OeLNvSNahosGBZDiyVETPPiipN?=
 =?us-ascii?Q?1vT3umb40Zf8oDsvfYTvVIwWF3rY+RHaNT+0HXRvchBhKNPSHzU2y4TdZo0v?=
 =?us-ascii?Q?OTV0zj3WIl2zKuaLmy8EHQTRxiDUzcLBVXFTZ92cg0QlfhIb8s05jVenC4Kb?=
 =?us-ascii?Q?KFQtqQ1viozIkhlKBbZlIfMnmrxJdoUDMGNxkPFu5An22k5lzZE9EL9FEeXz?=
 =?us-ascii?Q?H2aC5jul0LNQizKLdLrGNpuxaB0ogEIsMjw7zFz1I6PY7QBiihyX9iGTqTsT?=
 =?us-ascii?Q?vs6A5zIIzTPiqXONfLOpI0lCjva+AbyvI0HzchbGY0RJiAPW5hlwJt5Q7NaC?=
 =?us-ascii?Q?J7UMELGYd9SZeSOpDxy+wzf0QcHndt8kc6uIHJ4VdYlO+T1yndvZHTLboBhy?=
 =?us-ascii?Q?5vDtQhI/ocyHMmMvVo3ZR+DCySy+ec27MGZX6POTewpEVdLRj09+BXRGckOS?=
 =?us-ascii?Q?Bat5Rt8qFpLBVagP+HIzDL+bRRGZ+W6OmLbTkcpwURM4CiiQBWoYDNixqD0L?=
 =?us-ascii?Q?jvutMABfRnMT4CT5W8pcsLtaCA9i+Mur3XE6y76VkStN0oy5urCiK/OSbwYE?=
 =?us-ascii?Q?2jBv8vUjgeNGMLwl1WKDLDrgJuGUS2oku3RUiUHUQhaKAnUHdu7wyIAsX2UK?=
 =?us-ascii?Q?ftCCef62QXWOGYBQveLpr5HnLWrH6ykOjHCjTy/5K/JwWQsWyXSW2mEjH9Du?=
 =?us-ascii?Q?pA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bdf32ac2-3f0f-4db8-a475-08d9faa0da4c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 09:58:21.2865
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jMfNJ/nyCtwBoT6ZmqjVn3/9N8CQY48vnD8ARtH2cylZ8NJOPEk9zM734FJ1RxsCOj/p2eERh6x3wm7mg1bdKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1275
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, Feb 21, 2022 at 08:39:48PM -0800, Yusuf Khan wrote:
> > Note: This bug was introduced here:
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-
> next.git/patch/?id=3Dada3caabaf6135150077c3f729bb06e8f3b5b8f6
> > I saw this commit inside the linux-next branch, it is not present in
> > the mainline branch.
> > The linux-next branch was last updated 5 days ago, so I am unsure
> > about the state of that commit.
> >
> > On Mon, Feb 21, 2022 at 8:27 PM Yusuf Khan <yusisamerican@gmail.com>
> wrote:
> > >
> > > In the case that the DMA 64 bit bit mask error check does not fail,
> > > the error check will be done twice, this patch fixed that.
> > >
> > > NOTE: This patch is only for use in the linux-next branch as the
> > > commit that caused this bug happened there.

Thanks for the patch.
please remove this from the commit message, and fix the title
s/pga/fpga/

Thanks
Hao

> > >
> > > Signed-off-by: Yusuf Khan <yusisamerican@gmail.com>
> > > ---
> > >  drivers/fpga/dfl-pci.c | 9 +++++----
> > >  1 file changed, 5 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > index 717ac9715970..6222f18aed4b 100644
> > > --- a/drivers/fpga/dfl-pci.c
> > > +++ b/drivers/fpga/dfl-pci.c
> > > @@ -356,11 +356,12 @@ int cci_pci_probe(struct pci_dev *pcidev, const
> struct pci_device_id *pcidevid)
> > >         pci_set_master(pcidev);
> > >
> > >         ret =3D dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(=
64));
> > > -       if (ret)
> > > -               ret =3D dma_set_mask_and_coherent(&pcidev->dev,
> DMA_BIT_MASK(32));
> > >         if (ret) {
> > > -               dev_err(&pcidev->dev, "No suitable DMA support availa=
ble.\n");
> > > -               goto disable_error_report_exit;
> > > +               ret =3D dma_set_mask_and_coherent(&pcidev->dev,
> DMA_BIT_MASK(32));
> > > +               if (ret) {
> > > +                       dev_err(&pcidev->dev, "No suitable DMA suppor=
t
> available.\n");
> > > +                       goto disable_error_report_exit;
> > > +               }
>=20
> Looks good to me.
>=20
> Acked-by: Xu Yilun <yilun.xu@intel.com>
>=20
> > >         }
> > >
> > >         ret =3D cci_init_drvdata(pcidev);
> > > --
> > > 2.25.1
> > >