Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2751689pxm; Mon, 28 Feb 2022 05:31:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwsdygiV/GJMXqVN8aAPgN2EcnLDzhhx1qZybf/B5kxa+RzDTB2x8mMf4pwmEJaHwKVATEH X-Received: by 2002:a05:6402:b37:b0:400:500f:f26 with SMTP id bo23-20020a0564020b3700b00400500f0f26mr18992733edb.301.1646055092438; Mon, 28 Feb 2022 05:31:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646055092; cv=none; d=google.com; s=arc-20160816; b=FJ7msu7Pn4AVRRnvyPw99iObwCOL0O0O/4wWJN7dtGOTl+F+26GOxaj8LS1q+WtjwC 2qQJFfnDzk+qsIx8SKCHM+ixbxlsc50Ahj6cXtehqIqEf18nK8HLOU9C2Hbhfc4m8o2D 6uPVcOCXoUNgTpuu2969+ySm5DWGkwl7WxXPPwTQxZeZWppYOtmo1iOMo78nRaTno0Ev 9qKhC1Y8YkNs92ERCYYurTppF8/SzZBg1CGm+0h/dBkGVlrcP/sSkaxDf6l1lZCqxRZ2 W3eLGnmVmd9m4uOdj+cOUplz2H2ezOTd1bubAstqgvzUqHWbB5DI9thGk9W8R8/BP4O8 p8tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=71GrgkuA8DRTzKZEPIWJI5QBOUaJJOgGR4Yi1irRp+I=; b=dsbZ52plhSRrUXfRs9lPiSSRoZ5rX9D4ANNHG12kXUqHU0ui6Voh7AhRjAY6J73doi CYACpOzKpG8zGPxwo+mYFTJozOB7Sdbbz/6le2YYwAdrj7yMG7pAf6dAyrtDrCz2pyc3 nQ1msAIAanWvcxYRJzizImI2Z9+STbMT/7sExBMlMZD0w+5sOF5b4DDPqdLMsKTuixpv h5c7XdK/RTqMfxq5vzD15SbGRv05Wpo9LpRxPosl4PfyjtypKDJWiCke6BwgIVAJaWt6 L0+jMraGGHLidzrpxetRvWbVWl+voirTJK6LR+9n9SqIMq9Ue+l3yDq/eOnk+Qv8bA1o d8Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i1ozI60q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q23-20020aa7d457000000b0041124e6584dsi6879921edr.105.2022.02.28.05.31.09; Mon, 28 Feb 2022 05:31:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i1ozI60q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbiB1MZl (ORCPT + 99 others); Mon, 28 Feb 2022 07:25:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236510AbiB1MZQ (ORCPT ); Mon, 28 Feb 2022 07:25:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B8C76E1E; Mon, 28 Feb 2022 04:24:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1133061122; Mon, 28 Feb 2022 12:24:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 661B0C340F5; Mon, 28 Feb 2022 12:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646051059; bh=oZOcgtYrh8yNZbOLHL9TFee3Kx3uN+kaijUMv7n/GjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i1ozI60qUTEXbDm9LxZvDcalgB+3gC1zwMOCspsbav5qRX79FLyCmF9dorUbugH1S H8kD16eDTvFLzufdtzdgJQKaOH+iZPSZg83IyzL/PIFYf6gOYN6JjeMskxaQ/ie5LW Gns9aq7Rlyb9TUAmQjRgdUj7LpM3IJApBa9anvphQEU95ATdA9DX5uiUlWf4GJidik u0FLKj77hUGQm59BroDX9/hFklHGvrGtWXAUfsJJi4SRnfS1qLY+v/WShuE9Agm34V TKXpUWdMF+PrCWmGyFHcPekbDBtFeP4VcRB4DiRof5rWvcf3mr8SvUFexxnczdLmwa 4WXzTjgcRS85Q== Date: Mon, 28 Feb 2022 13:24:58 +0100 From: Jarkko Sakkinen To: "Dhanraj, Vijay" Cc: "Chatre, Reinette" , "dave.hansen@linux.intel.com" , "tglx@linutronix.de" , "bp@alien8.de" , "Lutomirski, Andy" , "mingo@redhat.com" , "linux-sgx@vger.kernel.org" , "x86@kernel.org" , "Christopherson,, Sean" , "Huang, Kai" , "Zhang, Cathy" , "Xing, Cedric" , "Huang, Haitao" , "Shanahan, Mark" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 16/32] x86/sgx: Support restricting of enclave page permissions Message-ID: References: <4ce06608b5351f65f4e6bc6fc87c88a71215a2e7.1644274683.git.reinette.chatre@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 23, 2022 at 07:21:50PM +0000, Dhanraj, Vijay wrote: > Hi All, > > Regarding the recent update of splitting the page permissions change > request into two IOCTLS (RELAX and RESTRICT), can we combine them into > one? That is, revert to how it was done in the v1 version? They are logically separate complex functionalities: 1. "restrict" calls EMODPR and requires EACCEPT 2. "relax" increases permissions up to vetted ("EADD") and could be combined with EMODPE called inside enclave. I don't think it is a good idea. BR, Jarkko