Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH bpf-next] bpf: add config to allow loading modules with
 BTF mismatches
To:     Shung-Hsi Yu <shung-hsi.yu@suse.com>,
        Connor O'Brien <connoro@google.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, netdev@vger.kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?Q?Michal_Such=c3=a1nek?= <msuchanek@suse.de>
References: <20220223012814.1898677-1-connoro@google.com>
 <YhW5UIQ5kf8Fr3kI@syu-laptop.lan>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <6a979467-7bfb-68eb-57d6-f5294846bac4@iogearbox.net>
Date:   Mon, 28 Feb 2022 14:25:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <YhW5UIQ5kf8Fr3kI@syu-laptop.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/23/22 5:34 AM, Shung-Hsi Yu wrote:
> On Wed, Feb 23, 2022 at 01:28:14AM +0000, Connor O'Brien wrote:
>> BTF mismatch can occur for a separately-built module even when the ABI
>> is otherwise compatible and nothing else would prevent successfully
>> loading. Add a new config to control how mismatches are handled. By
>> default, preserve the current behavior of refusing to load the
>> module. If MODULE_ALLOW_BTF_MISMATCH is enabled, load the module but
>> ignore its BTF information.
>>
>> Suggested-by: Yonghong Song <yhs@fb.com>
>> Suggested-by: Michal Suchánek <msuchanek@suse.de>
>> Signed-off-by: Connor O'Brien <connoro@google.com>
> 
> Maybe reference the discussion thread as well?
> 
> Link: https://lore.kernel.org/bpf/CAADnVQJ+OVPnBz8z3vNu8gKXX42jCUqfuvhWAyCQDu8N_yqqwQ@mail.gmail.com/

LGTM, and added above into the commit log while applying. Thanks everyone!