Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <837c988c-1347-8aa6-cffd-2130f8894cb0@amlogic.com>
Date:   Mon, 28 Feb 2022 21:35:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH V2] tty: serial: meson: Fix the compile link error
 reported by kernel test robot
Content-Language: en-US
To:     Neil Armstrong <narmstrong@baylibre.com>,
        <linux-serial@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <20220228090351.9976-1-yu.tu@amlogic.com>
 <790952bd-b066-0b41-545c-1f65cd4244af@baylibre.com>
From:   Yu Tu <yu.tu@amlogic.com>
In-Reply-To: <790952bd-b066-0b41-545c-1f65cd4244af@baylibre.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Neil,
	Thank you very much for your reply.

On 2022/2/28 17:52, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> i,
> 
> On 28/02/2022 10:03, Yu Tu wrote:
>> Describes the calculation of the UART baud rate clock using a clock
>> frame. Forgot to add in Kconfig kernel test Robot compilation error
>> due to COMMON_CLK dependency.
>>
>> Fixes: 44023b8e1f14 ("tty: serial:meson: Describes the calculation of 
>> the UART baud rate clock using a clock frame“)
> 
> AFAIK this commit is not in an uptream/feature branch, so you should 
> simply fix your `Use CCF to describe the UART baud rate clock` instead.
> 
I'll correct it right away as you suggested.

> Neil
> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>> ---
>>   drivers/tty/serial/Kconfig      |  1 +
>>   drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++----------
>>   2 files changed, 27 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>> index e952ec5c7a7c..a0f2b82fc18b 100644
>> --- a/drivers/tty/serial/Kconfig
>> +++ b/drivers/tty/serial/Kconfig
>> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI
>>   config SERIAL_MESON
>>       tristate "Meson serial port support"
>>       depends on ARCH_MESON || COMPILE_TEST
>> +    depends on COMMON_CLK
>>       select SERIAL_CORE
>>       help
>>         This enables the driver for the on-chip UARTs of the Amlogic
>> diff --git a/drivers/tty/serial/meson_uart.c 
>> b/drivers/tty/serial/meson_uart.c
>> index bf6be5468aaf..972f210f3492 100644
>> --- a/drivers/tty/serial/meson_uart.c
>> +++ b/drivers/tty/serial/meson_uart.c
>> @@ -780,28 +780,37 @@ static int meson_uart_probe(struct 
>> platform_device *pdev)
>>           return ret;
>>       irq = platform_get_irq(pdev, 0);
>> -    if (irq < 0)
>> -        return irq;
>> +    if (irq < 0) {
>> +        ret = irq;
>> +        goto err_out_clk_disable;
>> +    }
>>       of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
>>       if (meson_ports[pdev->id]) {
>>           dev_err(&pdev->dev, "port %d already allocated\n", pdev->id);
>> -        return -EBUSY;
>> +        ret = -EBUSY;
>> +        goto err_out_clk_disable;
>>       }
>>       port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), 
>> GFP_KERNEL);
>> -    if (!port)
>> -        return -ENOMEM;
>> +    if (!port) {
>> +        ret = -ENOMEM;
>> +        goto err_out_clk_disable;
>> +    }
>>       port->membase = devm_ioremap_resource(&pdev->dev, res_mem);
>> -    if (IS_ERR(port->membase))
>> -        return PTR_ERR(port->membase);
>> +    if (IS_ERR(port->membase)) {
>> +        ret = PTR_ERR(port->membase);
>> +        goto err_out_clk_disable;
>> +    }
>>       private_data = devm_kzalloc(&pdev->dev, sizeof(*private_data),
>>                       GFP_KERNEL);
>> -    if (!private_data)
>> -        return -ENOMEM;
>> +    if (!private_data) {
>> +        ret = -ENOMEM;
>> +        goto err_out_clk_disable;
>> +    }
>>       if (device_get_match_data(&pdev->dev))
>>           private_data->use_xtal_clk = true;
>> @@ -822,7 +831,7 @@ static int meson_uart_probe(struct platform_device 
>> *pdev)
>>       ret = meson_uart_probe_clocks(port);
>>       if (ret)
>> -        return ret;
>> +        goto err_out_clk_disable;
>>       meson_ports[pdev->id] = port;
>>       platform_set_drvdata(pdev, port);
>> @@ -831,9 +840,15 @@ static int meson_uart_probe(struct 
>> platform_device *pdev)
>>       meson_uart_reset(port);
>>       ret = uart_add_one_port(&meson_uart_driver, port);
>> -    if (ret)
>> +    if (ret) {
>>           meson_ports[pdev->id] = NULL;
>> +        goto err_out_clk_disable;
>> +    }
>> +
>> +    return 0;
>> +err_out_clk_disable:
>> +    clk_disable_unprepare(pclk);
>>       return ret;
>>   }
>>
>> base-commit: c2faf737abfb10f88f2d2612d573e9edc3c42c37
>