Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2974464pxm; Mon, 28 Feb 2022 09:31:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIeZtOplT8B5U+HM4nilLGV45t/h0815Bx1Js15BpaI0Ozf9da4xoAmw7Da8HirLyBJduT X-Received: by 2002:a17:906:6410:b0:6d1:c4c9:8fec with SMTP id d16-20020a170906641000b006d1c4c98fecmr16330128ejm.378.1646069512889; Mon, 28 Feb 2022 09:31:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646069512; cv=none; d=google.com; s=arc-20160816; b=ppR2IIQDFuY1FZXZaYZmg/HHjNjrvCCJOjqO0+RNIzFamcM3HNI7gOus2MR0ecsbfj YZFYSILwBFtndPXeQCtavTSGtj9otWyzVFougg5/s5K/JTD4b7l7o2Lp+ujMYX2OMRMK CbwsVOc8y3cjauFK/CE1gTxaLfWKe88s/HNDxNnR/NCfgDy/HD9fsjXGDVCPYZVQBNG/ RvzBwPB+PCoJ9R18ZAqQGZDfJtJyc2PzOyfYS/XFPcjb7DKwsEaoxjXshv4hOefc/tqa /67BFmNSyX/B+X4vDAZ+1fTI/x2ZO/wbOMTCKumbAdgnDPPC3wxcRyE0oNDtjVm71ZY7 LEow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=dOBOk0C7BeVhZ7Rzxop8SBGy9YT3f0rTiunKXzycjHQ=; b=0NSOGeZTwEhYW4zzap65R2563Mz4p+81Y2nusDEqM0F874SqxBdQzl58O9Xd+habAt /BVmQ8WeQxOiuu3xMp9dk00YFulwk7hZbxrnE+7giXc/kx/vcI9UeQPeMSCFT1ZuI72x rEwI6Gko7HADGxvWdGH6YOJYhcNI+M3nMh7k/fT/6KSJIVKCIjc4OgM7O8J83dgtzOVZ 9A82xrtbM1g0vCS1z9an4iitoBrZBp5C0gMwxj1ACaXpAoArT61t1b+XrrQyrlDY8Xck tm3BZamK3kogdsOWBOyZ9wnY27ZlYOXHo+TjSIlX6vrIpLcDJOsHNDvKXmgRWsiqRuZ/ mBSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ss17-20020a170907c01100b006d6e0f062ecsi295327ejc.138.2022.02.28.09.31.29; Mon, 28 Feb 2022 09:31:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiB1Pyd (ORCPT + 99 others); Mon, 28 Feb 2022 10:54:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237667AbiB1Pyb (ORCPT ); Mon, 28 Feb 2022 10:54:31 -0500 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB97E11A1E; Mon, 28 Feb 2022 07:53:52 -0800 (PST) Received: from sslproxy02.your-server.de ([78.47.166.47]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1nOiLJ-000F04-J5; Mon, 28 Feb 2022 16:53:45 +0100 Received: from [85.1.206.226] (helo=linux.home) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOiLJ-0000ts-3v; Mon, 28 Feb 2022 16:53:45 +0100 Subject: Re: [PATCH v2 sysctl-next] bpf: move the bpf syscall sysctl table to bpf module To: Yan Zhu , mcgrof@kernel.org Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org, kpsingh@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, liucheng32@huawei.com, netdev@vger.kernel.org, nixiaoming@huawei.com, songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com, yzaikin@google.com, zengweilin@huawei.com References: <20220223102808.80846-1-zhuyan34@huawei.com> From: Daniel Borkmann Message-ID: Date: Mon, 28 Feb 2022 16:53:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20220223102808.80846-1-zhuyan34@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.5/26467/Mon Feb 28 10:24:05 2022) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yan, On 2/23/22 11:28 AM, Yan Zhu wrote: > Aggregating the code of the feature in the code file of the feature > itself can improve readability and reduce merge conflicts. So move > the bpf syscall sysctl table to kernel/bpf/syscall.c > > Signed-off-by: Yan Zhu > > --- > v1->v2: > 1.Added patch branch identifier sysctl-next. > 2.Re-describe the reason for the patch submission. I'm not applying it given there is very little value in this change, see also what has been said earlier: https://lore.kernel.org/bpf/CAADnVQKmBoQEG1+nmrCg2ePVncn9rZJX9R4eucP9ULiY=xVGjQ@mail.gmail.com/ Thanks, Daniel