Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 1/1] net: dsa: felix: remove
 prevalidate_phy_mode interface
Thread-Topic: [PATCH v1 net-next 1/1] net: dsa: felix: remove
 prevalidate_phy_mode interface
Thread-Index: AQHYK2FktZ+AkJz6WkWsPM8tzjJshKyo2ugA
Date:   Mon, 28 Feb 2022 11:46:35 +0000
Message-ID: <20220228114634.izmpym7x6kvjjvq6@skbuf>
References: <20220226223650.4129751-1-colin.foster@in-advantage.com>
In-Reply-To: <20220226223650.4129751-1-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1wSM+40P8l2SoLvyWgliZpRtAD7bxJUUUeqHeQJVOAj/DqVWLsZH8p06yDJX?=
 =?us-ascii?Q?1wDY4YLaNRiij9LTM3ABNr+uVQVfhm2mmD5ziiRjnnHutdLmC5ZGpQLnBrrR?=
 =?us-ascii?Q?j61jg81Y7HTq/VU3NwdfcAPmU8nXPeTtR4elZHYAuP2Y9YE9Ly5JoZXxCPxy?=
 =?us-ascii?Q?HrxXqLuqKLRA1Xa3F8UrRERy1GRyQDMSDnMjjKQGeoo8yXpqJh58YV+gX9xE?=
 =?us-ascii?Q?fu5/ytf/JIGUUiYtYmYBdLlZrO003m5aSXHVoLj6kwVjNIaNto46ckelP1kG?=
 =?us-ascii?Q?6RYbn5gZoOWQNiCeb5oipTbhljHNN5kZthJQHyvVTxhFEmUXPIeqisqEQvCv?=
 =?us-ascii?Q?776ZJHjzMgtyRsoA9ARtztUIBvafEECrkY5lbbQGC14AvAIMq+fY7qQCBGdg?=
 =?us-ascii?Q?4t89hrQ0vjG1FBZrzz0aIn6lA0zDHUF7PjNa8StYJxn4+/Dn6iAoG7DERu2A?=
 =?us-ascii?Q?l5U/3ZkBohGLiN5GOJb6BQQiRcz2sRkyr8bgMzpbOU4oO9KffZbegwGjaKCv?=
 =?us-ascii?Q?2BDbhFf2Gez9tL371aLPQgd81sKEDvT6VSm8byIBcq08AgrOndWt1mJ6ZtUt?=
 =?us-ascii?Q?sDRfb/vtLA4KZ40bIL8N3JbiRSc/4lHonqBL9z7zUP3osohka4n42UHLOtDi?=
 =?us-ascii?Q?M9uivy5pvR6stmtyBRecCgY0GolKyY565y3rGkMvQsi+EtAmlCTUMboRTfR8?=
 =?us-ascii?Q?RewKYfkab/DU4gEdk7LPVTxctghnDlvyo7SyPsDKLgT4ju7LTEQP114bozwq?=
 =?us-ascii?Q?B+nMudZIBjII+hQIFnU1a7ZG5f+4f8xHJF5Y7JMREIM6k9VoSamgVA6QjMws?=
 =?us-ascii?Q?utQMIn5NU1E/L2o0x7fbrSl4TNFrwpJqI63FD/bwwDC46Pxtezo0EuJURm6V?=
 =?us-ascii?Q?XzYQZkrBOCELyq8DIo0wZ9QPk/NUJMuBVVVsX/V/LrtNFx5nWRmLST81b8TE?=
 =?us-ascii?Q?p2jMLGnIX+BTSA746nFqfvIOCHMEdrPnsGJhLAL0l7EvSi2ojRDxDDnq2tmA?=
 =?us-ascii?Q?ZFg9i5IzHkXrvU1czNv+0zNv4x0xk0x77zM1rfoOX/RVsVJk4wEBI/H8JnmE?=
 =?us-ascii?Q?iooY652A676Se/f9iYPeWebeg72zKr9NRS2vm39OFvPEkpBq35VTIzMbSy/K?=
 =?us-ascii?Q?+Nhe5PsApH2o1T6TpGcE+L9iXFaR4/tL7iRRosGrcL8WrAImrlnNTQvhae+L?=
 =?us-ascii?Q?w21d5bGnN3XbMZWgvH2NKEWJelyrAunb8WgnGmGSC9VFowczkRfZSKO0dNs5?=
 =?us-ascii?Q?hYUDszxshUbjB6l3qSx9pWDHJ1bU5sPjWaa1qLtublIkkvwSK1wGT0qkmX6A?=
 =?us-ascii?Q?/OAGwiVhQ59Yfri+XRcUDsih6nJ5hRv5eUQoztyEVKrei+0tMdqGctte/4qk?=
 =?us-ascii?Q?LdQO0MXAH5Eu5rDg0pV+1l6LdPtspcN9SPSdO1Q4dtGWZ8YhSa1echnsWbd8?=
 =?us-ascii?Q?Kt+4tuN6i97Mj4Fs2xAFazm/UDbybp2NVHMmphBbyv0cqNua+H0xgCztNhS5?=
 =?us-ascii?Q?Ou5Zn0ZGGxAbPmjp+SYCuA2JXhzpF3+JtzzaMD7IEDqyWOGmSgLaRQn9KrIq?=
 =?us-ascii?Q?2sYcTgY2we8NqXqmZPFc9/bQVVwFRlP7Ij79gho2tAjSC1likAkzQVWDUI79?=
 =?us-ascii?Q?TsP0dz7Vo+aYSdeihst6WIM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9837ECC2D51CF642829AFEF329E0D8FE@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b663e04-223b-43ce-05e7-08d9faaff8fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 11:46:35.2472
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WAYp13NP2QeH29mU7PG5ECP1qSdUL2etIeYuinLMhDZObxLePNVkBZzAl/8sgKldHrLferVY8I8LLnPORi/YAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3275
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 26, 2022 at 02:36:50PM -0800, Colin Foster wrote:
> All users of the felix driver were creating their own prevalidate_phy_mod=
e
> function. The same logic can be performed in a more general way by using =
a
> simple array of bit fields.
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>=