Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2976838pxm; Mon, 28 Feb 2022 09:35:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQm5xDA/uWNDB4154ncBFletVQT5sabKSJNm7i+3Mt884JqSHtCDa5SwHMjALwng7DfJeG X-Received: by 2002:a17:906:1e4c:b0:6cf:7429:cfea with SMTP id i12-20020a1709061e4c00b006cf7429cfeamr16301814ejj.158.1646069700282; Mon, 28 Feb 2022 09:35:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646069700; cv=none; d=google.com; s=arc-20160816; b=fVfjq2uNwgO0YDVnH33x2jQuxDSMKDqjAZqw8WMQnce+is7VyORxorHYGqPZT+T7oa Qrx2cQX/yh2t3QjxlDGaZuZdGJ2ar4PTzZ6rnakGOjB1S61kxUY92k14U1VwlfYuNFPC AW6d6kK3hjVdsdQ8WAjc07IpOwXPMSWpUNa2ruFOAeae9DuORLrC80+j4SDZEJvvJvYG EL5A8oPPeUg1MsFCFyyz0CMXMbq9SvR5QMQoqsitdwC1iYg4iU9P5laJKhbKqWEQAdeb CzZ4SMLkfb7StvhlBECICUcg1NyVSPh3fr8/JHSP9xPjLIhJX64ua1iw0/1hcUkswmEs 56Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=aydvqx+uYs6ran9+qyI8tpaGZLxVf6e/I46wn7WR97Q=; b=QZvpci4312wHYMk86nr7Y2PhbWRo4MzOXD6ombm8pU/dosCqNSxSSyWMgiwYLoS78G mPv00yZaSXbC6bTwNUm99SivZkCTmkQsKJ5mrm/5P6F+4KsJY0ed3D1OONqFR1BQSOn6 YwJEhcnJ9nk171R00QBhQAavcB/3LeBzEpGKnET1aOaBvRcenZ/77ShRpn5oQG425aQJ 1/3Ng3DTF3mvd6vLPu0dBYpouGrMLmKDHzraJplbcbpwq5p0nZjWn1oj+GXfw2ER5ziF ccEQs8Ay0vXfn8j4vuWFgNKYD3Kx16y/Wv74awvOb2JxIN3k3G0eX4xJHDl5VDwoiii1 Aqtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l18-20020a1709067d5200b006cfe5e37c68si6245082ejp.302.2022.02.28.09.34.38; Mon, 28 Feb 2022 09:35:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237702AbiB1QkF (ORCPT + 99 others); Mon, 28 Feb 2022 11:40:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbiB1QkE (ORCPT ); Mon, 28 Feb 2022 11:40:04 -0500 Received: from relay4.hostedemail.com (relay4.hostedemail.com [64.99.140.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB015E77A for ; Mon, 28 Feb 2022 08:39:25 -0800 (PST) Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DC0A623715; Mon, 28 Feb 2022 16:39:23 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id 5F7028000F; Mon, 28 Feb 2022 16:38:49 +0000 (UTC) Message-ID: <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement From: Joe Perches To: Takashi Iwai Cc: Meng Tang , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Mon, 28 Feb 2022 08:39:21 -0800 In-Reply-To: References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Stat-Signature: dtaitigs3myn5hecefhi3rzmhzwsmi5t X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 5F7028000F X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/cTFZr/pNsYnF7B693HsSfdXRXrxvc6LM= X-HE-Tag: 1646066329-978216 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-02-28 at 17:02 +0100, Takashi Iwai wrote: > On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > > Return the result from file->f_op->open() directly instead of > > > taking this in another redundant variable. Make the typical > > > return the last statement, return early and reduce the indentation > > > too. > > > > > > Signed-off-by: Meng Tang > > > Signed-off-by: Joe Perches > > > > Hi Meng Tang. > > > > For the next time: it's not necessary (or even good) to add a sign-off > > for another person unless they specifically authorize one. > > > > You wrote and are submitting these changes, I merely gave you simple > > suggestions as to how you could improve them. > > Joe, would you like to drop your S-o-b lines from those two patches? > Or shall I keep them? > > thanks, > > Takashi Hi Takashi. Nominally, the sign-off-by chain shows who pushed these changes upstream and I did not and I am not an upstream aggregator. But whatever you choose is OK. It's not really a concern to me. I do think these changes are ok. cheers, Joe