Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2978361pxm; Mon, 28 Feb 2022 09:36:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTaP/1UeN0snUm6CddlGR7J9Baqq+5yXJDMCCFqqoczuL/0c5qSXnbSxfyiLv+dq4g3vNL X-Received: by 2002:a17:903:40ce:b0:151:7343:9981 with SMTP id t14-20020a17090340ce00b0015173439981mr2520945pld.102.1646069815735; Mon, 28 Feb 2022 09:36:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646069815; cv=none; d=google.com; s=arc-20160816; b=Q503Z6s/8auIMc1OheMb1xtxos1eRaRRJlWdh/Lr/kfLAsB6m31Lfu4VvCkbneZNy+ uD3ziCBMi1AVoEErynXHVt+Hx424pvyTIbDjFpFcknCd2cOceN1Evwg1WtD2E79zBcoN tOu2U28kEZq9YX2MWBq/sn2HcVMG2pcbzeNKXulGOhBKqIKW23lB8+uKmMYi1yh8aRzA EpnhKV8TZIJwhV/HO6ATg8wojI/0xmyBqeMeqQl1RnpC2I91fF4doQFlF1fU8it/byjP GFdJi7cctGiWcCkkaEnDVUenCzw+0gnh3AQLxOnCAIv34jE0LGHlO52F1mTnFvZr+03h Ft4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=qxRCCAXAfuoBrGRDkdWXidexd7UZrcXMW5gFBSjgRXU=; b=UvFCvbDmgWqh3tBFJ14/ECz4daG8GbnP10Z9EMfkYmbfk6oNyauDs/ET2dEhQhFqoP rNgC1BpVM4/N/83AFTJCZEF/+EwDgqS6epNCcjs2V0SwN6ZN6HhTlzDWobnJTwyfBVy0 viagA4zF5YCQl/TnR7IXnnJbgThgcywtJEwz/nJpgzXvV/s3coIZ3M8lid6x9Dwj1cNS KJLMV9fXoBrLBRgUtpWFRfF9BTYS/9gJ2ns9CS0inak9/aG9X5LdgCJlWh5Ea8OXEQ5N aDNSWDnHqnYlUnCThDfSTNrADtxzOf8RPR1ucnDmJm/5XhH7yOT5YTRA+AXHYP/SgH1d LmfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a63d547000000b003701ea4c7dasi9387516pgi.145.2022.02.28.09.36.39; Mon, 28 Feb 2022 09:36:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232007AbiB1MR1 (ORCPT + 99 others); Mon, 28 Feb 2022 07:17:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbiB1MR0 (ORCPT ); Mon, 28 Feb 2022 07:17:26 -0500 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E320569CCC for ; Mon, 28 Feb 2022 04:16:47 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id B927A4B0; Mon, 28 Feb 2022 13:16:45 +0100 (CET) Date: Mon, 28 Feb 2022 13:16:43 +0100 From: Joerg Roedel To: Miaoqian Lin Cc: Thierry Reding , Krishna Reddy , Will Deacon , Jonathan Hunter , Nicolin Chen , linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find Message-ID: References: <20220107080915.12686-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220107080915.12686-1-linmq006@gmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 07, 2022 at 08:09:11AM +0000, Miaoqian Lin wrote: > The reference taken by 'of_find_device_by_node()' must be released when > not needed anymore. > Add the corresponding 'put_device()' in the error handling path. > > Fixes: 765a9d1d02b2 ("iommu/tegra-smmu: Fix mc errors on tegra124-nyan") > Signed-off-by: Miaoqian Lin > --- > drivers/iommu/tegra-smmu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied for v5.17, thanks.