Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp" 
        <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
To:     "'Yuezhang.Mo@sony.com'" <Yuezhang.Mo@sony.com>,
        "linkinjeon@kernel.org" <linkinjeon@kernel.org>,
        "sj1557.seo@samsung.com" <sj1557.seo@samsung.com>
CC:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] exfat: do not clear VolumeDirty in writeback
Thread-Topic: [PATCH] exfat: do not clear VolumeDirty in writeback
Thread-Index: AQHYHKozeVmted1T5UKvjQCq+AaGCayoqY+A
Date:   Mon, 28 Feb 2022 07:11:34 +0000
Deferred-Delivery: Mon, 28 Feb 2022 07:14:00 +0000
Message-ID: <TYAPR01MB5353E089F4843C6CE6A0BA1E90019@TYAPR01MB5353.jpnprd01.prod.outlook.com>
References: <HK2PR04MB38914869B1FEE326CFE11779812D9@HK2PR04MB3891.apcprd04.prod.outlook.com>
In-Reply-To: <HK2PR04MB38914869B1FEE326CFE11779812D9@HK2PR04MB3891.apcprd04.prod.outlook.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?T1hka29GY2JLYi96TkdLR2MxQWFyWjRPZWd5U3hoL21LeHl0aVVEZ2h1?=
 =?iso-2022-jp?B?Z2JBd1BVd00rN2VSdUJtTUJtOHV0N080TGZpSUlGbElqNWxvTnNTQ3k4?=
 =?iso-2022-jp?B?YnBiSmJqRUNSL0tudWh2a3FML2pxd1VmQVh6SHFOemxpUUFjWmZta2pG?=
 =?iso-2022-jp?B?bzQyWXBaVnFKTDFZNmxxbEhLZTV1WStQeVk2bHIxRmEvTTJuRHlIVEZS?=
 =?iso-2022-jp?B?cWRFbkNwcEwxSGh3ZlVlbGZMc2MrMnhxTzdoK1dIb3ZKejFiczVyNk5k?=
 =?iso-2022-jp?B?OGN0aVlqcUpzOE5EakorT3o2Y0tLWDAySE9UUjFWR0hNR2JmVUtQT2JC?=
 =?iso-2022-jp?B?a1pKWlJIUjhsL1dkeTFNdVZwODFEWThLZmQ1aEFmUkQ0WG8xelEzT0dn?=
 =?iso-2022-jp?B?QWRHWXJNYi8wMGo0SWtZZXlnMFFDcm1DVERXc0xUcFA5SDl5OVRJU2R6?=
 =?iso-2022-jp?B?TFVmWk9odHRoTmRyMlNXMnIzOSt4a0xMTWZHWEo4ZDJqQzlBSDk3RGtW?=
 =?iso-2022-jp?B?Rm1DenE2cmprMXJVNGliYTl4VHpQVW1ndEJyZGxMZE1iVVg5R1lrN0NZ?=
 =?iso-2022-jp?B?UzVNdnFLdHRHa21XSFB6NFJveFlpTTBhbUJhTlRmdU8zNVNHNzJpRDd6?=
 =?iso-2022-jp?B?aU5leUR4aXpkckZaSEh2dkhudUdFdTM0U2RWU09qL2pBMko5WW9UbHBX?=
 =?iso-2022-jp?B?N3pmVUliMWJHVno3Qm9TcFE3TkFpdWU2UXd2TDZqMldaWGMzVUJ4cWFv?=
 =?iso-2022-jp?B?WVZQYitxSnZNMTM1OFV3YXBGOXUwUGJlWVNkNndCOGd1YmsxRjlnY3Jn?=
 =?iso-2022-jp?B?SnhnQ3k3UE40cld2K2RSSFZYaWZFUWhrc01VaWQ4K3VDMWNha3hES2hP?=
 =?iso-2022-jp?B?QUJqaWJOeGR6M3cyaVhSOW9kM1NOTjUwSGMxUnF4TFMvczgrbHFYQzdI?=
 =?iso-2022-jp?B?MDFGSlNwNUtNb0dGMytIWTNGd25NZWpScmVRSlFDUzF3c21YMWE4N1la?=
 =?iso-2022-jp?B?WE5DUGY3emtrMEt6a3p6ZUgrQlMybnhqUjVQT2V2VUhDdkpud1h2OUla?=
 =?iso-2022-jp?B?ajIxQTc4R2JiYThpUGIwMDIxUHVhUllrWmY1MnNnWGc3Qk1xWGJhNDYw?=
 =?iso-2022-jp?B?N1BEVUVBdDZaRmdldXBWemtoaU41TVZUYUVScUZOMi84TndRT0FHYURk?=
 =?iso-2022-jp?B?djcxUHdpckZoRXN0bE96bzZqQWhTd21CWVN5dXBSQUxpM0Y3VG9FbUlM?=
 =?iso-2022-jp?B?U1RIalIyamJrcnliMGJOUGRwOU9TTHZMZ0dhV0h3TkY3dU41alBkSGl5?=
 =?iso-2022-jp?B?Wk5Mb0pZai9jN3BoNUI4VHJRZno5RjdkNWh2MVUwQ3cxcjFCa1VSVitn?=
 =?iso-2022-jp?B?M2NPYVRqaWpsWS9pbXE1YmRiekpzM3JVcGd4eWMrWWhZVnNmTmtMbGdq?=
 =?iso-2022-jp?B?UEFKVVEwNmpqUWVtbjY4ZzRGMXB6TjhYTWxETGVnQVRvLzhDd1lyRDhi?=
 =?iso-2022-jp?B?Zm5mZXVwRlZwTXZWVFpuTUpMeTBwWjlwN09vRWhUc3ZhN3hqak9hUWdr?=
 =?iso-2022-jp?B?dm9DVlYxdTVvZVhhdzg3KzRrbzhSRG9mMUZzY1JnMi9LS2dYVG9IUVBm?=
 =?iso-2022-jp?B?a29uMHkrV2lKbUo1N3Z5Skthczd3NzIyUG9KNnJGR2ZkQ2ZiaWJHMmdr?=
 =?iso-2022-jp?B?MnpUc1FhVExhR2hpeU1CT2d0bVZ0RXJSbFlIdWtXSjFQV2ROUWNqOGVZ?=
 =?iso-2022-jp?B?cmpFT21XekJDVFR1UDVoQXdqaU14aTV1RU5YaE9Zc0JxZURlZHNPQ28z?=
 =?iso-2022-jp?B?VlczNzE0eDBnTTN6aUZuVmhSK3JXdXlhS01qeWt0T1pPWkZWaStnYUNY?=
 =?iso-2022-jp?B?SXRXWVJPVDNDNlZ5ZzNKT3NUSEU3MU1Hd2ZZR3ppTkhoNjFaN0l4N3li?=
 =?iso-2022-jp?B?TnVVTFBIalhkNFZ2VHFlSDIrWGc1MENtUzlsVFpSdWp0VWo0NmF3VkZy?=
 =?iso-2022-jp?B?VUJYa1doeFpNaUV0a2pkU2tPbXhNRXp1dUtGalpEaGRLQi96MEZPS3RT?=
 =?iso-2022-jp?B?NHhZbDZ2c25rZW5xa0czVjlVZG5ZUVQwUlZGNU13UjVsOGN5REhZbkFy?=
 =?iso-2022-jp?B?NnNBaWNOeDQ2ajhPQ0xSbWZVUGwvdVhxQllLeTNSb0hPVlQ1QXdvemty?=
 =?iso-2022-jp?B?U29qbllhWXVyVE9zR1kxRi9Penp2Rk42S0hmaG5ZUmFxR0JjTDRRcXZJ?=
 =?iso-2022-jp?B?YURCU0pNelR2dDVxc0JpU214T2ttYk9ub05HaEFVK01LYWp1dVZEUVZF?=
 =?iso-2022-jp?B?ZGU2ckVENjNsbVpJaWdvcDE5Z0EyYnhiVFE9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: dc.MitsubishiElectric.co.jp
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB5353.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96891264-64db-43eb-3982-08d9fa89f3a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 07:14:25.4256
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JOENMwNAVt/0//NNxIpJ2xE0ASIppKAjvLPxmS99254aQAnTjDik130lT5NLuo1VLhOUFQf81jZ1Jwx/dBh9BA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB8530
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Yuezhang.

> And VolumeDirty will be set again when updating the parent directory. It =
means that BootSector will be written twice in
> each writeback, that will shorten the life of the device.

I have the same concern.
From a lifespan point of view, we should probably clear dirty with just syn=
c_fs().

>  	sync_blockdev(sb->s_bdev);
> -	if (exfat_clear_volume_dirty(sb))
> +	if (__exfat_clear_volume_dirty(sb))

If SB_SYNCHRONOUS or SB_DIRSYNC is not present, isn't dirty cleared?

> +int exfat_clear_volume_dirty(struct super_block *sb) {
> +	if (sb->s_flags & (SB_SYNCHRONOUS | SB_DIRSYNC))
> +		return __exfat_clear_volume_dirty(sb);

Even when only one of SB or DIR is synced, dirty will be cleared.
Isn't it necessary to have both SB_SYNCHRONOUS and SB_DIRSYNC?
And, I think it would be better to use IS_SYNC or IS_DIRSYNC macro here.

BR