Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Feb 2022 17:02:54 +0100
Message-ID: <s5ha6ebrnbl.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Joe Perches <joe@perches.com>
Cc:     Meng Tang <tangmeng@uniontech.com>, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement
In-Reply-To: <e5c1ba2f7db29b78066d12dab812b7a1c0a37a81.camel@perches.com>
References: <20220228050253.1649-1-tangmeng@uniontech.com>
        <20220228050253.1649-2-tangmeng@uniontech.com>
        <e5c1ba2f7db29b78066d12dab812b7a1c0a37a81.camel@perches.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 28 Feb 2022 06:20:45 +0100,
Joe Perches wrote:
> 
> On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote:
> > Return the result from file->f_op->open() directly instead of
> > taking this in another redundant variable. Make the typical
> > return the last statement, return early and reduce the indentation
> > too.
> > 
> > Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Hi Meng Tang.
> 
> For the next time: it's not necessary (or even good) to add a sign-off
> for another person unless they specifically authorize one.
> 
> You wrote and are submitting these changes, I merely gave you simple
> suggestions as to how you could improve them.

Joe, would you like to drop your S-o-b lines from those two patches?
Or shall I keep them?


thanks,

Takashi