Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2987685pxm; Mon, 28 Feb 2022 09:48:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhyKrWjXwToS1kh2i6FLi703gV82mnvazyCPdWKp/8HTa2X8OSkaLk5i+8I8pISXhAC8/l X-Received: by 2002:a05:6a00:218a:b0:4ec:c810:67ec with SMTP id h10-20020a056a00218a00b004ecc81067ecmr22949545pfi.51.1646070491494; Mon, 28 Feb 2022 09:48:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646070491; cv=none; d=google.com; s=arc-20160816; b=pjyBWtgnoTNeZiJVJ3JNDrpjRgroMmLfb9JuEcixyYu0msfjIpu8HHzQOEcJ69bW56 j3UGOWYcIHkCqCcz+l/+wnaRI8n6w2zKScvSSzbAWc+gC0KvhoZNMxl457NhwgO6tyTF kdrztFWuP2qO+WFeVeI7SHK7aS6I4CAJh9zIW3/kFkSdVvTRn0Ufn/xTgN6+WKbyI+eP vE6k2lUmHwD36XiJo6WRfOI3hnVaSMTNuZFuJtVIW0F0t38JH6CKCpEchBMDUa0dmf0G D3+Xnx5m6pjDic946fhL+XluXrhQmpzU6USeEwhhbyuQlHFTFNVOk983I1FPVebY3e3Z mOyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=hGTfvCQhrt/SMIRr7jr1rjKHBVEjBKSzMSd1EBTGR88=; b=bU6NaeX5bA3vp8KQ3PsotxmxDkX8AM/9gh8UVe+Bg5CnYHbnn0Z9Mhm44rACV2OknK ATSQzdihVSmU7Z5Pzi1bfte7r9awxniSTKrXe2KsdY2gT6bJwlIqsL6h992kiMRa3qcN 66vKCiONJFw0Al4Jk1RhsZ2D0rxIhMYjoeGukWnjcH8jkEFHb9KSZVEt9gNPOpw7C+uP BEgQga57e+TlK+np8sLabRkDpETZ35kA65UOg6HDP3xGM2YhgynWstB4kvHN65QFm6n+ LQGSWidgf4GEU4ManAtAblE8HQbkBUgh5ToE99BmJ8b7pkLXP+DH8JP16PXKxPM4pFhI XHYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=RMvd4SO0; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a15-20020a170902b58f00b0014d23053da0si9391268pls.65.2022.02.28.09.47.55; Mon, 28 Feb 2022 09:48:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=RMvd4SO0; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237709AbiB1QBY (ORCPT + 99 others); Mon, 28 Feb 2022 11:01:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbiB1QBW (ORCPT ); Mon, 28 Feb 2022 11:01:22 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148D98301F for ; Mon, 28 Feb 2022 08:00:44 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BF9C71F899; Mon, 28 Feb 2022 16:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646064042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hGTfvCQhrt/SMIRr7jr1rjKHBVEjBKSzMSd1EBTGR88=; b=RMvd4SO0qA4gNblsvo/BvVPnjsN24PK4RvPQOQY8AK6xOT/hXGANnQ7ZmXDkK2cB1dOsck KDSsggwYQrAJkdLxERW57Pmw55xaY/Rc/7n36ir4vCyDrkXAdgIu/1QstovxHQaT3gnkBT XBOImZpd9Dh5H/9ecjmHh+rU5yBSNsg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646064042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hGTfvCQhrt/SMIRr7jr1rjKHBVEjBKSzMSd1EBTGR88=; b=APSnLcwkE7M8GOLjXPGfvSaWXD7tDuSRJtxTNoETQKr1j8ec9O9kFw6EqsPOqydjBG+8Q9 UTmDQ4c2cx4qEVBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id ADBE7A3B83; Mon, 28 Feb 2022 16:00:42 +0000 (UTC) Date: Mon, 28 Feb 2022 17:00:42 +0100 Message-ID: From: Takashi Iwai To: Jiasheng Jiang Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: spi: Add check for clk_enable() In-Reply-To: <20220228022839.3547266-1-jiasheng@iscas.ac.cn> References: <20220228022839.3547266-1-jiasheng@iscas.ac.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Feb 2022 03:28:39 +0100, Jiasheng Jiang wrote: > > As the potential failure of the clk_enable(), > it should be better to check it and return error > if fails. > > Fixes: 3568459a5113 ("ALSA: at73c213: manage SSC clock") > Signed-off-by: Jiasheng Jiang Thanks, applied now. Takashi