Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp2992540pxm; Mon, 28 Feb 2022 09:54:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJweJbCW3lFXZ8vhSJZGXS4W3z+NpF2gXXr8og8PNb4kWOb5OqpOik+R5pIci5puVKJ0Xfrp X-Received: by 2002:a63:5f0f:0:b0:370:1db0:5766 with SMTP id t15-20020a635f0f000000b003701db05766mr18300354pgb.532.1646070864306; Mon, 28 Feb 2022 09:54:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646070864; cv=none; d=google.com; s=arc-20160816; b=as39d7cs/gBUY5JggxMvQF3hDxQvDGgY+FkRv3gDrL0kEkdiO6fX0UF4vCMFCzmyVC rb2MMPrAXEiKetqh4KIss9zqTWYx0hU8+q0CqKLLEkd2cYJK+hxvw7+EMfcOi+cafKj4 aw5bVY0hjxp+DiY9vz2vnq9vsqagkewfM9Ma4k/LmKKoS1IZglhgF3DJVIZU1Nu5mhGH oVmXyjc3hrHhQ1hIj5N8Lt2sStABo6HEkrpdAMjXDS+aYrDZDrEb9vLUMCjWpNwp0Jq0 PI0kkuqNRJge6oXF0Y3zCoE7NpchSrwSBn9AgwGdxcglAUAFU9gddcHFA9IZ1P9c9sQ+ UyWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=7SQezWrefdfyxYAuqsK1Ki9iYBM12AVThkoZEyjK+Zc=; b=xOc6cc8M/f6yiXMjzj1UD31VfuC03COpbuFm1uKwbnrRVwqR2Z6G1pg89buaHqSuTM ng0CLI4hXuSieHGFDzbW399F4V/aWn7kbbVXRpSNQTPaFLeHaTGFmw/i8y8s1F5RrMGB SG9J3bDb6ilqyzNnKpYDTdd3nEO4keFjkSckqzcnGW28J4dr/5WVcCFofeTMx0rfoZL6 2WvNYHFK7ML+YF8w/vPSc9c/oGQGz1JHZtDEfdd5dMjPyRnhtZjtXmNkc8VeGcASeDjE fhaaNrhOnJHBJ3v98MP7+6ZGALPO+ZaTg6CO9s0Vepi00qwUlpxVVqpGFlrlmtpIpLAP QeXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZPU88y8Z; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u63-20020a638542000000b003656c6cc42csi9919659pgd.670.2022.02.28.09.54.07; Mon, 28 Feb 2022 09:54:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=ZPU88y8Z; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238077AbiB1Q6l (ORCPT + 99 others); Mon, 28 Feb 2022 11:58:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237903AbiB1Q6j (ORCPT ); Mon, 28 Feb 2022 11:58:39 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C8B12DD69 for ; Mon, 28 Feb 2022 08:58:00 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 083791F446; Mon, 28 Feb 2022 16:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646067479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7SQezWrefdfyxYAuqsK1Ki9iYBM12AVThkoZEyjK+Zc=; b=ZPU88y8ZF6FXH0afyVvu6HAMJgRMsZF3hNWU2XICwxzXL/snhtsxGXhAVRF2gokDO9Gom+ px+XSjFF7ndXCbfn1l5fBt8sbOzQlKzZKsalRzM6QSv1AXR9RbevP2iOkOEtYoRrJE3sLN YW/VZqwoL83En2w7OJgirSXFdUWizaA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646067479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7SQezWrefdfyxYAuqsK1Ki9iYBM12AVThkoZEyjK+Zc=; b=nBQswWkpY13GEqau7Zffx2DBRTDruvMIeiXXZgmJknRXIVZW1tru+BRU7vtJLxNiMDhtrT 4AzaOm7mF03FIGCA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id C745FA3B8B; Mon, 28 Feb 2022 16:57:58 +0000 (UTC) Date: Mon, 28 Feb 2022 17:57:58 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Meng Tang , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement In-Reply-To: <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Feb 2022 17:39:21 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 17:02 +0100, Takashi Iwai wrote: > > On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > > > Return the result from file->f_op->open() directly instead of > > > > taking this in another redundant variable. Make the typical > > > > return the last statement, return early and reduce the indentation > > > > too. > > > > > > > > Signed-off-by: Meng Tang > > > > Signed-off-by: Joe Perches > > > > > > Hi Meng Tang. > > > > > > For the next time: it's not necessary (or even good) to add a sign-off > > > for another person unless they specifically authorize one. > > > > > > You wrote and are submitting these changes, I merely gave you simple > > > suggestions as to how you could improve them. > > > > Joe, would you like to drop your S-o-b lines from those two patches? > > Or shall I keep them? > > > > thanks, > > > > Takashi > > Hi Takashi. > > Nominally, the sign-off-by chain shows who pushed these changes upstream > and I did not and I am not an upstream aggregator. > > But whatever you choose is OK. > It's not really a concern to me. > I do think these changes are ok. OK, I dropped S-o-b lines and applied the patches now. thanks, Takashi