Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220222141838.1.If784ba19e875e8ded4ec4931601ce6d255845245@changeid>
 <CACRpkdbQ9U22afR74YiZs95qCm7dnLb2k4_nT3Le__hJPpDGUw@mail.gmail.com>
 <YhXBIxbx63IXBU7L@pendragon.ideasonboard.com> <CAD=FV=UV+3PNF=O8Zv4UJK50gvDx=WHbamLLhH5ANZUBeCxjdQ@mail.gmail.com>
 <YhZY+FLTlv7V5BIB@pendragon.ideasonboard.com>
In-Reply-To: <YhZY+FLTlv7V5BIB@pendragon.ideasonboard.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 28 Feb 2022 09:54:36 -0800
Message-ID: <CAD=FV=Ux9aPqNnbs4vj1EO49smW7f6VVm4VyGTy246QjGUfqHg@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Properly undo autosuspend
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Brian Norris <briannorris@chromium.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Wed, Feb 23, 2022 at 7:55 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Doug,
>
> On Wed, Feb 23, 2022 at 07:43:27AM -0800, Doug Anderson wrote:
> > On Tue, Feb 22, 2022 at 9:08 PM Laurent Pinchart wrote:
> > > On Tue, Feb 22, 2022 at 11:44:54PM +0100, Linus Walleij wrote:
> > > > On Tue, Feb 22, 2022 at 11:19 PM Douglas Anderson wrote:
> > > > >
> > > > > The PM Runtime docs say:
> > > > >   Drivers in ->remove() callback should undo the runtime PM changes done
> > > > >   in ->probe(). Usually this means calling pm_runtime_disable(),
> > > > >   pm_runtime_dont_use_autosuspend() etc.
> > > > >
> > > > > We weren't doing that for autosuspend. Let's do it.
> > > > >
> > > > > Fixes: 9bede63127c6 ("drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend")
> > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > >
> > > > Hm. I know a few places in drivers where I don't do this :/
> > >
> > > It seems to be a very common problem indeed, I haven't seen any driver
> > > yet that uses pm_runtime_dont_use_autosuspend(). We could play a game of
> > > whack-a-mole, but we'll never win. Could this be solved in the runtime
> > > PM framework instead ? pm_runtime_disable() could disable auto-suspend.
> > > If there are legitimate use cases for disabling runtime PM temporarily
> > > without disabling auto-suspend, then a new function designed
> > > specifically for remove() that would take care of cleaning everything up
> > > could be another option.
> >
> > Yeah, it would be good. It's probably not a yak I have time to shave
> > right now, though. :(
>
> I don't insist on shaving that yak right now :-) This patch is fine.

Landed in drm-misc-fixes:

26d347434829 drm/bridge: ti-sn65dsi86: Properly undo autosuspend

-Doug