Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 28 Feb 2022 10:21:30 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next 1/1] net: dsa: felix: remove
 prevalidate_phy_mode interface
Message-ID: <20220228182130.GA6816@COLIN-DESKTOP1.localdomain>
References: <20220226223650.4129751-1-colin.foster@in-advantage.com>
 <20220228114634.izmpym7x6kvjjvq6@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220228114634.izmpym7x6kvjjvq6@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dDCulCPg8vDhHLbN1FtWQsYedJz8dnECuDIIlZioVS6jMJaiOQ5WW8/PdZ6Q?=
 =?us-ascii?Q?NzKHCI87msLnsjWgbnZNz9BEO9msOaTC/UTqiIygT521NkX/RQ9xbzKy6UsX?=
 =?us-ascii?Q?c2luoSopjidKizcYz1LHQrVhgjriOu6Eo24wKEnKrgLcYJ3bS6dHm0YC39wo?=
 =?us-ascii?Q?UFiZuovYDr1XEa/qUlqzF9kAbeXaZYF++Jp+B7pPMRiZc14e9t5WtpO4uAes?=
 =?us-ascii?Q?zIvOCPtqoQa2TotJgan86nujZfi3y0BVmdNP5mG0YIKSY4ZEMUWT8B3BGxYw?=
 =?us-ascii?Q?F6LZLM/jKZc1LVbq61CIWPyOF8gUJ95T5em8S1Tg9U3YvGTbAyv4FhOeDwsj?=
 =?us-ascii?Q?9v3TWfTpoj21U1fyJwmP1dyE7XGmeMTpT8BiofC8M7IPbfAKqWXocum95kZg?=
 =?us-ascii?Q?TyaQchkDqAUKBhLblEwmxlhN9y3d4nTNgf2DtXt/B4WZ1wpifUnh11KaXGdE?=
 =?us-ascii?Q?sI9EqvV8224VWN+UqPSBZzUThBYKYfdsOK4CtugqAbWSH8x+/EAN20aIpiIN?=
 =?us-ascii?Q?ULw0td/sw75S2R0QwvTjlz+e1WPA7JTRQy8wcoU+84ccyy57egVwYYjSf/1I?=
 =?us-ascii?Q?mTPaxQFFdWIky2SgBfoZ+mtI3x6lIcAtqSGzBoJG6Ztsxuhpytm2rFvSsTUv?=
 =?us-ascii?Q?bK5sgWrkTvloxw1D18bI5cik++14FvTIlDJMWxLgDh9zm300TpOgqOyGZIP+?=
 =?us-ascii?Q?N2LTEciEaOatJYp8GoBU9ogKxyplpxh+DMpjf7dGpsd20i3z+p2J8kXm7goN?=
 =?us-ascii?Q?8XPd55mtEPNhY0egnyeCqRnucQ+soth5Q4935E0h/eJD3B4Sa0MGcwEbecMF?=
 =?us-ascii?Q?O8lcSm5FYNWeSXjoZ2fzWiCVRyvb+D0idG+boMJ8I7NUXNp+ytzI+KnQTo04?=
 =?us-ascii?Q?eRYg/B+6vZaD0OaIfsmy8Om9nUHTqk2ecxHoPBIt6JQQVQPTzgEFQYH0+y3K?=
 =?us-ascii?Q?Ga/vASgxhTuGC3qSJF80iOE+XCzbV7vslSrPfeQVtHQs1Ybt++i2xYGFSCwE?=
 =?us-ascii?Q?MQqbOZ3xGU1RRABMD7MctjKxR8CzVyP/chFAB630UvhP0Ign7BwrlUNYFqmN?=
 =?us-ascii?Q?OkIpqkajwn5chTJPTIa+5bOTQUmWGSNCmRvBhLxL1tmgWCZdMBwQ+w0h2wam?=
 =?us-ascii?Q?/vYEzGEm4nP+ePmHR1Xin+92R5pYMVtxR6u2rPtzwTyXwjAruYnUGHVd0l+7?=
 =?us-ascii?Q?BGJFlNpoReTysiebBPEGvs+1sTf9BY17aoDGKQdLLaRfquSPDTFn96phTfYS?=
 =?us-ascii?Q?P8ge41P+gLid0XBz8T2EVwVcmX+gYKaviNpyldsV5qQQDJKRlWQuy3OgrKfg?=
 =?us-ascii?Q?+ohi/1pY5lk8BBrb3XGqYbdxA0woSCgTXaMn4wuVoMg31sVz8mNgkSIjSZ2l?=
 =?us-ascii?Q?Qn6guBe+/Jgwij/fIb0bhy5l2yrGVYEv2X3R5TR1qQKWz5B1gRWaOQPkVqkT?=
 =?us-ascii?Q?wi+UC7P72RsVAOHLe7+FXLHhtQqEuN4lWXgpBmhTmnmIUBxfaiWstV4E1uaQ?=
 =?us-ascii?Q?VbAKr8baVC3qcJ8ZeWMUpv1zR6LBMR/fMjq2YdGUUk7NuDl3sQSMZaAHyFfT?=
 =?us-ascii?Q?SWP/o1+d3Iz7yPgfOEi8d7c58wFmYGsc/br9/SFGhCzlp7rf9gYp6MMgH942?=
 =?us-ascii?Q?MfRKgQH1zHIsw7UAliTQIUJDG16stDaXJuWuWxhDyVHovsvOQR3iRhiryxFs?=
 =?us-ascii?Q?FWvCkg=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7dffe7c-04e0-4072-1e03-08d9fae7204a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 18:21:23.8878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Be9B8QZBQ33wsib8Kecv+bP+F5h0RScqeEa9R1rXBO0GkPL30sEWxxejm0rY+DuyIS93HIIqGzsN8Pc8PSdZEfzgmDrzPv2QYGa+9QUvzhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2160
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 28, 2022 at 11:46:35AM +0000, Vladimir Oltean wrote:
> On Sat, Feb 26, 2022 at 02:36:50PM -0800, Colin Foster wrote:
> > All users of the felix driver were creating their own prevalidate_phy_mode
> > function. The same logic can be performed in a more general way by using a
> > simple array of bit fields.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Thanks Vladimir!

I realized I didn't respond to your feedback email from my last patch
set. My apologies - I had shifted my focus to the MFD infrastructure
changes. I hope to be able to send a new RFC soon with all improvements
both you and Lee suggested.