Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3144546pxm; Mon, 28 Feb 2022 13:01:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVHqpja16PcZvaQ8TXuVGfHZniqA/Z1TyuHENnZVu4GADX37ipPfCT6UYGIOXg5BWhcwHw X-Received: by 2002:a05:6a00:1a42:b0:4d1:e81a:64cb with SMTP id h2-20020a056a001a4200b004d1e81a64cbmr23854427pfv.78.1646082110776; Mon, 28 Feb 2022 13:01:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646082110; cv=none; d=google.com; s=arc-20160816; b=bWi255hXfwQsFsXpV4PgmQAzKqfdlQMB2tHYpnkV9mr5a+VjGbpCEhh5os+ErQTyo4 jQ5QJYvwtFXI1hha6agWleQeGtZpcCUdZg6bCCrlZOo7xYv2jwpu3rWRVpvhIRPgJBzR RohmolvO2tm/idNaRwQs3rMdlm/lVZB38hH+JlXdxgGgOiCLHS+6Wl4P6h8oyvBp1lyU z9eVjyRq26nQTlE4PmrupeTS2Am4Wx8Q84jCOU3BF2uNrLpAQBLaG2qb4MRzJbEGAcK0 qhacTJcDRYqgXVVJ6uGJhSJ6jI22bsUR10SkJHFwdSImP7Gplh5YZbwsYguae5SdAT7h v5UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JTZz2T2Na+vRzqmRdpOujmk+1KCqOLa2nPaNBU9nqrM=; b=AG2CPbwwORdIhumnkvTWO0AnUZovMVDHon5dYnqZon537dnUAb9mqTM4RbIZ0V/Fqk eiZ8yqytSC59ehZNbn3GHbf7fj4bHJyDwt7kRk6eKja6ya1hb/jFzzmfRWUxW5dIc3+2 Il2Wwgf1X4gNVcZIIab9mTEkzNx0Rm/IUF80DKoZ8YrzNT8ksk/3iKu8fLlo8B4m0cXR nP82DOksDqzlsRUxYH3gSDFhMRziV1Ppx185iX7eOpTWr7CGigBrg/pJLcBte/iBULyG pCYz+N3Rmjq5Y+AYo8Nld9S7Ux1wg/jrkjp7N/kJwVzEiY7uQtkibRIq+fsqIL7spAaK dmoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tzy0WmcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a62e505000000b004e12e13947esi9483211pff.187.2022.02.28.13.01.34; Mon, 28 Feb 2022 13:01:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tzy0WmcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229713AbiB1U7y (ORCPT + 99 others); Mon, 28 Feb 2022 15:59:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229673AbiB1U7x (ORCPT ); Mon, 28 Feb 2022 15:59:53 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2469369F5; Mon, 28 Feb 2022 12:59:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 601AAB8165B; Mon, 28 Feb 2022 20:59:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2DB6C340F1; Mon, 28 Feb 2022 20:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646081951; bh=9DFC8+ejskEuUZnsxASmagFdYxR7Vh6yUJxTxyJU0xE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tzy0WmcNphDKxKnlaRvvOyPdgQBhuO0l/KoeJ7U6GP4aZf9Mh4WP7YcIkQdI9MFzh 49Z4FcShoqj5QXNuByQCBzPR3Zt9GN8p404dvaCWnNY4HP44O8BVnjQ40n5gYrBcrb WGe87xcp5dnQgIp90N36AsWlRfaCX5S6k4mhnq9U= Date: Mon, 28 Feb 2022 21:59:08 +0100 From: Greg KH To: Giovanni Cabiddu Cc: Linus Torvalds , Kyle Sanderson , Herbert Xu , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , Linux Crypto Mailing List , device-mapper development Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 08:39:11PM +0000, Giovanni Cabiddu wrote: > On Mon, Feb 28, 2022 at 11:25:49AM -0800, Linus Torvalds wrote: > > On Mon, Feb 28, 2022 at 12:18 AM Kyle Sanderson wrote: > > > > > > Makes sense - this kernel driver has been destroying users for many > > > years. I'm disappointed that this critical bricking failure isn't > > > searchable for others. > > > > It does sound like we should just disable that driver entirely until > > it is fixed. > > > > Or at least the configuration that can cause problems, if there is > > some particular sub-case. > The dm-crypt + QAT use-case is already disabled since kernel 5.10 due to > a different issue. > Is it an option to port those patches to stable till I provide a fix for > the driver? I drafted already few alternatives for the fix and I am aiming > for a final set by end of week. If the existing situation is broken, yes, those patches are fine for stable releases. thanks, greg k-h