Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f0b158dc-5b01-67aa-1f49-331bf1ff2bfd@nvidia.com>
Date:   Mon, 28 Feb 2022 13:16:34 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 6/6] fuse: convert direct IO paths to use FOLL_PIN
Content-Language: en-US
To:     Miklos Szeredi <miklos@szeredi.hu>, jhubbard.send.patches@gmail.com
Cc:     Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
        Christoph Hellwig <hch@infradead.org>,
        Dave Chinner <dchinner@redhat.com>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Theodore Ts'o <tytso@mit.edu>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-xfs <linux-xfs@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220227093434.2889464-1-jhubbard@nvidia.com>
 <20220227093434.2889464-7-jhubbard@nvidia.com>
 <CAJfpegsDkpdCQiPmfKfX_b4-bkkj5N5vRhseifEH6woJ7r0S6A@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <CAJfpegsDkpdCQiPmfKfX_b4-bkkj5N5vRhseifEH6woJ7r0S6A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVpmNHg5ZUpEM0VCRWFHZjRQSjRSSGRIRG1WZkw0eUxpZGNQOVZna1FxalBv?=
 =?utf-8?B?NnQ0eWcwNStEZG5rQnlJZjBKTVp1UmlvQWF5SUNTS3FpMVk0YVB4SnM1WE5n?=
 =?utf-8?B?dmdzd2RmdzZlcFlIOEg2Y0UwUjQ2M3Fxdit5dXVHcUNzcEpWR3B6NzBINjU1?=
 =?utf-8?B?TDIvbzVoVVd1R2o5eWRMTk41K3lNeks3U1Fab1FXcGRySzZNSmUvQnlTMzI5?=
 =?utf-8?B?TVVxS2w4MmFaRzRRVU92RlViUmVvVXBUNDNWNUt4U0tVNGt6MmxQZ21sbCta?=
 =?utf-8?B?Sm9mVmlJeTRXVklMMWcvaUtYUDVzeWptaHhmZ0hKbktlYjF1Q292elYySWVj?=
 =?utf-8?B?Y1AzSFVINlpGWE5LUFRjZjMreThMcVhiN2IxemlHUkZNejM5WUJzQmhsSVcv?=
 =?utf-8?B?L2doWWJ0bCt2dE1tem9VWGVWSDdXMGVVNWxFTUE4ZjlsSGFyeGJFWXVIWWhr?=
 =?utf-8?B?OXJQbXR6MUE1RTZNV2Y0MlNacjdFMkpVdHRRczNpSUpNdUsxV1lLeFYxVGpw?=
 =?utf-8?B?bXM1d0kvT1M1RGNRclBTWitMVXpVTW1hY29Mdm1ZL2VNT005MWRSYkt0SkNG?=
 =?utf-8?B?RDZ1VkM5M25PTWdNdjhXOE5obEZySTIxZUcwbWgyTFBuR01sWnRTOWtZcHd3?=
 =?utf-8?B?dllxSjFZaUZwQ0FVTUtSQ0ppK3hPcUtkNklmYTlEWDlCc2JLbFhvOExkODN2?=
 =?utf-8?B?alJONUtUYWc3OTJzUEV0amdMMWJQd2svZndwWWl6UjdjbFQ5dDgyZlpYcmF6?=
 =?utf-8?B?QzNZd21UenE4cUx2NFNzQ1YzRHVYWXhjS1BpTWQ4STlUM0x4b0NIWVltVFVE?=
 =?utf-8?B?ZUdpUFA3T2NNSWRrbkpRbzFUV2d2YWhFYzNRdTF5Vk0vTjI2bDduczREd2wx?=
 =?utf-8?B?d3B1RVhHVHliYXFYWkRpQ2dmdHRLZEFsRE9jVVNsTWxiaURDV0ZseE9vbWN2?=
 =?utf-8?B?cWo2VFBDVkR6QVV0V3VQZTRVVWltZVF2NVJKbFZ5TWZsRkk0ZlFTK2p1RzFX?=
 =?utf-8?B?VUNiZlhKaCs0M2J4Y0c0S2pUNFZVM2MrNGR0d2pyK3R0Vkt2dmhYay9TWFFM?=
 =?utf-8?B?M3BZQmZ6U053YUFla29scHZyUnU1bW1kWXFYSFB1VFU1cHRKNXJZajNGWjh0?=
 =?utf-8?B?NDI4SVdsQnpzR2RTZFRvREZnN2JWYU5NVHU0SUZqcUY2ZDFDUkN2WXBHSmVD?=
 =?utf-8?B?dUlKc2RVRFF0UGlNcTlGZmFSb25zYmg3MmJSQnp0RitWeVJyRTI3Mmkra2Zn?=
 =?utf-8?B?SkUrYmJuRXFpLzBxbHZpaEtiZ3VVOFduLysyWEtiT04rN0VQUzBMOWdKYm5i?=
 =?utf-8?B?QUJVeUxPTWFrZTJrM1gzZmFIM1MxVkxhYThTSzUyOWFCMWJqd2hjUEdBZkRz?=
 =?utf-8?B?aFhqSHNZUVBRZjdWc3p4M0NQWlpoOEhTYXdwaHpScGlRN2J4Yms0RDFxeUhF?=
 =?utf-8?B?MWFtdGhqRERhcGtocVBjWHBMSFlBY2svY3JtUHNtMEFxbTg1NVpyYWw5T3Av?=
 =?utf-8?B?WHNHbFVOTE5xejJ0SDZDTlh1N2pSbExQR1FOT0dML1ZsSmtoWlgwRUpiVzlR?=
 =?utf-8?B?a3VvQXoveGR4dk15Y2xzY3FVaXpnaUVDSTJ1Y1h3dUpFbkVKa045bzZyYUZM?=
 =?utf-8?B?TnBOaUI1VXpjeG82aU9SMHlna29tYzRkTlU3YXhSL3dEeWR4dXNrbitoWGRx?=
 =?utf-8?B?T3N0d3FuSlhwc3FvYmtLSzIxTkxSeUh2UzhDakQxbC83WUErQUgzWXVNQ1JW?=
 =?utf-8?B?bXE2V2d1OHpoVXd6UVdkYWNUbmNXOW1sSU8xaUM4Y09UQS9MMEQxZ0xTNmtj?=
 =?utf-8?B?SUFGWmdPbUpVSy9CSUJoaGhqM3d2UmdnZDNISklBQm01Mm4xd1FHTTFleTdV?=
 =?utf-8?B?eFdtNFNEa1VNbG1DVFJ5T29vQ1ZNQ1cyeHBudE1kV1RkN25BRUFJcWVtUmNZ?=
 =?utf-8?B?a04vckdjRlc1S095am9vZWN2TERkWEljcUFtd2xhUTE2cFcyNk80ZlY5MkxT?=
 =?utf-8?B?RVBjNTMvNnlzdzZFU3pYbk5oQkJjd0x5ZEJZbmxCWVBsbjFrVmxGSkhOdmtt?=
 =?utf-8?B?WVAwRkZzcWN5Syttc0ZIRHZuckRMRXBmaVV0VUM2NHd0SDNwV3pXRmhaRTly?=
 =?utf-8?B?bElnWmFxTjlRelBvOEdocXJBbnVtMVRKejZaRmhiWm8rWFBoZWhNK3ZyUGNz?=
 =?utf-8?Q?ukFnJYk3jrgQ6Ow+jZ7kxVQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26364b12-1290-4acc-3921-08d9faff99da
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2022 21:16:35.6018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZLLMMkvfDDnGhp2TecUlWh+Fuh5ZpOf38qWAObt35QBYlQn/OGvpwt1bZyyNNcHLdzFparf/ZwivI45A380sWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0268
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/28/22 07:59, Miklos Szeredi wrote:
> On Sun, 27 Feb 2022 at 10:34, <jhubbard.send.patches@gmail.com> wrote:
>>
>> From: John Hubbard <jhubbard@nvidia.com>
>>
>> Convert the fuse filesystem to support the new iov_iter_get_pages()
>> behavior. That routine now invokes pin_user_pages_fast(), which means
>> that such pages must be released via unpin_user_page(), rather than via
>> put_page().
>>
>> This commit also removes any possibility of kernel pages being handled,
>> in the fuse_get_user_pages() call. Although this may seem like a steep
>> price to pay, Christoph Hellwig actually recommended it a few years ago
>> for nearly the same situation [1].
> 
> This might work for O_DIRECT, but fuse has this mode of operation
> which turns normal "buffered" I/O into direct I/O.  And that in turn
> will break execve of such files.
> 
> So AFAICS we need to keep kvec handing in some way.
> 

Thanks for bringing that up! Do you have any hints for me, to jump start
a deeper look? And especially, sample programs that exercise this?


thanks,
-- 
John Hubbard
NVIDIA