Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220228183955.25508-1-jose.exposito89@gmail.com>
References: <20220228183955.25508-1-jose.exposito89@gmail.com>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: switch to devm_drm_of_get_bridge
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     linux-pwm@vger.kernel.org, jonas@kwiboo.se, airlied@linux.ie,
        robert.foss@linaro.org, dri-devel@lists.freedesktop.org,
        narmstrong@baylibre.com, linux-kernel@vger.kernel.org,
        jernej.skrabec@gmail.com, thierry.reding@gmail.com,
        Laurent.pinchart@ideasonboard.com, u.kleine-koenig@pengutronix.de,
        =?utf-8?q?Jos=C3=A9_Exp=C3=B3sito?= <jose.exposito89@gmail.com>,
        lee.jones@linaro.org, maxime@cerno.tech
To:     =?utf-8?q?Jos=C3=A9_Exp=C3=B3sito?= <jose.exposito89@gmail.com>,
        andrzej.hajda@intel.com
Date:   Mon, 28 Feb 2022 23:24:36 +0000
Message-ID: <164609067646.2361501.15747139249939190799@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Hi Jos=C3=A9

Quoting Jos=C3=A9 Exp=C3=B3sito (2022-02-28 18:39:54)
> The function "drm_of_find_panel_or_bridge" has been deprecated in
> favor of "devm_drm_of_get_bridge".
>=20
> Switch to the new function and reduce boilerplate.
>=20
> Signed-off-by: Jos=C3=A9 Exp=C3=B3sito <jose.exposito89@gmail.com>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/brid=
ge/ti-sn65dsi86.c
> index dab8f76618f3..fb8e16ed7e90 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1232,15 +1232,9 @@ static int ti_sn_bridge_probe(struct auxiliary_dev=
ice *adev,
>  {
>         struct ti_sn65dsi86 *pdata =3D dev_get_drvdata(adev->dev.parent);
>         struct device_node *np =3D pdata->dev->of_node;
> -       struct drm_panel *panel;
>         int ret;
> =20
> -       ret =3D drm_of_find_panel_or_bridge(np, 1, 0, &panel, NULL);
> -       if (ret)
> -               return dev_err_probe(&adev->dev, ret,
> -                                    "could not find any panel node\n");
> -
> -       pdata->next_bridge =3D devm_drm_panel_bridge_add(pdata->dev, pane=
l);
> +       pdata->next_bridge =3D devm_drm_of_get_bridge(pdata->dev, np, 1, =
0);

Yikes, I was about to rely on this panel variable to determine if the
device is a panel or a display port connector. (Well, I am relying on
it, and patches are hoping to be reposted this week).

Is there expected to be another way to identify if the next connection
is a panel or a bridge?

Regards

--
Kieran


>         if (IS_ERR(pdata->next_bridge)) {
>                 DRM_ERROR("failed to create panel bridge\n");
>                 return PTR_ERR(pdata->next_bridge);
> --=20
> 2.25.1
>