Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3406089pxm; Mon, 28 Feb 2022 19:44:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqNvQDsUwEzC84GJsQG3KQqKb5sUPzzZwJ2lUwBdAVUdJtu0QKcOqOEnnuiqP5Xm0n2hNY X-Received: by 2002:a63:e249:0:b0:36c:4f1f:95e0 with SMTP id y9-20020a63e249000000b0036c4f1f95e0mr20139635pgj.381.1646106290619; Mon, 28 Feb 2022 19:44:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646106290; cv=none; d=google.com; s=arc-20160816; b=DZjbgVnJtBRY+8g0z/Lsv016I4FofuzWNLXOH0VxsO2+tazgP28zUoxHhai6onsj3H QDXJ4twtxDsRYr2uJhB3p7kP1snxP+RlOOAehBGuUF8sQkO607uPke74lFDPFLHA9yJw Ys3e9SzgT7JhNR5NfIWzhARWmEjiQHpYJGM8uqZWvXcklPoMcY3jwEIaNWhQg+9lyYBi Z5MrKhu/7nGAc+gxzOYizC17Rs+QjT53mO7TVkkBhrnTiYDxyc/jOQqoG9D0TfKHzAB2 ohWp/SMj/1LCjcl2GqTczUR833673phCZBgzj9yQ9gzXMpgM0DHJVwUZp11qV6Y4clVE dMSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=wzi1eHI9KMkDbH6ArAAmZ3kbYhpxihBN22v3wecHQJQ=; b=Npgdq45dfHyph5zroIQTFHZjy0BZrdHtqmZxjVNu1aCINMqTwcX3CY+TMBa1q/armJ VZs+BG08N7WAnl96uJNwiI0XDRTk0mLDsgY/vQ387mu+ciA/Hpin4n94Q7eXEMz/W8+5 r9dH2o6W2Ti0RaeDiTks4c7XUZZS9kmcUO0pSwOQgc3sE1zyQMN0KHxMF6dA5ZX7Cfpg T4ZoKBwbBgLn6ydUR10x9uf8lZWrRa2Dc8TcugPcb3zMk4ipcdYu+9mjC44IdaG7ioux WuxuthRaUa0cjFCvuXtnJ1HMQ3uV77lByjXvnN2Z64IyJppgTOgPSHqp3DTwlR2jFjZ3 QgpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z128-20020a636586000000b00372c8822108si10230718pgb.369.2022.02.28.19.44.34; Mon, 28 Feb 2022 19:44:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbiCACoc (ORCPT + 99 others); Mon, 28 Feb 2022 21:44:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230498AbiCACob (ORCPT ); Mon, 28 Feb 2022 21:44:31 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5CD369E6; Mon, 28 Feb 2022 18:43:50 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 10:43:48 +0800 Message-ID: Date: Tue, 1 Mar 2022 10:43:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot Content-Language: en-US To: Greg Kroah-Hartman , Dan Carpenter CC: , , , , Jiri Slaby , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , kernel test robot References: <20220228135530.6918-1-yu.tu@amlogic.com> <20220228142751.GF2812@kadam> From: Yu Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi greg and dan, Thank you very much for your reply. I will make a separate submission as you suggested to fix Dan's suggestion. On 2022/3/1 5:23, Greg Kroah-Hartman wrote: > [ EXTERNAL EMAIL ] > > On Mon, Feb 28, 2022 at 05:27:52PM +0300, Dan Carpenter wrote: >> On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote: >>> Describes the calculation of the UART baud rate clock using a clock >>> frame. Forgot to add in Kconfig kernel test Robot compilation error >>> due to COMMON_CLK dependency. >>> >>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frameā€œ) >>> Reported-by: kernel test robot >>> Reported-by: Dan Carpenter >>> Signed-off-by: Yu Tu >>> --- >>> drivers/tty/serial/Kconfig | 1 + >>> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++---------- >>> 2 files changed, 27 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >>> index e952ec5c7a7c..a0f2b82fc18b 100644 >>> --- a/drivers/tty/serial/Kconfig >>> +++ b/drivers/tty/serial/Kconfig >>> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI >>> config SERIAL_MESON >>> tristate "Meson serial port support" >>> depends on ARCH_MESON || COMPILE_TEST >>> + depends on COMMON_CLK >>> select SERIAL_CORE >>> help >>> This enables the driver for the on-chip UARTs of the Amlogic >> >> >> This is a link issue. The rest is an unrelated error handling fix. >> It should really be sent as two patches. > > I'll take the first version of this patch, which just did this portion, > and the rest can be an independant change. > > thanks, > > greg k-h >